Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for private endpoint in azurerm_storage_account #11628

Closed
yupwei68 opened this issue May 8, 2021 · 2 comments · Fixed by #11629
Closed

Support for private endpoint in azurerm_storage_account #11628

yupwei68 opened this issue May 8, 2021 · 2 comments · Fixed by #11629

Comments

@yupwei68
Copy link
Contributor

yupwei68 commented May 8, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Support for resource_access_rules in azurerm_storage_account.
You can use private endpoints for your Azure Storage accounts to allow clients on a virtual network (VNet) to securely access data over a Private Link. The private endpoint uses an IP address from the VNet address space for your storage account service. Network traffic between the clients on the VNet and the storage account traverses over the VNet and a private link on the Microsoft backbone network, eliminating exposure from the public internet.

New or Affected Resource(s)

  • azurerm_storage_account

Potential Terraform Configuration

resource "azurerm_storage_account" "test" {
  name                     = "unlikely23exst2acct%s"
  resource_group_name      = azurerm_resource_group.test.name
  location                 = azurerm_resource_group.test.location
  account_tier             = "Standard"
  account_replication_type = "LRS"

  network_rules {
    default_action             = "Deny"
    ip_rules                   = ["127.0.0.1"]
    virtual_network_subnet_ids = [azurerm_subnet.test.id]
    resource_access_rules {
      resource_id = azurerm_private_endpoint.test.id
    }
  }

  tags = {
    environment = "production"
  }
}

References

katbyte pushed a commit that referenced this issue May 12, 2021
Fix #11628

=== RUN TestAccStorageAccount_resourceAccessRules
=== PAUSE TestAccStorageAccount_resourceAccessRules
=== CONT TestAccStorageAccount_resourceAccessRules
--- PASS: TestAccStorageAccount_resourceAccessRules (465.11s)

=== RUN TestAccStorageAccountNetworkRules_resourceAccessRules
=== PAUSE TestAccStorageAccountNetworkRules_resourceAccessRules
=== CONT TestAccStorageAccountNetworkRules_resourceAccessRules
--- PASS: TestAccStorageAccountNetworkRules_resourceAccessRules (381.65s)
@katbyte katbyte added this to the v2.59.0 milestone May 12, 2021
@ghost
Copy link

ghost commented May 14, 2021

This has been released in version 2.59.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.59.0"
}
# ... other configuration ...

favoretti pushed a commit to gro1m/terraform-provider-azurerm that referenced this issue May 26, 2021
…corp#11629)

Fix hashicorp#11628

=== RUN TestAccStorageAccount_resourceAccessRules
=== PAUSE TestAccStorageAccount_resourceAccessRules
=== CONT TestAccStorageAccount_resourceAccessRules
--- PASS: TestAccStorageAccount_resourceAccessRules (465.11s)

=== RUN TestAccStorageAccountNetworkRules_resourceAccessRules
=== PAUSE TestAccStorageAccountNetworkRules_resourceAccessRules
=== CONT TestAccStorageAccountNetworkRules_resourceAccessRules
--- PASS: TestAccStorageAccountNetworkRules_resourceAccessRules (381.65s)
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants