-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading to v15 of the Azure SDK for Go #1077
Conversation
``` $ acctests azurerm TestAccAzureRMRoleAssignment === RUN TestAccAzureRMRoleAssignment === RUN TestAccAzureRMRoleAssignment/basic === RUN TestAccAzureRMRoleAssignment/basic/roleName === RUN TestAccAzureRMRoleAssignment/basic/builtin === RUN TestAccAzureRMRoleAssignment/basic/custom === RUN TestAccAzureRMRoleAssignment/basic/emptyName === RUN TestAccAzureRMRoleAssignment/import === RUN TestAccAzureRMRoleAssignment/import/basic === RUN TestAccAzureRMRoleAssignment/import/custom --- PASS: TestAccAzureRMRoleAssignment (446.84s) --- PASS: TestAccAzureRMRoleAssignment/basic (113.85s) --- PASS: TestAccAzureRMRoleAssignment/basic/roleName (32.06s) --- PASS: TestAccAzureRMRoleAssignment/basic/builtin (24.82s) --- PASS: TestAccAzureRMRoleAssignment/basic/custom (26.03s) --- PASS: TestAccAzureRMRoleAssignment/basic/emptyName (30.94s) --- PASS: TestAccAzureRMRoleAssignment/import (332.99s) --- PASS: TestAccAzureRMRoleAssignment/import/basic (30.90s) --- PASS: TestAccAzureRMRoleAssignment/import/custom (302.09s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 446.872s ```
``` $ acctests azurerm TestAccAzureRMTemplateDeployment_withOutputs === RUN TestAccAzureRMTemplateDeployment_withOutputs --- PASS: TestAccAzureRMTemplateDeployment_withOutputs (226.89s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 226.921s ```
Fixes #825 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Acceptance Tests look good 👍 |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Tasks:
Azure/azure-sdk-for-go
@ v15.0.0Determine what to do about Automation SDK: v15 of the Automation SDK doesn't compile Azure/azure-sdk-for-go#1512 - vendored the old version for now, temporarily@marstr is working on a fix in the SDKAzure/go-autorest
@ v10.6.0