Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v15 of the Automation SDK doesn't compile #1512

Closed
tombuildsstuff opened this issue Apr 5, 2018 · 3 comments
Closed

v15 of the Automation SDK doesn't compile #1512

tombuildsstuff opened this issue Apr 5, 2018 · 3 comments

Comments

@tombuildsstuff
Copy link
Contributor

👋

I've been trying to upgrade Terraform to use v15 of the Azure SDK - however I've encountered an error where the Automation SDK doesn't compile, either using the GA API/SDK version (2015-10-31) or using the Preview API version (2017-05-15-preview):

$ make
==> Checking that code complies with gofmt requirements...
go install
# github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/Azure/azure-sdk-for-go/services/automation/mgmt/2015-10-31/automation
vendor/github.com/Azure/azure-sdk-for-go/services/automation/mgmt/2015-10-31/automation/dscconfiguration.go:456:23: client.ResourceGroupName undefined (type DscConfigurationClient has no field or method ResourceGroupName)
vendor/github.com/Azure/azure-sdk-for-go/services/automation/mgmt/2015-10-31/automation/dscconfiguration.go:487:58: client.ResourceGroupName undefined (type DscConfigurationClient has no field or method ResourceGroupName)
vendor/github.com/Azure/azure-sdk-for-go/services/automation/mgmt/2015-10-31/automation/keys.go:40:34: too many arguments in call to NewWithBaseURI
	have (string, string, string)
	want (string, string)
vendor/github.com/Azure/azure-sdk-for-go/services/automation/mgmt/2015-10-31/automation/keys.go:48:23: client.ResourceGroupName undefined (type KeysClient has no field or method ResourceGroupName)
vendor/github.com/Azure/azure-sdk-for-go/services/automation/mgmt/2015-10-31/automation/keys.go:78:58: client.ResourceGroupName undefined (type KeysClient has no field or method ResourceGroupName)
make: *** [build] Error 2

From what I can see (where ResourceGroupName isn't on the Client) - this looks to be because of broken Swagger - but it would be possible for someone to take a look?

Thanks!
@tombuildsstuff tombuildsstuff mentioned this issue Apr 5, 2018
Merged
5 tasks
@vladbarosan
Copy link

Hi @tombuildsstuff there is a related issue #1487

marstr added a commit that referenced this issue Apr 5, 2018
@marstr
Fixing #1512 and #1487 (#1515)
068ec4d 
* Reverting CI def so build failures are detected.

* Fixing build problems with automation packages.

* Regenerating latest profile.

* Regenerating preview profile.

* Moving noop.go from test package.
@marstr
Copy link
Member

marstr commented Apr 5, 2018

This should be fixed. :)

@marstr marstr closed this as completed Apr 5, 2018
@tombuildsstuff tombuildsstuff mentioned this issue Apr 6, 2018
Merged
@tombuildsstuff
Copy link
Contributor Author

@marstr looks good at our end so far - thanks a lot :)

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tombuildsstuff @marstr @vladbarosan