Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new resource: azurerm_sentinel_data_connector_microsoft_cloud_app_security #10668

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Feb 20, 2021

new resource: azurerm_sentinel_data_connector_microsoft_cloud_app_security

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @magodo

Thanks for this PR - taking a look through whilst on the whole this is looking good I've left some minor comments inline - if we can fix those up then this should otherwise be good to merge 👍

Thanks!

@magodo magodo force-pushed the sentinel_dataconnector_microsoft_cloud_app_security branch from 3d4a36e to d28d3c2 Compare February 23, 2021 02:01
@magodo
Copy link
Collaborator Author

magodo commented Feb 23, 2021

@tombuildsstuff

Thank you for the comments! I've rebased the original commit onto your last merged base commit, and also have resolved the review comments except the etag one. Please take another review.

@magodo
Copy link
Collaborator Author

magodo commented Mar 1, 2021

The etag related code can be removed once: Azure/azure-rest-api-specs#13203 is resolved.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @magodo

Thanks for pushing those changes - I've taken a look through and left some comments inline but this is otherwise looking good 👍

Thanks!

@katbyte katbyte added this to the v2.51.0 milestone Mar 11, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@manicminer manicminer merged commit 1174556 into hashicorp:master Mar 11, 2021
manicminer added a commit that referenced this pull request Mar 11, 2021
@ghost
Copy link

ghost commented Mar 12, 2021

This has been released in version 2.51.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.51.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 10, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants