-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new resource: azurerm_sentinel_data_connector_microsoft_cloud_app_security
#10668
new resource: azurerm_sentinel_data_connector_microsoft_cloud_app_security
#10668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @magodo
Thanks for this PR - taking a look through whilst on the whole this is looking good I've left some minor comments inline - if we can fix those up then this should otherwise be good to merge 👍
Thanks!
azurerm/internal/services/sentinel/sentinel_data_connector_microsoft_cloud_app_security.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/sentinel/sentinel_data_connector_microsoft_cloud_app_security.go
Show resolved
Hide resolved
azurerm/internal/services/sentinel/sentinel_data_connector_microsoft_cloud_app_security.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/sentinel/sentinel_data_connector_microsoft_cloud_app_security.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/sentinel/sentinel_data_connector_microsoft_cloud_app_security.go
Outdated
Show resolved
Hide resolved
website/docs/r/sentinel_data_connector_microsoft_cloud_app_security.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/sentinel_data_connector_microsoft_cloud_app_security.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/sentinel_data_connector_microsoft_cloud_app_security.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/sentinel_data_connector_microsoft_cloud_app_security.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/sentinel_data_connector_microsoft_cloud_app_security.html.markdown
Outdated
Show resolved
Hide resolved
3d4a36e
to
d28d3c2
Compare
Thank you for the comments! I've rebased the original commit onto your last merged base commit, and also have resolved the review comments except the etag one. Please take another review. |
The etag related code can be removed once: Azure/azure-rest-api-specs#13203 is resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @magodo
Thanks for pushing those changes - I've taken a look through and left some comments inline but this is otherwise looking good 👍
Thanks!
azurerm/internal/services/sentinel/sentinel_data_connector_microsoft_cloud_app_security.go
Show resolved
Hide resolved
website/docs/r/sentinel_data_connector_microsoft_cloud_app_security.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/sentinel_data_connector_microsoft_cloud_app_security.html.markdown
Outdated
Show resolved
Hide resolved
…ector_microsoft_cloud_app_security
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
…ector_microsoft_cloud_app_security
website/docs/r/sentinel_data_connector_microsoft_cloud_app_security.html.markdown
Show resolved
Hide resolved
…urity.html.markdown
This has been released in version 2.51.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.51.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
new resource:
azurerm_sentinel_data_connector_microsoft_cloud_app_security