Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sentinel RP: empty etag should be accepted for "update" APIs #13203

Closed
magodo opened this issue Mar 1, 2021 · 6 comments
Closed

Sentinel RP: empty etag should be accepted for "update" APIs #13203

magodo opened this issue Mar 1, 2021 · 6 comments
Labels
Sentinel Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@magodo
Copy link
Contributor

magodo commented Mar 1, 2021

Currently, etag is required for updating most sentinel related resources. This violates the practice followed by ARM that etag should be optional.

Confirmed with Sentinel service team that this is currently under implementation. This issue is for the sake of tracking the progress.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 1, 2021
This was referenced Mar 1, 2021
Merged
Merged
Merged
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 2, 2021
@akning-ms akning-ms added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. Service Attention Workflow: This issue is responsible by Azure service team. labels Mar 2, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 2, 2021
@tombuildsstuff
Copy link
Contributor

@magodo any news on this one?

@tombuildsstuff
Copy link
Contributor

ping @akning-ms

@tombuildsstuff
Copy link
Contributor

ping @akning-ms

@magodo
Copy link
Contributor Author

magodo commented Apr 18, 2022 •
edited
Loading

@tombuildsstuff I just locally tested again, it appears the etag is now (at least for 2021-09-01-preview) optional for updating a data connector/ an alert rule.

@dosegal Can you please confirm that etag is now optional for updating all sentinel resources?

magodo added a commit to magodo/terraform-provider-azurerm that referenced this issue Apr 18, 2022
@magodo
sentinel - removing setting etag before updating it
40274e6 
Previously, sentinel API requires an `etag` is set in the update request (`PUT`), which is trakced in Azure/azure-rest-api-specs#13203. While it appears this is not a must now, which aligns with ARM's expectation that `etag` should be optional.
@magodo magodo mentioned this issue Apr 18, 2022
Merged
@dosegal
Copy link
Contributor

dosegal commented Apr 24, 2022

@magodo as far as I'm aware, etag is now optional for updating in all available API versions (and it's true that this wasn't the case when the issue was opened).

@magodo
Copy link
Contributor Author

magodo commented Apr 25, 2022

Closing this issue per @dosegal's reply.

@magodo magodo closed this as completed Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Sentinel Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tombuildsstuff @magodo @dosegal @akning-ms