Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Azure High Availability Ports #372

Closed
hashibot opened this issue Sep 29, 2017 · 11 comments
Closed

Feature Request: Azure High Availability Ports #372

hashibot opened this issue Sep 29, 2017 · 11 comments
Labels
enhancement service/load-balancers upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR

Comments

@hashibot
Copy link

This issue was originally opened by @robrankin as hashicorp/terraform#16215. It was migrated here as a result of the provider split. The original body of the issue is below.


Microsoft has just announced the Preview availability of a "High Availability Ports" for the Azure Load Balancer:

https://docs.microsoft.com/en-us/azure/load-balancer/load-balancer-ha-ports-overview

It's a pretty great addition to the LB, would be extremely useful to have it exposed in Terraform.

@justaugustus
Copy link
Contributor

@metacpp pinging you on this one, as you assigned yourself to #579.

@TechyMatt
Copy link
Contributor

Is there any chance this feature is scoped for implementation? It's the last piece of my vDC Terraform implementation and saves me creating hundreds of rules on my load balancer in front of next-gen firewalls.

@tombuildsstuff tombuildsstuff changed the title Azure High Availability Ports feature request Feature Request: Azure High Availability Ports Feb 26, 2018
@katbyte katbyte added upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR and removed upstream labels May 17, 2018
@katbyte
Copy link
Collaborator

katbyte commented May 17, 2018

Hi @justaugustus,

Thanks for the issue, but we are unfortunately still waiting on the GO SDK for Azure to support this.

@EtienneDeneuve
Copy link
Contributor

From our side, we have successfully deployed a Azure Load Balancer with HA Ports with the following configuration :

resource "azurerm_lb_rule" "lb_haports_rule" {
  backend_port = 0
  frontend_ip_configuration_name = "${azurerm_lb.private-lb-gateway.frontend_ip_configuration.0.name}"
  frontend_port = 0
  loadbalancer_id = "${azurerm_lb.private-lb-gateway.id}"
  name = "lb_haports_rule"
  protocol = "All"
  backend_address_pool_id = "${azurerm_lb_backend_address_pool.gateway_backend_pool.id}"
  probe_id = "${azurerm_lb_probe.lb_gateway_probe_fw.id}"
  resource_group_name          = "${var.resource_group_name}"
}

And it's working ! We simply add "All" in protocol.

@asubmani
Copy link
Contributor

@EtienneDeneuve .. Terraform 0.11.8 throws an error when I run the workaround config. The error is
"backend_port is not a valid port number: 'x00'
My config looks like:

resource "azurerm_lb_rule" "lb_haports_rule" {
  protocol = "All"
  backend_port = 0
  frontend_ip_configuration_name = "${azurerm_lb.ilbmain.frontend_ip_configuration.0.name}"
  frontend_port = 0
  loadbalancer_id = "${azurerm_lb.ilbmain.id}"
  name = "lb_haports_rule"  
  backend_address_pool_id = "${azurerm_lb_backend_address_pool.ILB2PaloAlto.id}"
  probe_id = "${azurerm_lb_probe.paloalto_probe.id}"
  resource_group_name  = "${data.azurerm_resource_group.pa-rg.name}"
}

@steffencircle
Copy link

Hi,
just bumped into the same issue and also for me the workaround is no longer working.

What surprises me is that the referenced issue for the go-sdk is also closed !
Can somebody please have a look to see how this can be done.

@DYNSOL
Copy link

DYNSOL commented Sep 14, 2018

I'm also getting

"backend_port is not a valid port number: 'x00'

Yet if you leave it to "All" and put in a port it moans that it must be set to 0, which then errors.

Message="A rule that supports any port and protocol load balancing must have the following settings: FrontendPort: 0, BackendPort: 0, and Protocol: Protocol.All.

@katbyte
Copy link
Collaborator

katbyte commented Sep 19, 2018

@DYNSOL, @lw81, @asubmani

Additional validation was added to this resource breaking the workaround. I have opened #1951 to allow 0 for the ports again.

@steffencircle
Copy link

steffencircle commented Sep 21, 2018 via email

@tombuildsstuff
Copy link
Contributor

Fixed via #1951

@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement service/load-balancers upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Projects
None yet
Development

No branches or pull requests