Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Microsoft.Cache for Redis API v2024-03-01 #26797

Closed
1 task done
koderjoker opened this issue Jul 26, 2024 · 1 comment · Fixed by #27039
Closed
1 task done

Support for Microsoft.Cache for Redis API v2024-03-01 #26797

koderjoker opened this issue Jul 26, 2024 · 1 comment · Fixed by #27039
Labels
enhancement sdk/requires-newer-api-version This requires upgrading the version of the API being used service/redis
Milestone
v4.0.0

Comments

@koderjoker
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment and review the contribution guide to help.

Description

Please update terraform with latest API v2024-03-01 of Microsoft Azure Cache for Redis.

New api version introduces feature to disable access keys authentication for an Azure Cache for Redis instance (properties.disableAccessKeyAuthentication)
https://learn.microsoft.com/en-us/rest/api/redis/redis/create?view=rest-redis-2024-03-01&tabs=HTTP
https://learn.microsoft.com/en-us/rest/api/redis/redis/update?view=rest-redis-2024-03-01&tabs=HTTP

New or Affected Resource(s)/Data Source(s)

azurerm_redis_cache

Potential Terraform Configuration

No response

References

https://learn.microsoft.com/en-us/rest/api/redis/redis?view=rest-redis-2024-03-01
@mybayern1974 mybayern1974 added the sdk/requires-newer-api-version This requires upgrading the version of the API being used label Jul 29, 2024
@koderjoker koderjoker changed the title Support for Microsoft.Cache for Redis API v2023-08-01 Support for Microsoft.Cache for Redis API v2024-03-01 Jul 29, 2024
gerrytan pushed a commit to gerrytan/terraform-provider-azurerm that referenced this issue Aug 5, 2024
Updated go-azure-sdk/resource-manager/redis from 2023-08-01 to 2024-0…
b411139 
…3-01 (hashicorp#26797)
@gerrytan gerrytan mentioned this issue Aug 5, 2024
Merged
17 tasks
magodo pushed a commit that referenced this issue Aug 7, 2024
@gerrytan
Updated go-azure-sdk/resource-manager/redis from 2023-08-01 to 2024-0…
af7a4a9 
…3-01 (#26797) (#26932)

Co-authored-by: Gerry Tan <[email protected]>
gerrytan pushed a commit to gerrytan/terraform-provider-azurerm that referenced this issue Aug 8, 2024
hashicorp#26797: disable_access_keys_authentication property for Redi…
13b49a8 
…s Cache
gerrytan pushed a commit to gerrytan/terraform-provider-azurerm that referenced this issue Aug 14, 2024
@gerrytan
azurerm_redis_cache: access_keys_authentication_disabled property (ha…
199cea6 
…shicorp#26797)
gerrytan added a commit to gerrytan/terraform-provider-azurerm that referenced this issue Aug 14, 2024
@gerrytan
azurerm_redis_cache: access_keys_authentication_disabled property (ha…
5201b0a 
…shicorp#26797)
@gerrytan gerrytan mentioned this issue Aug 14, 2024
Merged
14 tasks
gerrytan added a commit to gerrytan/terraform-provider-azurerm that referenced this issue Aug 19, 2024
@gerrytan
azurerm_redis_cache: access_keys_authentication_disabled property (ha…
6ebbc0e 
…shicorp#26797)
stephybun pushed a commit that referenced this issue Aug 21, 2024
@gerrytan @magodo
azurerm_redis_cache - support access_keys_authentication_disabled pro…
ca742ee 
…perty (#27039)

* azurerm_redis_cache: access_keys_authentication_disabled property (#26797)

* Fix tflint and unused test func arg

* Update website/docs/d/redis_cache.html.markdown

Co-authored-by: magodo <[email protected]>

* Inlined access keys auth validation into CustomizeDiff

* Improved docs grammar for access_keys_authentication_disabled

* Further improvement on website/docs/r/redis_cache.html.markdown

* Improved debug log message

Co-authored-by: magodo <[email protected]>

* Improved error message

Co-authored-by: magodo <[email protected]>

* Flip prop into _enabled

To comply with Hashicorp contrib guide

* Fix linting error on redis_cache_resource_test.go

* Added nil check on redis_cache_data_source.go

Co-authored-by: magodo <[email protected]>

* Formatting on redis_cache_data_source.go

* More nil check and boolean prop flipping on redis_cache_resource.go

* PR feedback: use pointer.From

* Removed redundant nil check

---------

Co-authored-by: magodo <[email protected]>
@github-actions github-actions bot added this to the v3.117.0 milestone Aug 21, 2024
@stephybun stephybun modified the milestones: v3.117.0, v4.0.0 Aug 21, 2024
@github-actions GitHub Actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement sdk/requires-newer-api-version This requires upgrading the version of the API being used service/redis
Projects
None yet
Milestone
v4.0.0
4 participants
@mybayern1974 @stephybun @koderjoker @rcskosir