Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]aws_finspace_kx_volume #34833

Merged
merged 13 commits into from
Dec 14, 2023
Merged

Conversation

hiranimd
Copy link
Contributor

@hiranimd hiranimd commented Dec 8, 2023

Description

Introduces a new resource for finspace_kx_volume. Includes resource handlers, tests, and documentation changes.

Relations

Relates #34831

References

https://github.com/aws/aws-sdk-go-v2/tree/main/service/finspace
https://docs.aws.amazon.com/finspace/latest/userguide/finspace-managed-kdb.html

Output from Acceptance Testing

% make testacc TESTS=TestAccFinSpaceKxVolume PKG=finspace
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxVolume'  -timeout 360m
=== RUN   TestAccFinSpaceKxVolume_basic
=== PAUSE TestAccFinSpaceKxVolume_basic
=== RUN   TestAccFinSpaceKxVolume_dissappears
=== PAUSE TestAccFinSpaceKxVolume_dissappears
=== CONT  TestAccFinSpaceKxVolume_basic
=== CONT  TestAccFinSpaceKxVolume_dissappears
--- PASS: TestAccFinSpaceKxVolume_basic (1904.35s)
--- PASS: TestAccFinSpaceKxVolume_dissappears (1922.58s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/finspace   1928.129s

...

Copy link

github-actions bot commented Dec 8, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/finspace Issues and PRs that pertain to the finspace service. labels Dec 8, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 8, 2023
@hiranimd hiranimd changed the title Push all kx volume changes for PR. [New Resource]aws_finspace_kx_volume Dec 8, 2023
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 12, 2023
@jar-b jar-b added the partner Contribution from a partner. label Dec 13, 2023
@jar-b jar-b self-assigned this Dec 14, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 14, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc TESTS=TestAccFinSpaceKxVolume_ PKG=finspace ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 1 -run='TestAccFinSpaceKxVolume_'  -timeout 360m
=== RUN   TestAccFinSpaceKxVolume_basic
=== PAUSE TestAccFinSpaceKxVolume_basic
=== RUN   TestAccFinSpaceKxVolume_disappears
=== PAUSE TestAccFinSpaceKxVolume_disappears
=== RUN   TestAccFinSpaceKxVolume_tags
=== PAUSE TestAccFinSpaceKxVolume_tags
=== CONT  TestAccFinSpaceKxVolume_basic
--- PASS: TestAccFinSpaceKxVolume_basic (1704.73s)
=== CONT  TestAccFinSpaceKxVolume_tags
    kx_volume_test.go:101: Step 1/4 error: Error running apply: exit status 1

        Error: waiting for creation Amazon FinSpace Kx Volume (q3ddjdtnmiyvwpkkcqo4ey,tf-acc-test-3386223232616498069): unexpected state 'CREATE_FAILED', wanted target 'ACTIVE'. last error: %!s(<nil>)

          with aws_finspace_kx_volume.test,
          on terraform_plugin_test.tf line 118, in resource "aws_finspace_kx_volume" "test":
         118: resource "aws_finspace_kx_volume" "test" {

    testing_new.go:91: Error running post-test destroy, there may be dangling resources: exit status 1

        Error: waiting for delete Amazon FinSpace Kx Environment (q3ddjdtnmiyvwpkkcqo4ey): timeout while waiting for resource to be gone (last state: 'DELETING', timeout: 1h15m0s)

--- FAIL: TestAccFinSpaceKxVolume_tags (5014.65s)
=== CONT  TestAccFinSpaceKxVolume_disappears
--- PASS: TestAccFinSpaceKxVolume_disappears (1720.39s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/finspace   8443.002s

In a separate run:

% make testacc TESTS=TestAccFinSpaceKxVolume_tags PKG=finspace ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 1 -run='TestAccFinSpaceKxVolume_tags'  -timeout 360m
=== RUN   TestAccFinSpaceKxVolume_tags
=== PAUSE TestAccFinSpaceKxVolume_tags
=== CONT  TestAccFinSpaceKxVolume_tags
--- PASS: TestAccFinSpaceKxVolume_tags (1626.74s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/finspace   1630.055s

@jar-b jar-b merged commit bbe6c9d into hashicorp:main Dec 14, 2023
43 checks passed
@github-actions github-actions bot added this to the v5.31.0 milestone Dec 14, 2023
@jar-b
Copy link
Member

jar-b commented Dec 14, 2023

Thanks for your contribution, @hiranimd!

Copy link

This functionality has been released in v5.31.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/finspace Issues and PRs that pertain to the finspace service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants