Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for aws_finspace_dataview, aws_finspace_scaling_group & aws_finspace_volume for aws_finspace_cluster #34831

Merged
merged 10 commits into from
Dec 15, 2023

Conversation

ItsYou
Copy link
Contributor

@ItsYou ItsYou commented Dec 8, 2023

Description

Adds support for new resources aws_finspace_dataview, aws_finspace_scaling_group & aws_finspace_volume to kx clusters. Includes acceptance tests & documentation changes.

Relations

Relates #34828
Relates #34832
Relates #34833

References

Output from Acceptance Testing

% make testacc TESTS=TestAccFinSpaceKxRDBClusterInScalingGroup_withKxVolume PKG=finspace
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxRDBClusterInScalingGroup_withKxVolume'  -timeout 360m
=== RUN   TestAccFinSpaceKxRDBClusterInScalingGroup_withKxVolume
=== PAUSE TestAccFinSpaceKxRDBClusterInScalingGroup_withKxVolume
=== CONT  TestAccFinSpaceKxRDBClusterInScalingGroup_withKxVolume
--- PASS: TestAccFinSpaceKxRDBClusterInScalingGroup_withKxVolume (6596.63s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/finspace   6601.916s

% make testacc TESTS=TestAccFinSpaceKxTPClusterInScalingGroup_withKxVolume PKG=finspace
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxTPClusterInScalingGroup_withKxVolume'  -timeout 360m
=== RUN   TestAccFinSpaceKxTPClusterInScalingGroup_withKxVolume
=== PAUSE TestAccFinSpaceKxTPClusterInScalingGroup_withKxVolume
=== CONT  TestAccFinSpaceKxTPClusterInScalingGroup_withKxVolume
--- PASS: TestAccFinSpaceKxTPClusterInScalingGroup_withKxVolume (6526.03s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/finspace   6531.519s

% make testacc TESTS=TestAccFinSpaceKxClusterInScalingGroup_withKxDataview PKG=finspace
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxClusterInScalingGroup_withKxDataview'  -timeout 360m
=== RUN   TestAccFinSpaceKxClusterInScalingGroup_withKxDataview
=== PAUSE TestAccFinSpaceKxClusterInScalingGroup_withKxDataview
=== CONT  TestAccFinSpaceKxClusterInScalingGroup_withKxDataview
--- PASS: TestAccFinSpaceKxClusterInScalingGroup_withKxDataview (3884.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	3890.041s

Copy link

github-actions bot commented Dec 8, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/finspace Issues and PRs that pertain to the finspace service. labels Dec 8, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 8, 2023
@ItsYou ItsYou marked this pull request as ready for review December 8, 2023 22:09
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 12, 2023
@jar-b jar-b added the partner Contribution from a partner. label Dec 13, 2023
internal/service/finspace/kx_cluster_test.go Outdated Show resolved Hide resolved
internal/service/finspace/kx_cluster_test.go Outdated Show resolved Hide resolved
internal/service/finspace/kx_cluster_test.go Outdated Show resolved Hide resolved
internal/service/finspace/kx_cluster_test.go Outdated Show resolved Hide resolved
internal/service/finspace/kx_cluster_test.go Outdated Show resolved Hide resolved
@jar-b jar-b self-assigned this Dec 14, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 14, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ItsYou
Copy link
Contributor Author

ItsYou commented Dec 15, 2023

% make testacc TESTS=TestAccFinSpaceKxCluster_InScalingGroupWithKxDataview PKG=finspace
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 1 -run='TestAccFinSpaceKxCluster_InScalingGroupWithKxDataview'  -timeout 360m
=== RUN   TestAccFinSpaceKxCluster_InScalingGroupWithKxDataview
=== PAUSE TestAccFinSpaceKxCluster_InScalingGroupWithKxDataview
=== CONT  TestAccFinSpaceKxCluster_InScalingGroupWithKxDataview
--- PASS: TestAccFinSpaceKxCluster_InScalingGroupWithKxDataview (3953.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	3958.327s

@jar-b jar-b merged commit 945df7b into hashicorp:main Dec 15, 2023
62 checks passed
@github-actions github-actions bot added this to the v5.31.0 milestone Dec 15, 2023
Copy link

This functionality has been released in v5.31.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/finspace Issues and PRs that pertain to the finspace service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants