Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_rds_cluster: Fix RDS Cluster acceptance test #30655

Merged
merged 4 commits into from
Apr 12, 2023
Merged

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Apr 11, 2023

Description

The only engine modes now available are serverless and provisioned

Parallel query is now configured using parameter groups: https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/aurora-mysql-parallel-query.html#aurora-mysql-parallel-query-enabling

  • remove multimaster engine mode test
  • remove parallelquery engine mode test

Relations

Closes #30355

References

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccRDSCluster_' PKG=rds

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20  -run=estAccRDSCluster_ -timeout 180m
    cluster_test.go:1871: serverless does not support snapshot restore on an empty volume
--- SKIP: TestAccRDSCluster_SnapshotIdentifierEngineMode_serverless (0.00s)
--- PASS: TestAccRDSCluster_ManagedMasterPassword_managed (152.96s)
--- PASS: TestAccRDSCluster_basic (182.52s)
--- PASS: TestAccRDSCluster_port (188.75s)
--- PASS: TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey (191.24s)
--- PASS: TestAccRDSCluster_ManagedMasterPassword_convertToManaged (212.75s)
--- PASS: TestAccRDSCluster_password (219.23s)
--- PASS: TestAccRDSCluster_serverlessV2ScalingConfiguration (221.36s)
--- PASS: TestAccRDSCluster_Scaling_defaultMinCapacity (283.00s)
--- PASS: TestAccRDSCluster_deletionProtection (175.35s)
--- PASS: TestAccRDSCluster_iamAuth (147.36s)
--- PASS: TestAccRDSCluster_enableHTTPEndpoint (344.34s)
--- PASS: TestAccRDSCluster_encrypted (126.28s)
--- PASS: TestAccRDSCluster_missingUserNameCausesError (5.49s)
--- PASS: TestAccRDSCluster_backupsUpdate (200.01s)
--- PASS: TestAccRDSCluster_engineMode (516.49s)
--- PASS: TestAccRDSCluster_pointInTimeRestore (436.39s)
--- PASS: TestAccRDSCluster_copyTagsToSnapshot (228.10s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow (442.55s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow (442.55s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_encryptedRestore (442.57s)
--- PASS: TestAccRDSCluster_kmsKey (161.36s)
--- PASS: TestAccRDSCluster_snapshotIdentifier (455.28s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_tags (456.48s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs (460.37s)
--- PASS: TestAccRDSCluster_engineVersion (467.31s)
--- PASS: TestAccRDSCluster_updateIAMRoles (179.72s)
--- PASS: TestAccRDSCluster_networkType (273.31s)
--- PASS: TestAccRDSCluster_dbSubnetGroupName (162.00s)
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL (224.26s)
--- PASS: TestAccRDSCluster_availabilityZones (147.58s)
--- PASS: TestAccRDSCluster_takeFinalSnapshot (267.06s)
--- PASS: TestAccRDSCluster_backtrackWindow (205.79s)
--- PASS: TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags (738.96s)
--- PASS: TestAccRDSCluster_identifierGenerated (163.57s)
--- PASS: TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports (430.12s)
--- PASS: TestAccRDSCluster_identifierPrefix (142.90s)
--- PASS: TestAccRDSCluster_scaling (317.57s)
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal (417.80s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update (162.32s)
--- PASS: TestAccRDSCluster_tags (202.04s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_masterUsername (446.71s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_masterPassword (444.52s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_kmsKeyID (455.31s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add (140.49s)
--- PASS: TestAccRDSCluster_disappears (172.35s)
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned (435.65s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned (207.94s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_deletionProtection (425.14s)
--- PASS: TestAccRDSCluster_onlyMajorVersion (860.51s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove (166.24s)
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineVersion_different (464.20s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global (180.68s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeNoApplyImmediately (1319.91s)
--- PASS: TestAccRDSCluster_allocatedStorage (1906.64s)
--- PASS: TestAccRDSCluster_dbClusterInstanceClass (1941.02s)
--- PASS: TestAccRDSCluster_iops (1957.25s)
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql (2210.69s)
--- PASS: TestAccRDSCluster_storageType (2128.88s)
--- PASS: TestAccRDSCluster_engineVersionWithPrimaryInstance (1403.79s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgrade (2256.03s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters (2369.18s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm (2374.70s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding (2981.50s)
--- PASS: TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID (2028.98s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier (2542.82s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters (2807.12s)
...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 11, 2023
@johnsonaj johnsonaj changed the title r/aws_rds_cluster: include engine in every test r/aws_rds_cluster: Fix RDS Cluster acceptance test Apr 11, 2023
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Apr 11, 2023
@johnsonaj johnsonaj marked this pull request as ready for review April 11, 2023 21:58
@johnsonaj johnsonaj added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Apr 11, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc TESTARGS='-run=TestAccRDSCluster_' PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20  -run=TestAccRDSCluster_ -timeout 180m
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned (164.23s)
=== CONT  TestAccRDSCluster_engineVersionWithPrimaryInstance
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global (186.15s)
=== CONT  TestAccRDSCluster_backtrackWindow
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update (199.84s)
=== CONT  TestAccRDSCluster_dbSubnetGroupName
--- PASS: TestAccRDSCluster_ManagedMasterPassword_managed (216.34s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add (219.21s)
=== CONT  TestAccRDSCluster_password
--- PASS: TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey (221.78s)
=== CONT  TestAccRDSCluster_enableHTTPEndpoint
--- PASS: TestAccRDSCluster_port (223.06s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_encryptedRestore
--- PASS: TestAccRDSCluster_basic (225.08s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags
--- PASS: TestAccRDSCluster_ManagedMasterPassword_convertToManaged (265.26s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove (336.13s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_tags
--- PASS: TestAccRDSCluster_serverlessV2ScalingConfiguration (366.14s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow
--- PASS: TestAccRDSCluster_dbSubnetGroupName (172.59s)
=== CONT  TestAccRDSCluster_iops
--- PASS: TestAccRDSCluster_Scaling_defaultMinCapacity (376.15s)
=== CONT  TestAccRDSCluster_dbClusterInstanceClass
--- PASS: TestAccRDSCluster_pointInTimeRestore (404.61s)
=== CONT  TestAccRDSCluster_storageType
--- PASS: TestAccRDSCluster_scaling (415.90s)
=== CONT  TestAccRDSCluster_kmsKey
--- PASS: TestAccRDSCluster_backtrackWindow (234.07s)
=== CONT  TestAccRDSCluster_missingUserNameCausesError
--- PASS: TestAccRDSCluster_missingUserNameCausesError (4.84s)
=== CONT  TestAccRDSCluster_takeFinalSnapshot
--- PASS: TestAccRDSCluster_password (213.57s)
=== CONT  TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports
--- PASS: TestAccRDSCluster_snapshotIdentifier (484.61s)
=== CONT  TestAccRDSCluster_availabilityZones
--- PASS: TestAccRDSCluster_engineVersion (491.23s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal
--- PASS: TestAccRDSCluster_kmsKey (159.87s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_masterPassword
--- PASS: TestAccRDSCluster_availabilityZones (165.49s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_kmsKeyID
--- PASS: TestAccRDSCluster_enableHTTPEndpoint (428.40s)
=== CONT  TestAccRDSCluster_allowMajorVersionUpgrade
--- PASS: TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow (446.21s)
=== CONT  TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters
--- PASS: TestAccRDSCluster_takeFinalSnapshot (265.73s)
=== CONT  TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm
--- PASS: TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags (470.03s)
=== CONT  TestAccRDSCluster_allowMajorVersionUpgradeNoApplyImmediately
--- PASS: TestAccRDSCluster_SnapshotIdentifier_encryptedRestore (475.56s)
=== CONT  TestAccRDSCluster_backupsUpdate
--- PASS: TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs (440.00s)
=== CONT  TestAccRDSCluster_engineMode
--- PASS: TestAccRDSCluster_SnapshotIdentifier_tags (476.30s)
=== CONT  TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL
--- PASS: TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow (467.44s)
=== CONT  TestAccRDSCluster_updateIAMRoles
--- PASS: TestAccRDSCluster_onlyMajorVersion (848.30s)
=== CONT  TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
--- PASS: TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports (448.33s)
=== CONT  TestAccRDSCluster_copyTagsToSnapshot
--- PASS: TestAccRDSCluster_backupsUpdate (203.07s)
=== CONT  TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal (447.68s)
=== CONT  TestAccRDSCluster_identifierGenerated
--- PASS: TestAccRDSCluster_SnapshotIdentifier_masterPassword (424.92s)
=== CONT  TestAccRDSCluster_identifierPrefix
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL (221.90s)
=== CONT  TestAccRDSCluster_allocatedStorage
--- PASS: TestAccRDSCluster_updateIAMRoles (205.72s)
=== CONT  TestAccRDSCluster_iamAuth
--- PASS: TestAccRDSCluster_identifierGenerated (144.23s)
=== CONT  TestAccRDSCluster_encrypted
--- PASS: TestAccRDSCluster_SnapshotIdentifier_kmsKeyID (466.94s)
=== CONT  TestAccRDSCluster_tags
--- PASS: TestAccRDSCluster_copyTagsToSnapshot (252.40s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned
--- PASS: TestAccRDSCluster_engineMode (478.79s)
=== CONT  TestAccRDSCluster_networkType
--- PASS: TestAccRDSCluster_identifierPrefix (194.42s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_deletionProtection
--- PASS: TestAccRDSCluster_iamAuth (163.30s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_masterUsername
--- PASS: TestAccRDSCluster_encrypted (153.41s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierEngineVersion_different
--- PASS: TestAccRDSCluster_tags (202.31s)
=== CONT  TestAccRDSCluster_deletionProtection
--- PASS: TestAccRDSCluster_networkType (207.62s)
=== CONT  TestAccRDSCluster_disappears
--- PASS: TestAccRDSCluster_deletionProtection (192.73s)
--- PASS: TestAccRDSCluster_disappears (171.82s)
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned (445.49s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeNoApplyImmediately (885.49s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_masterUsername (415.60s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_deletionProtection (466.24s)
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineVersion_different (426.71s)
--- PASS: TestAccRDSCluster_engineVersionWithPrimaryInstance (1598.25s)
--- PASS: TestAccRDSCluster_dbClusterInstanceClass (1854.39s)
--- PASS: TestAccRDSCluster_iops (1862.95s)
--- PASS: TestAccRDSCluster_storageType (1944.47s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier (2587.26s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters (2666.92s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters (2173.67s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding (2920.00s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgrade (2269.77s)
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql (2177.63s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm (2363.33s)
--- PASS: TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID (2201.64s)
--- PASS: TestAccRDSCluster_allocatedStorage (2076.80s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        3117.034s

@johnsonaj johnsonaj merged commit 51ac97f into main Apr 12, 2023
@johnsonaj johnsonaj deleted the td-fix-rds-tests branch April 12, 2023 14:36
@github-actions github-actions bot added this to the v4.63.0 milestone Apr 12, 2023
@github-actions
Copy link

This functionality has been released in v4.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/rds Issues and PRs that pertain to the rds service. size/L Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace RDS Aurora Version 1 (MySQL 5.6) engine version in acceptance tests
2 participants