-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_rds_cluster: Fix RDS Cluster acceptance test #30655
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
$ make testacc TESTARGS='-run=TestAccRDSCluster_' PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run=TestAccRDSCluster_ -timeout 180m
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned (164.23s)
=== CONT TestAccRDSCluster_engineVersionWithPrimaryInstance
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global (186.15s)
=== CONT TestAccRDSCluster_backtrackWindow
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update (199.84s)
=== CONT TestAccRDSCluster_dbSubnetGroupName
--- PASS: TestAccRDSCluster_ManagedMasterPassword_managed (216.34s)
=== CONT TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add (219.21s)
=== CONT TestAccRDSCluster_password
--- PASS: TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey (221.78s)
=== CONT TestAccRDSCluster_enableHTTPEndpoint
--- PASS: TestAccRDSCluster_port (223.06s)
=== CONT TestAccRDSCluster_SnapshotIdentifier_encryptedRestore
--- PASS: TestAccRDSCluster_basic (225.08s)
=== CONT TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags
--- PASS: TestAccRDSCluster_ManagedMasterPassword_convertToManaged (265.26s)
=== CONT TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove (336.13s)
=== CONT TestAccRDSCluster_SnapshotIdentifier_tags
--- PASS: TestAccRDSCluster_serverlessV2ScalingConfiguration (366.14s)
=== CONT TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow
--- PASS: TestAccRDSCluster_dbSubnetGroupName (172.59s)
=== CONT TestAccRDSCluster_iops
--- PASS: TestAccRDSCluster_Scaling_defaultMinCapacity (376.15s)
=== CONT TestAccRDSCluster_dbClusterInstanceClass
--- PASS: TestAccRDSCluster_pointInTimeRestore (404.61s)
=== CONT TestAccRDSCluster_storageType
--- PASS: TestAccRDSCluster_scaling (415.90s)
=== CONT TestAccRDSCluster_kmsKey
--- PASS: TestAccRDSCluster_backtrackWindow (234.07s)
=== CONT TestAccRDSCluster_missingUserNameCausesError
--- PASS: TestAccRDSCluster_missingUserNameCausesError (4.84s)
=== CONT TestAccRDSCluster_takeFinalSnapshot
--- PASS: TestAccRDSCluster_password (213.57s)
=== CONT TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports
--- PASS: TestAccRDSCluster_snapshotIdentifier (484.61s)
=== CONT TestAccRDSCluster_availabilityZones
--- PASS: TestAccRDSCluster_engineVersion (491.23s)
=== CONT TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal
--- PASS: TestAccRDSCluster_kmsKey (159.87s)
=== CONT TestAccRDSCluster_SnapshotIdentifier_masterPassword
--- PASS: TestAccRDSCluster_availabilityZones (165.49s)
=== CONT TestAccRDSCluster_SnapshotIdentifier_kmsKeyID
--- PASS: TestAccRDSCluster_enableHTTPEndpoint (428.40s)
=== CONT TestAccRDSCluster_allowMajorVersionUpgrade
--- PASS: TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow (446.21s)
=== CONT TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters
--- PASS: TestAccRDSCluster_takeFinalSnapshot (265.73s)
=== CONT TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm
--- PASS: TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags (470.03s)
=== CONT TestAccRDSCluster_allowMajorVersionUpgradeNoApplyImmediately
--- PASS: TestAccRDSCluster_SnapshotIdentifier_encryptedRestore (475.56s)
=== CONT TestAccRDSCluster_backupsUpdate
--- PASS: TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs (440.00s)
=== CONT TestAccRDSCluster_engineMode
--- PASS: TestAccRDSCluster_SnapshotIdentifier_tags (476.30s)
=== CONT TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL
--- PASS: TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow (467.44s)
=== CONT TestAccRDSCluster_updateIAMRoles
--- PASS: TestAccRDSCluster_onlyMajorVersion (848.30s)
=== CONT TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
--- PASS: TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports (448.33s)
=== CONT TestAccRDSCluster_copyTagsToSnapshot
--- PASS: TestAccRDSCluster_backupsUpdate (203.07s)
=== CONT TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal (447.68s)
=== CONT TestAccRDSCluster_identifierGenerated
--- PASS: TestAccRDSCluster_SnapshotIdentifier_masterPassword (424.92s)
=== CONT TestAccRDSCluster_identifierPrefix
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL (221.90s)
=== CONT TestAccRDSCluster_allocatedStorage
--- PASS: TestAccRDSCluster_updateIAMRoles (205.72s)
=== CONT TestAccRDSCluster_iamAuth
--- PASS: TestAccRDSCluster_identifierGenerated (144.23s)
=== CONT TestAccRDSCluster_encrypted
--- PASS: TestAccRDSCluster_SnapshotIdentifier_kmsKeyID (466.94s)
=== CONT TestAccRDSCluster_tags
--- PASS: TestAccRDSCluster_copyTagsToSnapshot (252.40s)
=== CONT TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned
--- PASS: TestAccRDSCluster_engineMode (478.79s)
=== CONT TestAccRDSCluster_networkType
--- PASS: TestAccRDSCluster_identifierPrefix (194.42s)
=== CONT TestAccRDSCluster_SnapshotIdentifier_deletionProtection
--- PASS: TestAccRDSCluster_iamAuth (163.30s)
=== CONT TestAccRDSCluster_SnapshotIdentifier_masterUsername
--- PASS: TestAccRDSCluster_encrypted (153.41s)
=== CONT TestAccRDSCluster_SnapshotIdentifierEngineVersion_different
--- PASS: TestAccRDSCluster_tags (202.31s)
=== CONT TestAccRDSCluster_deletionProtection
--- PASS: TestAccRDSCluster_networkType (207.62s)
=== CONT TestAccRDSCluster_disappears
--- PASS: TestAccRDSCluster_deletionProtection (192.73s)
--- PASS: TestAccRDSCluster_disappears (171.82s)
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned (445.49s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeNoApplyImmediately (885.49s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_masterUsername (415.60s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_deletionProtection (466.24s)
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineVersion_different (426.71s)
--- PASS: TestAccRDSCluster_engineVersionWithPrimaryInstance (1598.25s)
--- PASS: TestAccRDSCluster_dbClusterInstanceClass (1854.39s)
--- PASS: TestAccRDSCluster_iops (1862.95s)
--- PASS: TestAccRDSCluster_storageType (1944.47s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier (2587.26s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters (2666.92s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters (2173.67s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding (2920.00s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgrade (2269.77s)
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql (2177.63s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm (2363.33s)
--- PASS: TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID (2201.64s)
--- PASS: TestAccRDSCluster_allocatedStorage (2076.80s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 3117.034s
This functionality has been released in v4.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
The only engine modes now available are
serverless
andprovisioned
Parallel query is now configured using parameter groups: https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/aurora-mysql-parallel-query.html#aurora-mysql-parallel-query-enabling
multimaster
engine mode testparallelquery
engine mode testRelations
Closes #30355
References
Output from Acceptance Testing