Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace RDS Aurora Version 1 (MySQL 5.6) engine version in acceptance tests #30355

Closed
jar-b opened this issue Mar 30, 2023 · 3 comments · Fixed by #30655
Closed

Replace RDS Aurora Version 1 (MySQL 5.6) engine version in acceptance tests #30355

jar-b opened this issue Mar 30, 2023 · 3 comments · Fixed by #30655
Labels
service/rds Issues and PRs that pertain to the rds service. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Milestone

Comments

@jar-b
Copy link
Member

jar-b commented Mar 30, 2023

Description

EOL Announcement:
https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/Aurora.MySQL56.EOL.html

The CreateDBCluster documentation also now only lists the aurora-mysql and aurora-postgres variants as valid engine arguments. This likely means updating this constants block:

const (
ClusterEngineAurora = "aurora"
ClusterEngineAuroraMySQL = "aurora-mysql"
ClusterEngineAuroraPostgreSQL = "aurora-postgresql"
ClusterEngineMySQL = "mysql"
ClusterEnginePostgres = "postgres"
)

Acceptance tests that explicitly pass 5.6 engine versions or default parameter groups will fail with something like:

=== CONT  TestAccRDSCluster_basic
    cluster_test.go:43: Step 1/2 error: Error running apply: exit status 1

        Error: creating RDS Cluster (tf-acc-test-2784878805221303157): InvalidParameterValue: Engine version not found: oscar/null
                status code: 400, request id: 88f85631-4ed9-4575-b314-c31cd0bf14b0

          with aws_rds_cluster.test,
          on terraform_plugin_test.tf line 2, in resource "aws_rds_cluster" "test":
           2: resource "aws_rds_cluster" "test" {

--- FAIL: TestAccRDSCluster_basic (7.60s)

func testAccClusterConfig_basic(rName string) string {
return fmt.Sprintf(`
resource "aws_rds_cluster" "test" {
cluster_identifier = %[1]q
database_name = "test"
master_username = "tfacctest"
master_password = "avoid-plaintext-passwords"
db_cluster_parameter_group_name = "default.aurora5.6"
skip_final_snapshot = true
}
`, rName)
}

@jar-b jar-b added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Mar 30, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions
Copy link

This functionality has been released in v4.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/rds Issues and PRs that pertain to the rds service. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant