Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_rds_cluster/aws_rds_cluster_instance: Remove default value from engine parameter #27960

Closed
2 tasks
gdavison opened this issue Nov 23, 2022 · 5 comments · Fixed by #31112
Closed
2 tasks
Assignees
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. enhancement Requests to existing resources that expand the functionality or scope.
Milestone

Comments

@gdavison
Copy link
Contributor

gdavison commented Nov 23, 2022

Description

The resource aws_rds_cluster defines a default value of aurora for the engine parameter. The AWS API treats this parameter as required and does not define a default. Additionally, aurora creates a MySQL-5.6-compatible cluster, while aurora-mysql is used for MySQL-5.7- and MySQL-8.0-compatible clusters.

  • aws_rds_cluster: Remove the default value and make engine a required parameter.
  • aws_rds_cluster_instance: Remove the default value and make engine a required parameter.

Affected Resource(s) and/or Data Source(s)

aws_rds_cluster

Potential Terraform Configuration

No response

References

No response

Would you like to implement a fix?

No response

@gdavison gdavison added enhancement Requests to existing resources that expand the functionality or scope. breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. labels Nov 23, 2022
@gdavison gdavison added this to the v5.0.0 milestone Nov 23, 2022
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@jar-b
Copy link
Member

jar-b commented Mar 31, 2023

With Aurora MySQL Version 1 now at EOL, it appears aurora (the current default value) has been removed as a valid value for the Engine argument in APIs like CreateDBCluster:

image

As part of these breaking changes, we should remove this constant to ensure plan time validation matches the AWS valid values going forward.

ClusterEngineAurora = "aurora"

Ref:

@YakDriver YakDriver self-assigned this May 1, 2023
@YakDriver YakDriver linked a pull request May 2, 2023 that will close this issue
@YakDriver YakDriver changed the title resource/aws_rds_cluster: Remove default value from engine parameter resource/aws_rds_cluster/aws_rds_cluster_instance: Remove default value from engine parameter May 2, 2023
@jar-b
Copy link
Member

jar-b commented May 23, 2023

Closed by #31112, merged to main via #31392

@jar-b jar-b closed this as completed May 23, 2023
@github-actions
Copy link

This functionality has been released in v5.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants