Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aws_codestarconnections_host resource #16918

Merged

Conversation

shuheiktgw
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #15453

Release note for CHANGELOG:

* **New Resource:** `aws_codestarconnections_host`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCodeStarConnectionsHost_*'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeStarConnectionsHost_* -timeout 120m
=== RUN   TestAccAWSCodeStarConnectionsHost_basic
=== PAUSE TestAccAWSCodeStarConnectionsHost_basic
=== RUN   TestAccAWSCodeStarConnectionsHost_disappears
=== PAUSE TestAccAWSCodeStarConnectionsHost_disappears
=== RUN   TestAccAWSCodeStarConnectionsHost_vpcConfig
=== PAUSE TestAccAWSCodeStarConnectionsHost_vpcConfig
=== CONT  TestAccAWSCodeStarConnectionsHost_basic
=== CONT  TestAccAWSCodeStarConnectionsHost_vpcConfig
=== CONT  TestAccAWSCodeStarConnectionsHost_disappears
--- PASS: TestAccAWSCodeStarConnectionsHost_disappears (87.31s)
--- PASS: TestAccAWSCodeStarConnectionsHost_basic (96.56s)
--- PASS: TestAccAWSCodeStarConnectionsHost_vpcConfig (483.70s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	485.633s

Thank you for your review! 👍

@shuheiktgw shuheiktgw requested a review from a team as a code owner December 29, 2020 01:22
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/codestarconnections Issues and PRs that pertain to the codestarconnections service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 29, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 29, 2020
@shuheiktgw shuheiktgw force-pushed the add_codestar_connections_host_resource branch from b95b5f5 to 2b6df09 Compare December 29, 2020 02:07
Base automatically changed from master to main January 23, 2021 01:00
@Meroje
Copy link

Meroje commented Feb 4, 2021

Eager to see this land, thank you for doing this :)

Anyway, shouldn't the host arn be made available as a parameter to the connection resource as it is required on the API side ? https://docs.aws.amazon.com/codestar-connections/latest/APIReference/API_CreateConnection.html#codestarconnections-CreateConnection-request-HostArn

@shuheiktgw
Copy link
Collaborator Author

Hi, @Meroje. Thank you for your comment! I guess you are talking about CodeStar Connection, not CodeStar Host. You may want to check the PR below!

@shuheiktgw
Copy link
Collaborator Author

Oh, wait. I think I understood what you mean. Since this PR adds aws_codestarconnections_host, we can add the host_arn parameter to aws_codestarconnections_connection. Let me fix that.

@Meroje
Copy link

Meroje commented Feb 4, 2021

Yes absolutely! But when I tried it out today it was not working because of this HostArn param, the aws api actually gives an error about it. So I figured I actually need this here PR because the connection needs the host and the host don't do anything alone.
Is it intended that #15990 was merged as what appears to me in a broken state and when should the fix be done ? I could open the PR if it will not be done here (I get it, related PR but not actually the same resource) but I've seen this kind take too long to get any review and land.

@shuheiktgw
Copy link
Collaborator Author

Hmm, I recommend you file an issue to explain the situation. In order to add the host_arn attribute to aws_codestarconnections_connection, this PR needs to be reviewed and merged first.

@bflad bflad self-assigned this Apr 29, 2021
@bflad bflad added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 29, 2021
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this, @shuheiktgw, bringing this in with some modernization of using waiter package, _Values() for validation, and adding a changelog file 🚀

Output from acceptance testing:

--- PASS: TestAccAWSCodeStarConnectionsHost_disappears (111.09s)
--- PASS: TestAccAWSCodeStarConnectionsHost_basic (115.11s)
--- PASS: TestAccAWSCodeStarConnectionsHost_vpcConfig (581.12s)

@bflad bflad merged commit 5084477 into hashicorp:main Apr 29, 2021
@github-actions github-actions bot added this to the v3.38.0 milestone Apr 29, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/codestarconnections Issues and PRs that pertain to the codestarconnections service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants