Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CodeStar Connections #15453

Closed
2 of 5 tasks
jrobison-sb opened this issue Oct 2, 2020 · 11 comments
Closed
2 of 5 tasks

Add support for CodeStar Connections #15453

jrobison-sb opened this issue Oct 2, 2020 · 11 comments
Labels
new-resource Introduces a new resource. service/codestarconnections Issues and PRs that pertain to the codestarconnections service.

Comments

@jrobison-sb
Copy link
Contributor

jrobison-sb commented Oct 2, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS recommends that CodePipeline connections to third party services like GitHub and BitBucket should be done using CodeStar Connections. It would be nice if Terraform supported this.

New Resources and Data Sources

  • resource: aws_codestarconnections_connection (Add aws_codestarconnections_connection resource #15990)
  • tag support for codestarconnections service
  • resource: aws_codestarconnections_host
  • data source: aws_codestarconnections_connection
  • data source: aws_codestarconnections_host

References

@jrobison-sb jrobison-sb added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 2, 2020
@ghost ghost added the service/codestar Issues and PRs that pertain to the codestar service. label Oct 2, 2020
@jrobison-sb jrobison-sb changed the title Add support for CodeStart Connections Add support for CodeStar Connections Oct 2, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 2, 2020
@bflad bflad added new-resource Introduces a new resource. service/codestarconnections Issues and PRs that pertain to the codestarconnections service. and removed enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. service/codestar Issues and PRs that pertain to the codestar service. labels Oct 2, 2020
@bflad
Copy link
Contributor

bflad commented Oct 2, 2020

Related:

Please note that in this case we'll expect these resources to be named aws_codestarconnections_XXX to follow the conventions in the Contributing Guide.

@mwarkentin
Copy link
Contributor

The GitHub version 1 action is not recommended and will soon no longer be supported.

Sounds like this will be the only supported connection type soon.

@mwarkentin
Copy link
Contributor

Might be nice to have a codestar_connection data source as well so that you could look them up by name and reference their ARN in CodePipeline actions.

@shuheiktgw
Copy link
Collaborator

I've started adding CodeStar Connections to TF so please upvote the PR below for the faster review! 🙏

#15960

@shuheiktgw
Copy link
Collaborator

Added the second part of the PR: #15990

I'm going to work on aws_codestarconnections_host once the PR above is merged!

@shuheiktgw
Copy link
Collaborator

Added tag support for CodeStar connection! 🎉
#16835

@shuheiktgw
Copy link
Collaborator

shuheiktgw commented Dec 29, 2020

Added support for CodeStar host! 🙏
#16918

@onitake
Copy link
Contributor

onitake commented Mar 4, 2021

Might be nice to have a codestar_connection data source as well so that you could look them up by name and reference their ARN in CodePipeline actions.

@shuheiktgw Will you be adding a aws_codestarconnections_connection data source as well?
If not, what would be the recommended way to obtain the ARN in a separate Terraform script? Add the aws_codestarconnections_connection resource to every script, or copy the ARN?

It doesn't look like the ARN has a predictable value, so it can't be constructed in-place.

@shuheiktgw
Copy link
Collaborator

@onitake Sure, I'll add aws_codestarconnections_connection data 👍

@DrFaust92
Copy link
Collaborator

Closing this as most (if not all were resource were covered) if a more specific resource/feature is needed please create a dedicated ticket

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-resource Introduces a new resource. service/codestarconnections Issues and PRs that pertain to the codestarconnections service.
Projects
None yet
Development

No branches or pull requests

6 participants