Add tag support for aws_codestarconnections_connection resource

[shuheiktgw]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #15453

Release note for CHANGELOG:

resource/aws_codestarconnections_connection: Add tag support

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCodeStarConnectionsConnection_tags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeStarConnectionsConnection_tags -timeout 120m
=== RUN   TestAccAWSCodeStarConnectionsConnection_tags
=== PAUSE TestAccAWSCodeStarConnectionsConnection_tags
=== CONT  TestAccAWSCodeStarConnectionsConnection_tags
--- PASS: TestAccAWSCodeStarConnectionsConnection_tags (36.40s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	38.256s

Thank you for your review! 👍

[bflad]

Overall this is on the right track, just a few additional things and we will get this in. Thank you, @shuheiktgw 😄

[bflad]

Updating resource tags should not require resource recreation -- we can add an Update function that only handles tags. 👍

[bflad]

Nit: Will parameterize this to match the Contributing Guide so it is easier to add the update step.

[bflad]

In Terraform the type is map

Suggested change

	* `tags` - (Optional) An array of key:value pairs to associate with the resource.
	* `tags` - (Optional) Map of key-value resource tags to associate with the resource.

[bflad]

Thank you, @shuheiktgw 🚀

After adding tag update support:

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSCodeStarConnectionsConnection_disappears (10.57s)
--- PASS: TestAccAWSCodeStarConnectionsConnection_Basic (14.06s)
--- PASS: TestAccAWSCodeStarConnectionsConnection_Tags (30.15s)

Output from acceptance testing in AWS GovCloud (US):

--- SKIP: TestAccAWSCodeStarConnectionsConnection_Basic (1.27s)
--- SKIP: TestAccAWSCodeStarConnectionsConnection_disappears (1.27s)
--- SKIP: TestAccAWSCodeStarConnectionsConnection_Tags (1.27s)

[ghost]

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!