Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Values functions to validate SDK Enums: K-M #16732

Closed
wants to merge 1 commit into from

Conversation

mattburgess
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #14601

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@mattburgess mattburgess requested a review from a team as a code owner December 12, 2020 15:56
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/firehose Issues and PRs that pertain to the firehose service. service/kafka Issues and PRs that pertain to the kafka service. service/kinesis Issues and PRs that pertain to the kinesis service. service/kms Issues and PRs that pertain to the kms service. service/lambda Issues and PRs that pertain to the lambda service. service/licensemanager Issues and PRs that pertain to the licensemanager service. service/macie Issues and PRs that pertain to the macie service. service/mediaconvert Issues and PRs that pertain to the mediaconvert service. service/mq Issues and PRs that pertain to the mq service. service/s3 Issues and PRs that pertain to the s3 service. labels Dec 12, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 12, 2020
Base automatically changed from master to main January 23, 2021 00:59
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. service/mq Issues and PRs that pertain to the mq service. labels Jul 7, 2021
@gordonbondon
Copy link
Contributor

This would fix #19140

@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 16, 2021
@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@justinretzolk
Copy link
Member

👋 We discussed this out of band with Matt. The team would like to revisit how we deal with enumerated values when we migrate to AWS Go SDK v2. With that in mind, closing this PR.

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/firehose Issues and PRs that pertain to the firehose service. service/kafka Issues and PRs that pertain to the kafka service. service/kinesis Issues and PRs that pertain to the kinesis service. service/kms Issues and PRs that pertain to the kms service. service/lambda Issues and PRs that pertain to the lambda service. service/licensemanager Issues and PRs that pertain to the licensemanager service. service/macie Issues and PRs that pertain to the macie service. service/mediaconvert Issues and PRs that pertain to the mediaconvert service. service/s3 Issues and PRs that pertain to the s3 service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants