Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_launch_template: add the option to tag network-interfaces #19140

Closed
AlexisJackson opened this issue Apr 28, 2021 · 5 comments · Fixed by #20409
Closed

aws_launch_template: add the option to tag network-interfaces #19140

AlexisJackson opened this issue Apr 28, 2021 · 5 comments · Fixed by #20409
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@AlexisJackson
Copy link

AlexisJackson commented Apr 28, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The LaunchTemplateTagSpecificationRequest API docs show that network-interface is an option. Can this be added to the list of supported types? We pair ECS Clusters with AutoScaling Groups and it would be helpful if the network-interfaces/enis attached to the EC2 Instances were tagged along with the instances and volumes.

https://github.com/hashicorp/terraform-provider-aws/blob/main/aws/resource_aws_launch_template.go#L588-L591

New or Affected Resource(s)

  • aws_launch_template

Potential Terraform Configuration

tag_specifications {
    resource_type = "network-interface"

    tags = {
      Name = "test"
    }
}

References

@AlexisJackson AlexisJackson added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 28, 2021
@ghost ghost added the service/ec2 Issues and PRs that pertain to the ec2 service. label Apr 28, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 28, 2021
@gdavison gdavison removed the needs-triage Waiting for first response or review from a maintainer. label Apr 28, 2021
@Aym3nTN
Copy link

Aym3nTN commented May 26, 2021

Really appreciate adding this feature, we're building several EKS clusters with severals nodes for our different environments and we need to efficiently track our spending.

@alexmnyc
Copy link

alexmnyc commented Jun 1, 2021

same here. it is a problem! why not allow the entire list of tag specification allowed enum?

@gordonbondon
Copy link
Contributor

Should be fixed by #20409

@github-actions
Copy link

github-actions bot commented Aug 5, 2021

This functionality has been released in v3.53.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 5, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
5 participants