tests/service/rds: Remove hardcoded us-east-1 environment variable handling

[bflad]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #8316
Reference: #15791

Release note for CHANGELOG:

NONE

Previously in AWS Commercial:

=== CONT  TestAccAWSDBInstance_ec2Classic
TestAccAWSDBInstance_ec2Classic: resource_aws_db_instance_test.go:2242: Step 1/1 error: Error running apply: 2020/11/02 10:23:21 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0
Error: Error creating DB Instance: InsufficientDBInstanceCapacity: Cannot create a db.t3.micro database instance because there are no availability zones with sufficient capacity for non-VPC and storage type : standard for db.t3.micro. Please try the request again at a later time.
  status code: 400, request id: cb437def-f533-4894-874a-235bef9fe874
--- FAIL: TestAccAWSDBInstance_ec2Classic (11.36s)

Previously in AWS GovCloud (US):

=== CONT  TestAccAWSDbInstanceDataSource_ec2Classic
TestAccAWSDbInstanceDataSource_ec2Classic: provider_test.go:196: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid.
  status code: 403, request id: 4f3cfbfa-bc43-46bd-8834-5eeb10cc4fc9  []}]
--- FAIL: TestAccAWSDbInstanceDataSource_ec2Classic (0.49s)

=== CONT  TestAccAWSDBInstance_ec2Classic
TestAccAWSDBInstance_ec2Classic: provider_test.go:196: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid.
  status code: 403, request id: 2af3b934-784b-43e5-8e67-38b7b7333b94  []}]
--- FAIL: TestAccAWSDBInstance_ec2Classic (0.38s)

=== CONT  TestAccAWSDBSecurityGroup_basic
TestAccAWSDBSecurityGroup_basic: provider_test.go:196: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid.
  status code: 403, request id: 2ac5b1af-30f7-4c64-81d8-0cf983ce035b  []}]
--- FAIL: TestAccAWSDBSecurityGroup_basic (0.33s)

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSDbInstanceDataSource_ec2Classic (452.57s)

--- PASS: TestAccAWSDBInstance_ec2Classic (496.81s)

--- PASS: TestAccAWSDBSecurityGroup_basic (35.95s)

Output from acceptance testing in AWS GovCloud (US):

--- SKIP: TestAccAWSDbInstanceDataSource_ec2Classic (2.84s)

--- SKIP: TestAccAWSDBInstance_ec2Classic (2.81s)

--- SKIP: TestAccAWSDBSecurityGroup_basic (2.72s)

[YakDriver]

Ut-oh.

Commercial (main & alt):

    data_source_aws_db_instance_test.go:46: Step 1/1 error: Error running pre-apply plan: 
        Error: DBInstanceNotFound: DBInstance foobarbaz-test-terraform-3571722750175342799 not found.
        	status code: 404, request id: 3b0da668-3d8e-4bee-93df-a26e9db58683
        
        
--- FAIL: TestAccAWSDbInstanceDataSource_ec2Classic (5.28s)

[ghost]

This has been released in version 3.14.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!