Acceptance testing: Create EC2-Classic alternate test provider #15791
Assignees
Labels
enhancement
Requests to existing resources that expand the functionality or scope.
provider
Pertains to the provider itself, rather than any interaction with AWS.
technical-debt
Addresses areas of the codebase that need refactoring or redesign.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Milestone
Comments
gdavison
added
enhancement
48 tasks
bflad
added a commit
that referenced
this issue
Oct 23, 2020
…lt region environment variable and better document existing provider initialization Reference: #8316 Reference: #15737 Reference: #15791 Output from acceptance testing in AWS Commercial (DynamoDB to verify existing testAccProviderFactories handling): ``` --- PASS: TestAccAWSDynamoDbTable_Replica_Single (274.15s) --- PASS: TestAccAWSRedshiftSecurityGroup_basic (10.87s) --- PASS: TestAccAWSRedshiftSecurityGroup_ingressCidr (10.88s) --- PASS: TestAccAWSRedshiftSecurityGroup_ingressSecurityGroup (12.45s) --- PASS: TestAccAWSRedshiftSecurityGroup_updateIngressCidr (24.07s) --- PASS: TestAccAWSRedshiftSecurityGroup_updateIngressSecurityGroup (27.14s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- SKIP: TestAccAWSRedshiftSecurityGroup_updateIngressCidr (2.50s) --- SKIP: TestAccAWSRedshiftSecurityGroup_basic (2.50s) --- SKIP: TestAccAWSRedshiftSecurityGroup_ingressCidr (2.50s) --- SKIP: TestAccAWSRedshiftSecurityGroup_ingressSecurityGroup (2.50s) --- SKIP: TestAccAWSRedshiftSecurityGroup_updateIngressSecurityGroup (2.50s) ```
bflad
added a commit
that referenced
this issue
Oct 28, 2020
…nvironment variable overwrite (CUR and EC2-Classic) (#15803) * tests/provider: Prepare EC2-Classic handling to remove reseting default region environment variable and better document existing provider initialization Reference: #8316 Reference: #15737 Reference: #15791 Output from acceptance testing in AWS Commercial (DynamoDB to verify existing testAccProviderFactories handling): ``` --- PASS: TestAccAWSDynamoDbTable_Replica_Single (274.15s) --- PASS: TestAccAWSRedshiftSecurityGroup_basic (10.87s) --- PASS: TestAccAWSRedshiftSecurityGroup_ingressCidr (10.88s) --- PASS: TestAccAWSRedshiftSecurityGroup_ingressSecurityGroup (12.45s) --- PASS: TestAccAWSRedshiftSecurityGroup_updateIngressCidr (24.07s) --- PASS: TestAccAWSRedshiftSecurityGroup_updateIngressSecurityGroup (27.14s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- SKIP: TestAccAWSRedshiftSecurityGroup_updateIngressCidr (2.50s) --- SKIP: TestAccAWSRedshiftSecurityGroup_basic (2.50s) --- SKIP: TestAccAWSRedshiftSecurityGroup_ingressCidr (2.50s) --- SKIP: TestAccAWSRedshiftSecurityGroup_ingressSecurityGroup (2.50s) --- SKIP: TestAccAWSRedshiftSecurityGroup_updateIngressSecurityGroup (2.50s) ``` * tests/service/costandusagereporting: Migrate to automatic region lookup Reference: #8316 Reference: #15737 Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAwsCurReportDefinition_refresh (13.35s) --- PASS: TestAccAwsCurReportDefinition_overwrite (13.53s) --- PASS: TestAccAwsCurReportDefinition_athena (13.55s) --- PASS: TestAccAwsCurReportDefinition_basic (13.56s) --- PASS: TestAccAwsCurReportDefinition_textOrCsv (13.77s) --- PASS: TestAccAwsCurReportDefinition_parquet (13.83s) --- PASS: TestAccDataSourceAwsCurReportDefinition_additional (15.71s) --- PASS: TestAccDataSourceAwsCurReportDefinition_basic (16.05s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- SKIP: TestAccAwsCurReportDefinition_refresh (1.22s) --- SKIP: TestAccAwsCurReportDefinition_athena (1.22s) --- SKIP: TestAccAwsCurReportDefinition_basic (1.23s) --- SKIP: TestAccAwsCurReportDefinition_textOrCsv (1.23s) --- SKIP: TestAccAwsCurReportDefinition_overwrite (1.24s) --- SKIP: TestAccAwsCurReportDefinition_parquet (1.25s) ``` * tests/service/cur: Ensure DescribeReportDefinitions call is in PreCheck Output from acceptance testing in AWS Commercial ("main" testing account -- Organizations member account): ``` === CONT TestAccAwsCurReportDefinition_basic cur_test.go:66: skipping acceptance testing: AccessDeniedException: accountId: --OMITTED-- is not authorized to callDescribeReportDefinitions. Note: linked account is not allowed to modify report preference. status code: 400, request id: 6e513d8a-4ff8-4af2-a4d3-7523dacb2dbb --- SKIP: TestAccAwsCurReportDefinition_basic (2.42s) ``` Output from acceptance testing in AWS Commercial (standalone account): ``` --- PASS: TestAccAwsCurReportDefinition_basic (13.76s) ``` Output from acceptance testing in AWS GovCloud (US): ``` === CONT TestAccAwsCurReportDefinition_basic provider_test.go:602: skipping tests; partition aws-us-gov does not support cur service --- SKIP: TestAccAwsCurReportDefinition_basic (1.37s) ```
bflad
added a commit
that referenced
this issue
Oct 28, 2020
…etup and PreCheck functions Reference: #8316 Reference: #15737 Reference: #15791 This creates the remaining special `ProviderFactories` functions (as they need to exist currently), updates the Contributing Guide documentation, and migrates a portion of the tests over to them. Further changesets will continue these efforts by: * Migrating the rest of the `awsalternate` provider test configurations to `testAccProviderFactoriesAlternate()` * Migrating the rest of the `testAccMultipleRegionsPreCheck()` and `testAccAlternateRegionPreCheck()` usage to `testAccMultipleRegionPreCheck()` (bundling with the above as its fairly common together) * Flipping `testAccProviderFactories` to a variable with only the `aws` provider and replacing `testAccProviderFactoriesEc2Classic` and `testAccProviderFactoriesCur()` * Continuing efforts to remove environment variable handling in test functions Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAwsBackupPlan_Rule_CopyAction_CrossRegion (20.85s) --- PASS: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn (157.90s) --- PASS: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn_ConflictsWithCloudFrontDefaultCertificate (157.61s) --- FAIL: TestAccAWSDBInstance_DbSubnetGroupName_RamShared (18.95s) resource_aws_db_instance_test.go:352: Step 1/1 error: Error running apply: 2020/10/27 23:13:26 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0 Error: Error associating principal with RAM resource share: UnknownResourceException: Organization o-upyv668dz5 could not be found. Error: error associating RAM Resource Share: InvalidParameterException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress. Error: error associating RAM Resource Share: InvalidParameterException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress. --- FAIL: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName_RamShared (604.80s) resource_aws_db_instance_test.go:808: Step 1/1 error: Error running apply: 2020/10/27 21:59:55 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0 Error: Error associating principal with RAM resource share: UnknownResourceException: Organization o-upyv668dz5 could not be found. Error: error associating RAM Resource Share: InvalidParameterException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress. Error: error associating RAM Resource Share: InvalidParameterException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress. --- FAIL: TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName_RamShared (615.89s) resource_aws_db_instance_test.go:1437: Step 1/1 error: Error running apply: 2020/10/27 23:13:26 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0 Error: Error associating principal with RAM resource share: UnknownResourceException: Organization o-upyv668dz5 could not be found. Error: error associating RAM Resource Share: InvalidParameterException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress. Error: error associating RAM Resource Share: InvalidParameterException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress. --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName (2252.27s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName_VpcSecurityGroupIds (1908.33s) --- PASS: TestAccAWSDynamoDbTable_Replica_Multiple (766.22s) --- PASS: TestAccAWSDynamoDbTable_Replica_Single (412.01s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_basic (376.21s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_differentAccount (360.55s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_disappears (363.16s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_Tags_sameAccount (365.29s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentAccepter_basic_differentAccount (780.52s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentAccepter_basic_sameAccount (773.52s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentAccepter_Tags_sameAccount (815.32s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Filter_differentAccount (389.30s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Filter_sameAccount (397.06s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_ID_differentAccount (333.33s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_ID_sameAccount (333.84s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Tags (332.99s) --- PASS: TestAccAWSProvider_AssumeRole_Empty (16.67s) --- PASS: TestAccAWSProvider_Endpoints (14.28s) --- PASS: TestAccAWSProvider_IgnoreTags_EmptyConfigurationBlock (14.21s) --- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_Multiple (14.15s) --- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_None (14.28s) --- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_One (14.05s) --- PASS: TestAccAWSProvider_IgnoreTags_Keys_Multiple (14.11s) --- PASS: TestAccAWSProvider_IgnoreTags_Keys_None (14.19s) --- PASS: TestAccAWSProvider_IgnoreTags_Keys_One (14.31s) --- PASS: TestAccAWSProvider_Region_AwsChina (11.20s) --- PASS: TestAccAWSProvider_Region_AwsCommercial (11.54s) --- PASS: TestAccAWSProvider_Region_AwsGovCloudUs (11.22s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAwsBackupPlan_Rule_CopyAction_CrossRegion (24.77s) --- SKIP: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn (1.52s) --- SKIP: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn_ConflictsWithCloudFrontDefaultCertificate (1.55s) ```
bflad
added a commit
that referenced
this issue
Oct 28, 2020
…etup and PreCheck functions (#15877) Reference: #8316 Reference: #15737 Reference: #15791 This creates the remaining special `ProviderFactories` functions (as they need to exist currently), updates the Contributing Guide documentation, and migrates a portion of the tests over to them. Further changesets will continue these efforts by: * Migrating the rest of the `awsalternate` provider test configurations to `testAccProviderFactoriesAlternate()` * Migrating the rest of the `testAccMultipleRegionsPreCheck()` and `testAccAlternateRegionPreCheck()` usage to `testAccMultipleRegionPreCheck()` (bundling with the above as its fairly common together) * Flipping `testAccProviderFactories` to a variable with only the `aws` provider and replacing `testAccProviderFactoriesEc2Classic` and `testAccProviderFactoriesCur()` * Continuing efforts to remove environment variable handling in test functions Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAwsBackupPlan_Rule_CopyAction_CrossRegion (20.85s) --- PASS: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn (157.90s) --- PASS: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn_ConflictsWithCloudFrontDefaultCertificate (157.61s) --- FAIL: TestAccAWSDBInstance_DbSubnetGroupName_RamShared (18.95s) resource_aws_db_instance_test.go:352: Step 1/1 error: Error running apply: 2020/10/27 23:13:26 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0 Error: Error associating principal with RAM resource share: UnknownResourceException: Organization o-upyv668dz5 could not be found. Error: error associating RAM Resource Share: InvalidParameterException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress. Error: error associating RAM Resource Share: InvalidParameterException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress. --- FAIL: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName_RamShared (604.80s) resource_aws_db_instance_test.go:808: Step 1/1 error: Error running apply: 2020/10/27 21:59:55 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0 Error: Error associating principal with RAM resource share: UnknownResourceException: Organization o-upyv668dz5 could not be found. Error: error associating RAM Resource Share: InvalidParameterException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress. Error: error associating RAM Resource Share: InvalidParameterException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress. --- FAIL: TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName_RamShared (615.89s) resource_aws_db_instance_test.go:1437: Step 1/1 error: Error running apply: 2020/10/27 23:13:26 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0 Error: Error associating principal with RAM resource share: UnknownResourceException: Organization o-upyv668dz5 could not be found. Error: error associating RAM Resource Share: InvalidParameterException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress. Error: error associating RAM Resource Share: InvalidParameterException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress. --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName (2252.27s) --- PASS: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName_VpcSecurityGroupIds (1908.33s) --- PASS: TestAccAWSDynamoDbTable_Replica_Multiple (766.22s) --- PASS: TestAccAWSDynamoDbTable_Replica_Single (412.01s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_basic (376.21s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_differentAccount (360.55s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_disappears (363.16s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_Tags_sameAccount (365.29s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentAccepter_basic_differentAccount (780.52s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentAccepter_basic_sameAccount (773.52s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentAccepter_Tags_sameAccount (815.32s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Filter_differentAccount (389.30s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Filter_sameAccount (397.06s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_ID_differentAccount (333.33s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_ID_sameAccount (333.84s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Tags (332.99s) --- PASS: TestAccAWSProvider_AssumeRole_Empty (16.67s) --- PASS: TestAccAWSProvider_Endpoints (14.28s) --- PASS: TestAccAWSProvider_IgnoreTags_EmptyConfigurationBlock (14.21s) --- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_Multiple (14.15s) --- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_None (14.28s) --- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_One (14.05s) --- PASS: TestAccAWSProvider_IgnoreTags_Keys_Multiple (14.11s) --- PASS: TestAccAWSProvider_IgnoreTags_Keys_None (14.19s) --- PASS: TestAccAWSProvider_IgnoreTags_Keys_One (14.31s) --- PASS: TestAccAWSProvider_Region_AwsChina (11.20s) --- PASS: TestAccAWSProvider_Region_AwsCommercial (11.54s) --- PASS: TestAccAWSProvider_Region_AwsGovCloudUs (11.22s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAwsBackupPlan_Rule_CopyAction_CrossRegion (24.77s) --- SKIP: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn (1.52s) --- SKIP: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn_ConflictsWithCloudFrontDefaultCertificate (1.55s) ```
bflad
added a commit
that referenced
this issue
Oct 29, 2020
…refactor testAccProviderFactories for broad usage Reference: #8316 Reference: #15737 Reference: #15791 This change set continues the work of #15877, bringing a consistent pattern for cross-region and cross-account testing and removing previously deprecated provider-level test functions. The `testAccProviderFactories` global variable is now generically for every test that only requires a single provider and prevents the previous issues where extraneous gRPC plugins were extraneously created (sometimes causing `ulimit` issues, but broadly a performance fix to remove them). This also removes the temporary `testAccProviderFactoriesCur()` and `testAccProviderFactoriesEc2Classic()` functions, since anything only requiring a single provider can use `ProviderFactories: testAccProviderFactories` or `Providers: testAccProviders` (for now, its deprecated in the SDK and we'll be updating these everywhere to `ProviderFactories` anyways). This should mean that other existing EC2-Classic and special service region testing should not require changes to that particular field in future change sets that continue this effort. After this, we are off to the races to remove the problematic environment variable handling causing issues across the provider acceptance testing. Output from acceptance testing (CUR testing done in standalone account): ``` --- PASS: TestAccDataSourceAwsCurReportDefinition_additional (21.63s) --- PASS: TestAccDataSourceAwsCurReportDefinition_basic (18.93s) --- PASS: TestAccDataSourceAwsRoute53ResolverRule_basic (59.47s) --- PASS: TestAccDataSourceAwsRoute53ResolverRule_ResolverEndpointIdWithTags (265.34s) --- PASS: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn (158.62s) --- PASS: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn_ConflictsWithCloudFrontDefaultCertificate (159.67s) --- PASS: TestAccAWSCodePipeline_multiregion_basic (37.37s) --- PASS: TestAccAWSCodePipeline_multiregion_Update (58.07s) --- PASS: TestAccAWSCodePipeline_multiregion_ConvertSingleRegion (81.33s) --- PASS: TestAccAwsCurReportDefinition_athena (18.30s) --- PASS: TestAccAwsCurReportDefinition_basic (23.58s) --- PASS: TestAccAwsCurReportDefinition_overwrite (18.10s) --- PASS: TestAccAwsCurReportDefinition_parquet (18.67s) --- PASS: TestAccAwsCurReportDefinition_refresh (21.62s) --- PASS: TestAccAwsCurReportDefinition_textOrCsv (21.45s) --- PASS: TestAccAWSDbSubnetGroupDataSource_basic (66.22s) --- PASS: TestAccAWSDbSubnetGroupDataSource_nonexistent (3.06s) --- PASS: TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewayCrossAccount (1998.47s) --- PASS: TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewaySingleAccount (1957.89s) --- PASS: TestAccAwsDxGatewayAssociation_basicTransitGatewayCrossAccount (865.40s) --- PASS: TestAccAwsDxGatewayAssociation_basicTransitGatewaySingleAccount (1186.07s) --- PASS: TestAccAwsDxGatewayAssociation_basicVpnGatewayCrossAccount (1530.51s) --- PASS: TestAccAwsDxGatewayAssociation_basicVpnGatewaySingleAccount (1633.65s) --- PASS: TestAccAwsDxGatewayAssociation_multiVpnGatewaysSingleAccount (1697.33s) --- PASS: TestAccAwsDxGatewayAssociation_V0StateUpgrade (1187.97s) --- PASS: TestAccAwsDxGatewayAssociationProposal_AllowedPrefixes (138.31s) --- PASS: TestAccAwsDxGatewayAssociationProposal_basicTransitGateway (227.10s) --- PASS: TestAccAwsDxGatewayAssociationProposal_basicVpnGateway (68.42s) --- PASS: TestAccAwsDxGatewayAssociationProposal_disappears (64.49s) --- SKIP: TestAccAwsDxHostedPrivateVirtualInterface_AccepterTags (0.00s) --- SKIP: TestAccAwsDxHostedPrivateVirtualInterface_basic (0.00s) --- SKIP: TestAccAwsDxHostedPublicVirtualInterface_AccepterTags (0.00s) --- SKIP: TestAccAwsDxHostedPublicVirtualInterface_basic (0.00s) --- PASS: TestAccAwsDxHostedTransitVirtualInterface_serial (0.00s) --- SKIP: TestAccAwsDxHostedTransitVirtualInterface_serial/accepterTags (0.00s) --- SKIP: TestAccAwsDxHostedTransitVirtualInterface_serial/basic (0.00s) --- PASS: TestAccAWSDynamoDbGlobalTable_basic (84.93s) --- PASS: TestAccAWSDynamoDbGlobalTable_multipleRegions (102.52s) --- PASS: TestAccAWSEbsSnapshotCopy_withRegions (75.67s) --- PASS: TestAccAwsRamResourceShareAccepter_basic (36.70s) --- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_PrimarySecondaryClusters (1969.60s) --- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_ReplicationSourceIdentifier (1819.35s) --- PASS: TestAccAWSRDSCluster_ReplicationSourceIdentifier_KmsKeyId (1691.11s) --- PASS: TestAccAWSRedshiftCluster_snapshotCopy (631.18s) --- PASS: TestAccAWSRedshiftSecurityGroup_basic (11.11s) --- PASS: TestAccAWSRedshiftSecurityGroup_ingressCidr (11.10s) --- PASS: TestAccAWSRedshiftSecurityGroup_ingressSecurityGroup (12.47s) --- PASS: TestAccAWSRedshiftSecurityGroup_updateIngressCidr (23.94s) --- PASS: TestAccAWSRedshiftSecurityGroup_updateIngressSecurityGroup (27.22s) --- PASS: TestAccAWSRoute53VpcAssociationAuthorization_basic (99.00s) --- PASS: TestAccAWSRoute53VpcAssociationAuthorization_disappears (94.43s) --- PASS: TestAccAWSRoute53ZoneAssociation_CrossAccount (124.58s) --- PASS: TestAccAWSRoute53ZoneAssociation_CrossRegion (157.69s) --- PASS: TestAccAWSS3Bucket_Replication (145.26s) --- PASS: TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AccessControlTranslation (86.49s) --- PASS: TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AddAccessControlTranslation (84.75s) --- PASS: TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError (22.79s) --- PASS: TestAccAWSS3Bucket_ReplicationSchemaV2 (174.11s) --- PASS: TestAccAWSS3Bucket_ReplicationWithoutPrefix (65.38s) --- PASS: TestAccAWSS3Bucket_ReplicationWithoutStorageClass (85.05s) --- PASS: TestAccAWSS3Bucket_SameRegionReplicationSchemaV2 (73.58s) --- PASS: TestAccAWSSubnet_ignoreTags (86.24s) --- PASS: TestAccAWSVPCPeeringConnection_accept (144.21s) --- PASS: TestAccAWSVPCPeeringConnection_basic (65.98s) --- PASS: TestAccAWSVPCPeeringConnection_failedState (12.38s) --- PASS: TestAccAWSVPCPeeringConnection_options (117.22s) --- PASS: TestAccAWSVPCPeeringConnection_optionsNoAutoAccept (29.07s) --- PASS: TestAccAWSVPCPeeringConnection_peerRegionAutoAccept (29.13s) --- PASS: TestAccAWSVPCPeeringConnection_plan (52.19s) --- PASS: TestAccAWSVPCPeeringConnection_region (70.00s) --- PASS: TestAccAWSVPCPeeringConnection_tags (150.89s) --- PASS: TestAccAWSVPCPeeringConnectionAccepter_differentRegionDifferentAccount (68.06s) --- PASS: TestAccAWSVPCPeeringConnectionAccepter_differentRegionSameAccount (83.92s) --- PASS: TestAccAWSVPCPeeringConnectionAccepter_sameRegionDifferentAccount (64.85s) --- PASS: TestAccAWSVPCPeeringConnectionAccepter_sameRegionSameAccount (56.44s) --- PASS: TestAccAWSVpcPeeringConnectionOptions_basic (70.42s) --- PASS: TestAccAWSVpcPeeringConnectionOptions_differentRegionSameAccount (75.28s) --- PASS: TestAccAWSVpcPeeringConnectionOptions_sameRegionDifferentAccount (41.96s) --- FAIL: TestAccDataSourceAwsRoute53ResolverRule_SharedByMe (227.22s) --- FAIL: TestAccDataSourceAwsRoute53ResolverRule_SharedWithMe (228.00s) data_source_aws_route53_resolver_rule_test.go:101: Step 1/1 error: Error running apply: 2020/10/28 22:02:11 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0 Error: Error associating principal with RAM resource share: UnknownResourceException: Organization o-upyv668dz5 could not be found. --- FAIL: TestAccAWSEc2TransitGatewayVpcAttachment_SharedTransitGateway (221.84s) resource_aws_ec2_transit_gateway_vpc_attachment_test.go:215: Step 1/2 error: Error running apply: 2020/10/28 22:02:10 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0 Error: Error associating principal with RAM resource share: UnknownResourceException: Organization o-upyv668dz5 could not be found. Error: error associating RAM Resource Share: OperationNotPermittedException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress. --- FAIL: TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_Tags (201.45s) --- FAIL: TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_TransitGatewayDefaultRouteTableAssociationAndPropagation (211.45s) --- FAIL: TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_basic (221.42s) resource_aws_ec2_transit_gateway_vpc_attachment_accepter_test.go:135: Step 1/4 error: Error running apply: 2020/10/28 22:02:11 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0 Error: error associating RAM Resource Share: OperationNotPermittedException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress. Error: Error associating principal with RAM resource share: OperationNotPermittedException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress. ```
bflad
added a commit
that referenced
this issue
Nov 2, 2020
…refactor testAccProviderFactories for broad usage (#15904) Reference: #8316 Reference: #15737 Reference: #15791 This change set continues the work of #15877, bringing a consistent pattern for cross-region and cross-account testing and removing previously deprecated provider-level test functions. The `testAccProviderFactories` global variable is now generically for every test that only requires a single provider and prevents the previous issues where extraneous gRPC plugins were extraneously created (sometimes causing `ulimit` issues, but broadly a performance fix to remove them). This also removes the temporary `testAccProviderFactoriesCur()` and `testAccProviderFactoriesEc2Classic()` functions, since anything only requiring a single provider can use `ProviderFactories: testAccProviderFactories` or `Providers: testAccProviders` (for now, its deprecated in the SDK and we'll be updating these everywhere to `ProviderFactories` anyways). This should mean that other existing EC2-Classic and special service region testing should not require changes to that particular field in future change sets that continue this effort. After this, we are off to the races to remove the problematic environment variable handling causing issues across the provider acceptance testing. Output from acceptance testing (CUR testing done in standalone account): ``` --- PASS: TestAccDataSourceAwsCurReportDefinition_additional (21.63s) --- PASS: TestAccDataSourceAwsCurReportDefinition_basic (18.93s) --- PASS: TestAccDataSourceAwsRoute53ResolverRule_basic (59.47s) --- PASS: TestAccDataSourceAwsRoute53ResolverRule_ResolverEndpointIdWithTags (265.34s) --- PASS: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn (158.62s) --- PASS: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn_ConflictsWithCloudFrontDefaultCertificate (159.67s) --- PASS: TestAccAWSCodePipeline_multiregion_basic (37.37s) --- PASS: TestAccAWSCodePipeline_multiregion_Update (58.07s) --- PASS: TestAccAWSCodePipeline_multiregion_ConvertSingleRegion (81.33s) --- PASS: TestAccAwsCurReportDefinition_athena (18.30s) --- PASS: TestAccAwsCurReportDefinition_basic (23.58s) --- PASS: TestAccAwsCurReportDefinition_overwrite (18.10s) --- PASS: TestAccAwsCurReportDefinition_parquet (18.67s) --- PASS: TestAccAwsCurReportDefinition_refresh (21.62s) --- PASS: TestAccAwsCurReportDefinition_textOrCsv (21.45s) --- PASS: TestAccAWSDbSubnetGroupDataSource_basic (66.22s) --- PASS: TestAccAWSDbSubnetGroupDataSource_nonexistent (3.06s) --- PASS: TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewayCrossAccount (1998.47s) --- PASS: TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewaySingleAccount (1957.89s) --- PASS: TestAccAwsDxGatewayAssociation_basicTransitGatewayCrossAccount (865.40s) --- PASS: TestAccAwsDxGatewayAssociation_basicTransitGatewaySingleAccount (1186.07s) --- PASS: TestAccAwsDxGatewayAssociation_basicVpnGatewayCrossAccount (1530.51s) --- PASS: TestAccAwsDxGatewayAssociation_basicVpnGatewaySingleAccount (1633.65s) --- PASS: TestAccAwsDxGatewayAssociation_multiVpnGatewaysSingleAccount (1697.33s) --- PASS: TestAccAwsDxGatewayAssociation_V0StateUpgrade (1187.97s) --- PASS: TestAccAwsDxGatewayAssociationProposal_AllowedPrefixes (138.31s) --- PASS: TestAccAwsDxGatewayAssociationProposal_basicTransitGateway (227.10s) --- PASS: TestAccAwsDxGatewayAssociationProposal_basicVpnGateway (68.42s) --- PASS: TestAccAwsDxGatewayAssociationProposal_disappears (64.49s) --- SKIP: TestAccAwsDxHostedPrivateVirtualInterface_AccepterTags (0.00s) --- SKIP: TestAccAwsDxHostedPrivateVirtualInterface_basic (0.00s) --- SKIP: TestAccAwsDxHostedPublicVirtualInterface_AccepterTags (0.00s) --- SKIP: TestAccAwsDxHostedPublicVirtualInterface_basic (0.00s) --- PASS: TestAccAwsDxHostedTransitVirtualInterface_serial (0.00s) --- SKIP: TestAccAwsDxHostedTransitVirtualInterface_serial/accepterTags (0.00s) --- SKIP: TestAccAwsDxHostedTransitVirtualInterface_serial/basic (0.00s) --- PASS: TestAccAWSDynamoDbGlobalTable_basic (84.93s) --- PASS: TestAccAWSDynamoDbGlobalTable_multipleRegions (102.52s) --- PASS: TestAccAWSEbsSnapshotCopy_withRegions (75.67s) --- PASS: TestAccAwsRamResourceShareAccepter_basic (36.70s) --- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_PrimarySecondaryClusters (1969.60s) --- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_ReplicationSourceIdentifier (1819.35s) --- PASS: TestAccAWSRDSCluster_ReplicationSourceIdentifier_KmsKeyId (1691.11s) --- PASS: TestAccAWSRedshiftCluster_snapshotCopy (631.18s) --- PASS: TestAccAWSRedshiftSecurityGroup_basic (11.11s) --- PASS: TestAccAWSRedshiftSecurityGroup_ingressCidr (11.10s) --- PASS: TestAccAWSRedshiftSecurityGroup_ingressSecurityGroup (12.47s) --- PASS: TestAccAWSRedshiftSecurityGroup_updateIngressCidr (23.94s) --- PASS: TestAccAWSRedshiftSecurityGroup_updateIngressSecurityGroup (27.22s) --- PASS: TestAccAWSRoute53VpcAssociationAuthorization_basic (99.00s) --- PASS: TestAccAWSRoute53VpcAssociationAuthorization_disappears (94.43s) --- PASS: TestAccAWSRoute53ZoneAssociation_CrossAccount (124.58s) --- PASS: TestAccAWSRoute53ZoneAssociation_CrossRegion (157.69s) --- PASS: TestAccAWSS3Bucket_Replication (145.26s) --- PASS: TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AccessControlTranslation (86.49s) --- PASS: TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AddAccessControlTranslation (84.75s) --- PASS: TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError (22.79s) --- PASS: TestAccAWSS3Bucket_ReplicationSchemaV2 (174.11s) --- PASS: TestAccAWSS3Bucket_ReplicationWithoutPrefix (65.38s) --- PASS: TestAccAWSS3Bucket_ReplicationWithoutStorageClass (85.05s) --- PASS: TestAccAWSS3Bucket_SameRegionReplicationSchemaV2 (73.58s) --- PASS: TestAccAWSSubnet_ignoreTags (86.24s) --- PASS: TestAccAWSVPCPeeringConnection_accept (144.21s) --- PASS: TestAccAWSVPCPeeringConnection_basic (65.98s) --- PASS: TestAccAWSVPCPeeringConnection_failedState (12.38s) --- PASS: TestAccAWSVPCPeeringConnection_options (117.22s) --- PASS: TestAccAWSVPCPeeringConnection_optionsNoAutoAccept (29.07s) --- PASS: TestAccAWSVPCPeeringConnection_peerRegionAutoAccept (29.13s) --- PASS: TestAccAWSVPCPeeringConnection_plan (52.19s) --- PASS: TestAccAWSVPCPeeringConnection_region (70.00s) --- PASS: TestAccAWSVPCPeeringConnection_tags (150.89s) --- PASS: TestAccAWSVPCPeeringConnectionAccepter_differentRegionDifferentAccount (68.06s) --- PASS: TestAccAWSVPCPeeringConnectionAccepter_differentRegionSameAccount (83.92s) --- PASS: TestAccAWSVPCPeeringConnectionAccepter_sameRegionDifferentAccount (64.85s) --- PASS: TestAccAWSVPCPeeringConnectionAccepter_sameRegionSameAccount (56.44s) --- PASS: TestAccAWSVpcPeeringConnectionOptions_basic (70.42s) --- PASS: TestAccAWSVpcPeeringConnectionOptions_differentRegionSameAccount (75.28s) --- PASS: TestAccAWSVpcPeeringConnectionOptions_sameRegionDifferentAccount (41.96s) --- FAIL: TestAccDataSourceAwsRoute53ResolverRule_SharedByMe (227.22s) --- FAIL: TestAccDataSourceAwsRoute53ResolverRule_SharedWithMe (228.00s) data_source_aws_route53_resolver_rule_test.go:101: Step 1/1 error: Error running apply: 2020/10/28 22:02:11 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0 Error: Error associating principal with RAM resource share: UnknownResourceException: Organization o-upyv668dz5 could not be found. --- FAIL: TestAccAWSEc2TransitGatewayVpcAttachment_SharedTransitGateway (221.84s) resource_aws_ec2_transit_gateway_vpc_attachment_test.go:215: Step 1/2 error: Error running apply: 2020/10/28 22:02:10 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0 Error: Error associating principal with RAM resource share: UnknownResourceException: Organization o-upyv668dz5 could not be found. Error: error associating RAM Resource Share: OperationNotPermittedException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress. --- FAIL: TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_Tags (201.45s) --- FAIL: TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_TransitGatewayDefaultRouteTableAssociationAndPropagation (211.45s) --- FAIL: TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_basic (221.42s) resource_aws_ec2_transit_gateway_vpc_attachment_accepter_test.go:135: Step 1/4 error: Error running apply: 2020/10/28 22:02:11 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0 Error: error associating RAM Resource Share: OperationNotPermittedException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress. Error: Error associating principal with RAM resource share: OperationNotPermittedException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress. ```
bflad
added a commit
that referenced
this issue
Nov 2, 2020
…ndling Reference: #8316 Reference: #15791 Previously in AWS Commercial: ``` === CONT TestAccAWSDBInstance_ec2Classic TestAccAWSDBInstance_ec2Classic: resource_aws_db_instance_test.go:2242: Step 1/1 error: Error running apply: 2020/11/02 10:23:21 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0 Error: Error creating DB Instance: InsufficientDBInstanceCapacity: Cannot create a db.t3.micro database instance because there are no availability zones with sufficient capacity for non-VPC and storage type : standard for db.t3.micro. Please try the request again at a later time. status code: 400, request id: cb437def-f533-4894-874a-235bef9fe874 --- FAIL: TestAccAWSDBInstance_ec2Classic (11.36s) ``` Previously in AWS GovCloud (US): ``` === CONT TestAccAWSDbInstanceDataSource_ec2Classic TestAccAWSDbInstanceDataSource_ec2Classic: provider_test.go:196: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid. status code: 403, request id: 4f3cfbfa-bc43-46bd-8834-5eeb10cc4fc9 []}] --- FAIL: TestAccAWSDbInstanceDataSource_ec2Classic (0.49s) === CONT TestAccAWSDBInstance_ec2Classic TestAccAWSDBInstance_ec2Classic: provider_test.go:196: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid. status code: 403, request id: 2af3b934-784b-43e5-8e67-38b7b7333b94 []}] --- FAIL: TestAccAWSDBInstance_ec2Classic (0.38s) === CONT TestAccAWSDBSecurityGroup_basic TestAccAWSDBSecurityGroup_basic: provider_test.go:196: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid. status code: 403, request id: 2ac5b1af-30f7-4c64-81d8-0cf983ce035b []}] --- FAIL: TestAccAWSDBSecurityGroup_basic (0.33s) ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSDbInstanceDataSource_ec2Classic (452.57s) --- PASS: TestAccAWSDBInstance_ec2Classic (496.81s) --- PASS: TestAccAWSDBSecurityGroup_basic (35.95s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- SKIP: TestAccAWSDbInstanceDataSource_ec2Classic (2.84s) --- SKIP: TestAccAWSDBInstance_ec2Classic (2.81s) --- SKIP: TestAccAWSDBSecurityGroup_basic (2.72s) ```
This was referenced Nov 2, 2020
bflad
added a commit
that referenced
this issue
Nov 4, 2020
… handling Reference: #8316 Reference: #15737 Reference: #15791 Previously in AWS GovCloud (US): ``` === RUN TestAccAWSDefaultSecurityGroup_Classic_basic TestAccAWSDefaultSecurityGroup_Classic_basic: provider_test.go:196: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid. status code: 403, request id: fc6cf64f-8c40-4e8b-a37c-a82d8c6a69c9 []}] --- FAIL: TestAccAWSDefaultSecurityGroup_Classic_basic (0.40s) ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSDefaultSecurityGroup_Classic_basic (16.47s) --- SKIP: TestAccAWSDefaultSecurityGroup_Classic_empty (0.00s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- SKIP: TestAccAWSDefaultSecurityGroup_Classic_basic (2.90s) --- SKIP: TestAccAWSDefaultSecurityGroup_Classic_empty (0.00s) ```
bflad
added a commit
that referenced
this issue
Nov 4, 2020
…ndling (#15973) Reference: #8316 Reference: #15791 Previously in AWS Commercial: ``` === CONT TestAccAWSDBInstance_ec2Classic TestAccAWSDBInstance_ec2Classic: resource_aws_db_instance_test.go:2242: Step 1/1 error: Error running apply: 2020/11/02 10:23:21 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0 Error: Error creating DB Instance: InsufficientDBInstanceCapacity: Cannot create a db.t3.micro database instance because there are no availability zones with sufficient capacity for non-VPC and storage type : standard for db.t3.micro. Please try the request again at a later time. status code: 400, request id: cb437def-f533-4894-874a-235bef9fe874 --- FAIL: TestAccAWSDBInstance_ec2Classic (11.36s) ``` Previously in AWS GovCloud (US): ``` === CONT TestAccAWSDbInstanceDataSource_ec2Classic TestAccAWSDbInstanceDataSource_ec2Classic: provider_test.go:196: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid. status code: 403, request id: 4f3cfbfa-bc43-46bd-8834-5eeb10cc4fc9 []}] --- FAIL: TestAccAWSDbInstanceDataSource_ec2Classic (0.49s) === CONT TestAccAWSDBInstance_ec2Classic TestAccAWSDBInstance_ec2Classic: provider_test.go:196: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid. status code: 403, request id: 2af3b934-784b-43e5-8e67-38b7b7333b94 []}] --- FAIL: TestAccAWSDBInstance_ec2Classic (0.38s) === CONT TestAccAWSDBSecurityGroup_basic TestAccAWSDBSecurityGroup_basic: provider_test.go:196: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid. status code: 403, request id: 2ac5b1af-30f7-4c64-81d8-0cf983ce035b []}] --- FAIL: TestAccAWSDBSecurityGroup_basic (0.33s) ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSDbInstanceDataSource_ec2Classic (452.57s) --- PASS: TestAccAWSDBInstance_ec2Classic (496.81s) --- PASS: TestAccAWSDBSecurityGroup_basic (35.95s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- SKIP: TestAccAWSDbInstanceDataSource_ec2Classic (2.84s) --- SKIP: TestAccAWSDBInstance_ec2Classic (2.81s) --- SKIP: TestAccAWSDBSecurityGroup_basic (2.72s) ```
bflad
added a commit
that referenced
this issue
Nov 4, 2020
…hardcoded us-east-1 environment variable handling in tests Reference: #8316 Reference: #15737 Reference: #15791 Reference: #16018 (to run testing locally) Changes: ``` * resource/aws_eip: In EC2-Classic, wait until Instance returns as associated during create or update * resource/aws_eip_association: Retry on additional EC2 Address eventual consistency errors on creation * resource/aws_eip_association: In EC2-Classic, wait until Instance returns as associated during creation ``` Previously in AWS Commercial: ``` === RUN TestAccAWSEIP_Ec2Classic TestAccAWSEIP_Ec2Classic: resource_aws_eip_test.go:96: Step 1/2 error: After applying this test step, the plan was not empty. stdout: An execution plan has been generated and is shown below. Resource actions are indicated with the following symbols: ~ update in-place Terraform will perform the following actions: # aws_eip.test will be updated in-place ~ resource "aws_eip" "test" { domain = "standard" id = "52.0.143.158" + instance = "i-0c0a6ad483e281c59" public_dns = "ec2-52-0-143-158.compute-1.amazonaws.com" public_ip = "52.0.143.158" public_ipv4_pool = "amazon" vpc = false } Plan: 0 to add, 1 to change, 0 to destroy. --- FAIL: TestAccAWSEIP_Ec2Classic (153.41s) === CONT TestAccAWSEIPAssociation_ec2Classic resource_aws_eip_association_test.go:97: Step 1/2 error: After applying this test step, the plan was not empty. stdout: An execution plan has been generated and is shown below. Resource actions are indicated with the following symbols: -/+ destroy and then create replacement Terraform will perform the following actions: # aws_eip_association.test must be replaced -/+ resource "aws_eip_association" "test" { + allocation_id = (known after apply) ~ id = "34.224.14.254" -> (known after apply) + instance_id = "i-0ab9e7598ae44485f" + network_interface_id = (known after apply) + private_ip_address = (known after apply) public_ip = "34.224.14.254" } Plan: 1 to add, 0 to change, 1 to destroy. --- FAIL: TestAccAWSEIPAssociation_ec2Classic (74.15s) === CONT TestAccAWSEIPAssociation_ec2Classic resource_aws_eip_association_test.go:97: Step 1/2 error: Error running apply: 2020/11/03 09:35:32 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0 Error: Error associating EIP: AuthFailure: The address '34.239.37.205' does not belong to you. status code: 400, request id: d4163627-4987-4466-a297-aa2a48331dc9 === CONT TestAccAWSEIPAssociation_disappears resource_aws_eip_association_test.go:154: Step 1/1 error: Error running apply: 2020/11/03 09:35:33 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0 Error: Error associating EIP: InvalidAllocationID.NotFound: The allocation ID 'eipalloc-0780b47e4b04f970a' does not exist status code: 400, request id: 2c1a4d76-0ec2-45d7-9427-89d6e5de03ec === CONT TestAccAWSEIPAssociation_networkInterface resource_aws_eip_association_test.go:43: Step 1/2 error: Error running apply: 2020/11/03 09:35:30 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0 Error: Error associating EIP: InvalidAllocationID.NotFound: The allocation ID 'eipalloc-071e65b698ca98f08' does not exist status code: 400, request id: 862d2320-e52a-45ef-854c-9cc90004bf77 ``` Previously in AWS GovCloud (US): ``` === RUN TestAccAWSEIPAssociation_ec2Classic TestAccAWSEIPAssociation_ec2Classic: provider_test.go:196: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid. status code: 403, request id: f2a9b7c4-2448-47a0-b5ea-87de84dd9b7a []}] --- FAIL: TestAccAWSEIPAssociation_ec2Classic (0.36s) ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSEIP_associated_user_private_ip (231.25s) --- PASS: TestAccAWSEIP_basic (18.88s) --- PASS: TestAccAWSEIP_disappears (12.62s) --- PASS: TestAccAWSEIP_Ec2Classic (195.34s) --- PASS: TestAccAWSEIP_instance (99.75s) --- PASS: TestAccAWSEIP_Instance_Reassociate (126.92s) --- PASS: TestAccAWSEIP_networkInterface (81.71s) --- PASS: TestAccAWSEIP_notAssociated (144.46s) --- PASS: TestAccAWSEIP_PublicIpv4Pool_default (18.84s) --- PASS: TestAccAWSEIP_tags_Ec2Classic (7.61s) --- PASS: TestAccAWSEIP_tags_Vpc (26.35s) --- PASS: TestAccAWSEIP_twoEIPsOneNetworkInterface (82.93s) --- SKIP: TestAccAWSEIP_CustomerOwnedIpv4Pool (2.47s) --- SKIP: TestAccAWSEIP_PublicIpv4Pool_custom (0.00s) --- PASS: TestAccAWSEIPAssociation_basic (159.35s) --- PASS: TestAccAWSEIPAssociation_disappears (101.24s) --- PASS: TestAccAWSEIPAssociation_ec2Classic (93.73s) --- PASS: TestAccAWSEIPAssociation_instance (93.00s) --- PASS: TestAccAWSEIPAssociation_networkInterface (71.25s) --- PASS: TestAccAWSEIPAssociation_spotInstance (71.11s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAWSEIP_associated_user_private_ip (245.88s) --- PASS: TestAccAWSEIP_basic (23.76s) --- PASS: TestAccAWSEIP_disappears (16.42s) --- PASS: TestAccAWSEIP_instance (107.18s) --- PASS: TestAccAWSEIP_Instance_Reassociate (165.24s) --- PASS: TestAccAWSEIP_networkInterface (90.37s) --- PASS: TestAccAWSEIP_notAssociated (146.54s) --- PASS: TestAccAWSEIP_PublicIpv4Pool_default (24.04s) --- PASS: TestAccAWSEIP_tags_Vpc (37.31s) --- PASS: TestAccAWSEIP_twoEIPsOneNetworkInterface (90.85s) --- SKIP: TestAccAWSEIP_CustomerOwnedIpv4Pool (2.86s) --- SKIP: TestAccAWSEIP_Ec2Classic (2.89s) --- SKIP: TestAccAWSEIP_PublicIpv4Pool_custom (0.00s) --- SKIP: TestAccAWSEIP_tags_Ec2Classic (2.89s) --- PASS: TestAccAWSEIPAssociation_basic (156.32s) --- PASS: TestAccAWSEIPAssociation_disappears (130.31s) --- PASS: TestAccAWSEIPAssociation_instance (89.29s) --- PASS: TestAccAWSEIPAssociation_networkInterface (79.42s) --- PASS: TestAccAWSEIPAssociation_spotInstance (68.02s) --- SKIP: TestAccAWSEIPAssociation_ec2Classic (2.92s) ```
bflad
added a commit
that referenced
this issue
Nov 5, 2020
Reference: #8316 Reference: #15737 Reference: #15791 Previously in AWS GovCloud (US): ``` === RUN TestAccAWSElasticacheCluster_SecurityGroup_Ec2Classic TestAccAWSElasticacheCluster_SecurityGroup_Ec2Classic: provider_test.go:184: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid. status code: 403, request id: 9df5bb8f-fad4-4e95-9262-c306e610a3cf []}] --- FAIL: TestAccAWSElasticacheCluster_SecurityGroup_Ec2Classic (0.32s) === CONT TestAccAWSElasticacheSecurityGroup_basic TestAccAWSElasticacheSecurityGroup_basic: provider_test.go:184: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid. status code: 403, request id: 925ee8e0-4c50-4e40-a1aa-115a09a1603c []}] --- FAIL: TestAccAWSElasticacheSecurityGroup_basic (0.43s) ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSElasticacheCluster_SecurityGroup_Ec2Classic (533.02s) --- PASS: TestAccAWSElasticacheSecurityGroup_basic (13.61s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- SKIP: TestAccAWSElasticacheCluster_SecurityGroup_Ec2Classic (3.28s) --- SKIP: TestAccAWSElasticacheSecurityGroup_basic (2.85s) ```
bflad
added a commit
that referenced
this issue
Nov 5, 2020
Reference: #8316 Reference: #15737 Reference: #15791 Previously in AWS GovCloud (US): ``` === RUN TestAccAWSInstance_inEc2Classic TestAccAWSInstance_inEc2Classic: provider_test.go:184: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid. status code: 403, request id: 23aa824d-1186-4ea7-803b-4d857190e77c []}] --- FAIL: TestAccAWSInstance_inEc2Classic (0.71s) ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSInstance_inEc2Classic (96.92s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- SKIP: TestAccAWSInstance_inEc2Classic (2.79s) ```
This was referenced Nov 5, 2020
bflad
added a commit
that referenced
this issue
Nov 5, 2020
Reference: #8316 Reference: #15737 Reference: #15791 Previously in AWS GovCloud (US): ``` === RUN TestAccAWSSecurityGroup_defaultEgressClassic TestAccAWSSecurityGroup_defaultEgressClassic: provider_test.go:184: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid. status code: 403, request id: 80bb55a7-5ac8-46b6-8c39-cf4f09bb4cd5 []}] --- FAIL: TestAccAWSSecurityGroup_defaultEgressClassic (0.50s) === RUN TestAccAWSSecurityGroup_ingressWithCidrAndSGsClassic TestAccAWSSecurityGroup_ingressWithCidrAndSGsClassic: provider_test.go:184: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid. status code: 403, request id: 9909088a-dd37-40db-8774-2ea613dd1b3d []}] --- FAIL: TestAccAWSSecurityGroup_ingressWithCidrAndSGsClassic (0.50s) ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSSecurityGroup_defaultEgressClassic (12.50s) --- PASS: TestAccAWSSecurityGroup_ingressWithCidrAndSGsClassic (14.84s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- SKIP: TestAccAWSSecurityGroup_defaultEgressClassic (2.90s) --- SKIP: TestAccAWSSecurityGroup_ingressWithCidrAndSGsClassic (2.90s) ```
bflad
added a commit
that referenced
this issue
Nov 11, 2020
… handling (#16026) * tests/resource/aws_default_security_group: Remove hardcoded us-east-1 handling Reference: #8316 Reference: #15737 Reference: #15791 Previously in AWS GovCloud (US): ``` === RUN TestAccAWSDefaultSecurityGroup_Classic_basic TestAccAWSDefaultSecurityGroup_Classic_basic: provider_test.go:196: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid. status code: 403, request id: fc6cf64f-8c40-4e8b-a37c-a82d8c6a69c9 []}] --- FAIL: TestAccAWSDefaultSecurityGroup_Classic_basic (0.40s) ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSDefaultSecurityGroup_Classic_basic (16.47s) --- SKIP: TestAccAWSDefaultSecurityGroup_Classic_empty (0.00s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- SKIP: TestAccAWSDefaultSecurityGroup_Classic_basic (2.90s) --- SKIP: TestAccAWSDefaultSecurityGroup_Classic_empty (0.00s) ``` * tests/resource/aws_default_security_group: Ensure EC2-Classic ARN checking is separate from regular ARN checking
bflad
added a commit
that referenced
this issue
Nov 11, 2020
) Reference: #8316 Reference: #15737 Reference: #15791 Previously in AWS GovCloud (US): ``` === RUN TestAccAWSInstance_inEc2Classic TestAccAWSInstance_inEc2Classic: provider_test.go:184: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid. status code: 403, request id: 23aa824d-1186-4ea7-803b-4d857190e77c []}] --- FAIL: TestAccAWSInstance_inEc2Classic (0.71s) ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSInstance_inEc2Classic (96.92s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- SKIP: TestAccAWSInstance_inEc2Classic (2.79s) ```
bflad
added a commit
that referenced
this issue
Nov 11, 2020
#16036) Reference: #8316 Reference: #15737 Reference: #15791 Previously in AWS GovCloud (US): ``` === RUN TestAccAWSSecurityGroup_defaultEgressClassic TestAccAWSSecurityGroup_defaultEgressClassic: provider_test.go:184: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid. status code: 403, request id: 80bb55a7-5ac8-46b6-8c39-cf4f09bb4cd5 []}] --- FAIL: TestAccAWSSecurityGroup_defaultEgressClassic (0.50s) === RUN TestAccAWSSecurityGroup_ingressWithCidrAndSGsClassic TestAccAWSSecurityGroup_ingressWithCidrAndSGsClassic: provider_test.go:184: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid. status code: 403, request id: 9909088a-dd37-40db-8774-2ea613dd1b3d []}] --- FAIL: TestAccAWSSecurityGroup_ingressWithCidrAndSGsClassic (0.50s) ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSSecurityGroup_defaultEgressClassic (12.50s) --- PASS: TestAccAWSSecurityGroup_ingressWithCidrAndSGsClassic (14.84s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- SKIP: TestAccAWSSecurityGroup_defaultEgressClassic (2.90s) --- SKIP: TestAccAWSSecurityGroup_ingressWithCidrAndSGsClassic (2.90s) ```
bflad
added a commit
that referenced
this issue
Nov 11, 2020
Reference: #8316 Reference: #15737 Reference: #15791 Previously in AWS GovCloud (US): ``` === RUN TestAccAWSElasticacheCluster_SecurityGroup_Ec2Classic TestAccAWSElasticacheCluster_SecurityGroup_Ec2Classic: provider_test.go:184: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid. status code: 403, request id: 9df5bb8f-fad4-4e95-9262-c306e610a3cf []}] --- FAIL: TestAccAWSElasticacheCluster_SecurityGroup_Ec2Classic (0.32s) === CONT TestAccAWSElasticacheSecurityGroup_basic TestAccAWSElasticacheSecurityGroup_basic: provider_test.go:184: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid. status code: 403, request id: 925ee8e0-4c50-4e40-a1aa-115a09a1603c []}] --- FAIL: TestAccAWSElasticacheSecurityGroup_basic (0.43s) ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSElasticacheCluster_SecurityGroup_Ec2Classic (533.02s) --- PASS: TestAccAWSElasticacheSecurityGroup_basic (13.61s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- SKIP: TestAccAWSElasticacheCluster_SecurityGroup_Ec2Classic (3.28s) --- SKIP: TestAccAWSElasticacheSecurityGroup_basic (2.85s) ```
bflad
added a commit
that referenced
this issue
Nov 12, 2020
…hardcoded us-east-1 environment variable handling in tests (#16032) Reference: #8316 Reference: #15737 Reference: #15791 Reference: #16018 (to run testing locally) Changes: ``` * resource/aws_eip: In EC2-Classic, wait until Instance returns as associated during create or update * resource/aws_eip_association: Retry on additional EC2 Address eventual consistency errors on creation * resource/aws_eip_association: In EC2-Classic, wait until Instance returns as associated during creation ``` Previously in AWS Commercial: ``` === RUN TestAccAWSEIP_Ec2Classic TestAccAWSEIP_Ec2Classic: resource_aws_eip_test.go:96: Step 1/2 error: After applying this test step, the plan was not empty. stdout: An execution plan has been generated and is shown below. Resource actions are indicated with the following symbols: ~ update in-place Terraform will perform the following actions: # aws_eip.test will be updated in-place ~ resource "aws_eip" "test" { domain = "standard" id = "52.0.143.158" + instance = "i-0c0a6ad483e281c59" public_dns = "ec2-52-0-143-158.compute-1.amazonaws.com" public_ip = "52.0.143.158" public_ipv4_pool = "amazon" vpc = false } Plan: 0 to add, 1 to change, 0 to destroy. --- FAIL: TestAccAWSEIP_Ec2Classic (153.41s) === CONT TestAccAWSEIPAssociation_ec2Classic resource_aws_eip_association_test.go:97: Step 1/2 error: After applying this test step, the plan was not empty. stdout: An execution plan has been generated and is shown below. Resource actions are indicated with the following symbols: -/+ destroy and then create replacement Terraform will perform the following actions: # aws_eip_association.test must be replaced -/+ resource "aws_eip_association" "test" { + allocation_id = (known after apply) ~ id = "34.224.14.254" -> (known after apply) + instance_id = "i-0ab9e7598ae44485f" + network_interface_id = (known after apply) + private_ip_address = (known after apply) public_ip = "34.224.14.254" } Plan: 1 to add, 0 to change, 1 to destroy. --- FAIL: TestAccAWSEIPAssociation_ec2Classic (74.15s) === CONT TestAccAWSEIPAssociation_ec2Classic resource_aws_eip_association_test.go:97: Step 1/2 error: Error running apply: 2020/11/03 09:35:32 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0 Error: Error associating EIP: AuthFailure: The address '34.239.37.205' does not belong to you. status code: 400, request id: d4163627-4987-4466-a297-aa2a48331dc9 === CONT TestAccAWSEIPAssociation_disappears resource_aws_eip_association_test.go:154: Step 1/1 error: Error running apply: 2020/11/03 09:35:33 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0 Error: Error associating EIP: InvalidAllocationID.NotFound: The allocation ID 'eipalloc-0780b47e4b04f970a' does not exist status code: 400, request id: 2c1a4d76-0ec2-45d7-9427-89d6e5de03ec === CONT TestAccAWSEIPAssociation_networkInterface resource_aws_eip_association_test.go:43: Step 1/2 error: Error running apply: 2020/11/03 09:35:30 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0 Error: Error associating EIP: InvalidAllocationID.NotFound: The allocation ID 'eipalloc-071e65b698ca98f08' does not exist status code: 400, request id: 862d2320-e52a-45ef-854c-9cc90004bf77 ``` Previously in AWS GovCloud (US): ``` === RUN TestAccAWSEIPAssociation_ec2Classic TestAccAWSEIPAssociation_ec2Classic: provider_test.go:196: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid. status code: 403, request id: f2a9b7c4-2448-47a0-b5ea-87de84dd9b7a []}] --- FAIL: TestAccAWSEIPAssociation_ec2Classic (0.36s) ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSEIP_associated_user_private_ip (231.25s) --- PASS: TestAccAWSEIP_basic (18.88s) --- PASS: TestAccAWSEIP_disappears (12.62s) --- PASS: TestAccAWSEIP_Ec2Classic (195.34s) --- PASS: TestAccAWSEIP_instance (99.75s) --- PASS: TestAccAWSEIP_Instance_Reassociate (126.92s) --- PASS: TestAccAWSEIP_networkInterface (81.71s) --- PASS: TestAccAWSEIP_notAssociated (144.46s) --- PASS: TestAccAWSEIP_PublicIpv4Pool_default (18.84s) --- PASS: TestAccAWSEIP_tags_Ec2Classic (7.61s) --- PASS: TestAccAWSEIP_tags_Vpc (26.35s) --- PASS: TestAccAWSEIP_twoEIPsOneNetworkInterface (82.93s) --- SKIP: TestAccAWSEIP_CustomerOwnedIpv4Pool (2.47s) --- SKIP: TestAccAWSEIP_PublicIpv4Pool_custom (0.00s) --- PASS: TestAccAWSEIPAssociation_basic (159.35s) --- PASS: TestAccAWSEIPAssociation_disappears (101.24s) --- PASS: TestAccAWSEIPAssociation_ec2Classic (93.73s) --- PASS: TestAccAWSEIPAssociation_instance (93.00s) --- PASS: TestAccAWSEIPAssociation_networkInterface (71.25s) --- PASS: TestAccAWSEIPAssociation_spotInstance (71.11s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAWSEIP_associated_user_private_ip (245.88s) --- PASS: TestAccAWSEIP_basic (23.76s) --- PASS: TestAccAWSEIP_disappears (16.42s) --- PASS: TestAccAWSEIP_instance (107.18s) --- PASS: TestAccAWSEIP_Instance_Reassociate (165.24s) --- PASS: TestAccAWSEIP_networkInterface (90.37s) --- PASS: TestAccAWSEIP_notAssociated (146.54s) --- PASS: TestAccAWSEIP_PublicIpv4Pool_default (24.04s) --- PASS: TestAccAWSEIP_tags_Vpc (37.31s) --- PASS: TestAccAWSEIP_twoEIPsOneNetworkInterface (90.85s) --- SKIP: TestAccAWSEIP_CustomerOwnedIpv4Pool (2.86s) --- SKIP: TestAccAWSEIP_Ec2Classic (2.89s) --- SKIP: TestAccAWSEIP_PublicIpv4Pool_custom (0.00s) --- SKIP: TestAccAWSEIP_tags_Ec2Classic (2.89s) --- PASS: TestAccAWSEIPAssociation_basic (156.32s) --- PASS: TestAccAWSEIPAssociation_disappears (130.31s) --- PASS: TestAccAWSEIPAssociation_instance (89.29s) --- PASS: TestAccAWSEIPAssociation_networkInterface (79.42s) --- PASS: TestAccAWSEIPAssociation_spotInstance (68.02s) --- SKIP: TestAccAWSEIPAssociation_ec2Classic (2.92s) ```
|
This has been released in version 3.15.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In our current testing environment, EC2-Classic is only supported in
us-east-1in one specific account. We have the pre-checktestAccEC2ClassicPreCheck()to skip tests when EC2-Classic is not supported.Currently, we hardcode the region
us-east-1and override theAWS_DEFAULT_REGIONenvironment variable.Using the environment variable override impacts other acceptance tests when run locally unless those tests are not run in parallel, i.e. run with
resource.Test()instead ofresource.ParallelTest(), so it is not ideal.In addition, the assumption that only
us-east-1supports EC2-Classic is incorrect, and only applies in our testing environment. EC2-Classic is also supported in GovCloud, which does not have the regionus-east-1.Our testing framework supports the use of alternate provider configurations and environment variables to define regions for specific types of tests. Defining an environment variable such as
AWS_EC2CLASSIC_REGIONwhich is used in an EC2-Classic-related provider configuration, for exampletestAccProviderEC2Classic(), would allow this to be addressed.The text was updated successfully, but these errors were encountered: