r/aws_instance: Remove hardcoded AMI IDs from acceptance tests #14159

ewbankkit · 2020-07-13T14:20:21Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #14082.
Relates #14083.
Relates #14145.
Relates #14147.
Relates #14148.
Relates #11126.
Relates #12994.

Release note for CHANGELOG:

NONE

Output from acceptance testing:

Default test region (`us-west-2`):

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 2 -run=TestAccAWSInstance_ -timeout 120m
=== RUN   TestAccAWSInstance_inDefaultVpcBySgName
=== PAUSE TestAccAWSInstance_inDefaultVpcBySgName
=== RUN   TestAccAWSInstance_inDefaultVpcBySgId
=== PAUSE TestAccAWSInstance_inDefaultVpcBySgId
=== RUN   TestAccAWSInstance_basic
=== PAUSE TestAccAWSInstance_basic
=== RUN   TestAccAWSInstance_atLeastOneOtherEbsVolume
=== PAUSE TestAccAWSInstance_atLeastOneOtherEbsVolume
=== RUN   TestAccAWSInstance_EbsBlockDevice_KmsKeyArn
=== PAUSE TestAccAWSInstance_EbsBlockDevice_KmsKeyArn
=== RUN   TestAccAWSInstance_RootBlockDevice_KmsKeyArn
=== PAUSE TestAccAWSInstance_RootBlockDevice_KmsKeyArn
=== RUN   TestAccAWSInstance_userDataBase64
=== PAUSE TestAccAWSInstance_userDataBase64
=== RUN   TestAccAWSInstance_GP2IopsDevice
=== PAUSE TestAccAWSInstance_GP2IopsDevice
=== RUN   TestAccAWSInstance_GP2WithIopsValue
=== PAUSE TestAccAWSInstance_GP2WithIopsValue
=== RUN   TestAccAWSInstance_blockDevices
=== PAUSE TestAccAWSInstance_blockDevices
=== RUN   TestAccAWSInstance_rootInstanceStore
=== PAUSE TestAccAWSInstance_rootInstanceStore
=== RUN   TestAccAWSInstance_noAMIEphemeralDevices
=== PAUSE TestAccAWSInstance_noAMIEphemeralDevices
=== RUN   TestAccAWSInstance_sourceDestCheck
=== PAUSE TestAccAWSInstance_sourceDestCheck
=== RUN   TestAccAWSInstance_disableApiTermination
=== PAUSE TestAccAWSInstance_disableApiTermination
=== RUN   TestAccAWSInstance_vpc
=== PAUSE TestAccAWSInstance_vpc
=== RUN   TestAccAWSInstance_outpost
=== PAUSE TestAccAWSInstance_outpost
=== RUN   TestAccAWSInstance_placementGroup
=== PAUSE TestAccAWSInstance_placementGroup
=== RUN   TestAccAWSInstance_ipv6_supportAddressCount
=== PAUSE TestAccAWSInstance_ipv6_supportAddressCount
=== RUN   TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError
=== PAUSE TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError
=== RUN   TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
=== PAUSE TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
=== RUN   TestAccAWSInstance_NetworkInstanceSecurityGroups
=== PAUSE TestAccAWSInstance_NetworkInstanceSecurityGroups
=== RUN   TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups
=== PAUSE TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups
=== RUN   TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs
=== PAUSE TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs
=== RUN   TestAccAWSInstance_tags
=== PAUSE TestAccAWSInstance_tags
=== RUN   TestAccAWSInstance_volumeTags
=== PAUSE TestAccAWSInstance_volumeTags
=== RUN   TestAccAWSInstance_volumeTagsComputed
=== PAUSE TestAccAWSInstance_volumeTagsComputed
=== RUN   TestAccAWSInstance_instanceProfileChange
=== PAUSE TestAccAWSInstance_instanceProfileChange
=== RUN   TestAccAWSInstance_withIamInstanceProfile
=== PAUSE TestAccAWSInstance_withIamInstanceProfile
=== RUN   TestAccAWSInstance_privateIP
=== PAUSE TestAccAWSInstance_privateIP
=== RUN   TestAccAWSInstance_associatePublicIPAndPrivateIP
=== PAUSE TestAccAWSInstance_associatePublicIPAndPrivateIP
=== RUN   TestAccAWSInstance_Empty_PrivateIP
=== PAUSE TestAccAWSInstance_Empty_PrivateIP
=== RUN   TestAccAWSInstance_keyPairCheck
=== PAUSE TestAccAWSInstance_keyPairCheck
=== RUN   TestAccAWSInstance_rootBlockDeviceMismatch
=== PAUSE TestAccAWSInstance_rootBlockDeviceMismatch
=== RUN   TestAccAWSInstance_forceNewAndTagsDrift
=== PAUSE TestAccAWSInstance_forceNewAndTagsDrift
=== RUN   TestAccAWSInstance_changeInstanceType
=== PAUSE TestAccAWSInstance_changeInstanceType
=== RUN   TestAccAWSInstance_EbsRootDevice_basic
=== PAUSE TestAccAWSInstance_EbsRootDevice_basic
=== RUN   TestAccAWSInstance_EbsRootDevice_ModifySize
=== PAUSE TestAccAWSInstance_EbsRootDevice_ModifySize
=== RUN   TestAccAWSInstance_EbsRootDevice_ModifyType
=== PAUSE TestAccAWSInstance_EbsRootDevice_ModifyType
=== RUN   TestAccAWSInstance_EbsRootDevice_ModifyIOPS
=== PAUSE TestAccAWSInstance_EbsRootDevice_ModifyIOPS
=== RUN   TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination
=== PAUSE TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination
=== RUN   TestAccAWSInstance_EbsRootDevice_ModifyAll
=== PAUSE TestAccAWSInstance_EbsRootDevice_ModifyAll
=== RUN   TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize
=== PAUSE TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize
=== RUN   TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination
=== PAUSE TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination
=== RUN   TestAccAWSInstance_EbsRootDevice_MultipleDynamicEBSBlockDevices
=== PAUSE TestAccAWSInstance_EbsRootDevice_MultipleDynamicEBSBlockDevices
=== RUN   TestAccAWSInstance_primaryNetworkInterface
=== PAUSE TestAccAWSInstance_primaryNetworkInterface
=== RUN   TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck
=== PAUSE TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck
=== RUN   TestAccAWSInstance_addSecondaryInterface
=== PAUSE TestAccAWSInstance_addSecondaryInterface
=== RUN   TestAccAWSInstance_addSecurityGroupNetworkInterface
=== PAUSE TestAccAWSInstance_addSecurityGroupNetworkInterface
=== RUN   TestAccAWSInstance_associatePublic_defaultPrivate
=== PAUSE TestAccAWSInstance_associatePublic_defaultPrivate
=== RUN   TestAccAWSInstance_associatePublic_defaultPublic
=== PAUSE TestAccAWSInstance_associatePublic_defaultPublic
=== RUN   TestAccAWSInstance_associatePublic_explicitPublic
=== PAUSE TestAccAWSInstance_associatePublic_explicitPublic
=== RUN   TestAccAWSInstance_associatePublic_explicitPrivate
=== PAUSE TestAccAWSInstance_associatePublic_explicitPrivate
=== RUN   TestAccAWSInstance_associatePublic_overridePublic
=== PAUSE TestAccAWSInstance_associatePublic_overridePublic
=== RUN   TestAccAWSInstance_associatePublic_overridePrivate
=== PAUSE TestAccAWSInstance_associatePublic_overridePrivate
=== RUN   TestAccAWSInstance_getPasswordData_falseToTrue
=== PAUSE TestAccAWSInstance_getPasswordData_falseToTrue
=== RUN   TestAccAWSInstance_getPasswordData_trueToFalse
=== PAUSE TestAccAWSInstance_getPasswordData_trueToFalse
=== RUN   TestAccAWSInstance_CreditSpecification_Empty_NonBurstable
=== PAUSE TestAccAWSInstance_CreditSpecification_Empty_NonBurstable
=== RUN   TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable
=== PAUSE TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable
=== RUN   TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard
=== PAUSE TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard
=== RUN   TestAccAWSInstance_creditSpecification_standardCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecification_standardCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_unlimitedCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecification_unlimitedCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2
=== PAUSE TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2
=== RUN   TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3
=== PAUSE TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3
=== RUN   TestAccAWSInstance_creditSpecification_updateCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecification_updateCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable
=== PAUSE TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable
=== RUN   TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited
=== PAUSE TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited
=== RUN   TestAccAWSInstance_creditSpecificationT3_standardCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecificationT3_standardCpuCredits
=== RUN   TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits
=== RUN   TestAccAWSInstance_creditSpecificationT3_updateCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecificationT3_updateCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint
=== PAUSE TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint
=== RUN   TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint
=== PAUSE TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint
=== RUN   TestAccAWSInstance_disappears
=== PAUSE TestAccAWSInstance_disappears
=== RUN   TestAccAWSInstance_UserData_EmptyStringToUnspecified
=== PAUSE TestAccAWSInstance_UserData_EmptyStringToUnspecified
=== RUN   TestAccAWSInstance_UserData_UnspecifiedToEmptyString
=== PAUSE TestAccAWSInstance_UserData_UnspecifiedToEmptyString
=== RUN   TestAccAWSInstance_hibernation
=== PAUSE TestAccAWSInstance_hibernation
=== RUN   TestAccAWSInstance_metadataOptions
=== PAUSE TestAccAWSInstance_metadataOptions
=== CONT  TestAccAWSInstance_inDefaultVpcBySgName
=== CONT  TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination
=== CONT  TestAccAWSInstance_metadataOptions
--- PASS: TestAccAWSInstance_inDefaultVpcBySgName (97.63s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination (127.11s)
=== CONT  TestAccAWSInstance_hibernation
--- PASS: TestAccAWSInstance_metadataOptions (143.94s)
=== CONT  TestAccAWSInstance_UserData_UnspecifiedToEmptyString
--- PASS: TestAccAWSInstance_hibernation (214.57s)
=== CONT  TestAccAWSInstance_UserData_EmptyStringToUnspecified
--- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (134.65s)
=== CONT  TestAccAWSInstance_disappears
--- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (154.63s)
=== CONT  TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint
--- PASS: TestAccAWSInstance_disappears (219.40s)
=== CONT  TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (227.81s)
=== CONT  TestAccAWSInstance_creditSpecificationT3_updateCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (226.12s)
=== CONT  TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits
--- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (183.32s)
=== CONT  TestAccAWSInstance_creditSpecificationT3_standardCpuCredits
--- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (159.96s)
=== CONT  TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited
--- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (117.51s)
=== CONT  TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable
--- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (110.42s)
=== CONT  TestAccAWSInstance_creditSpecification_updateCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (137.86s)
=== CONT  TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3 (97.30s)
=== CONT  TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2
--- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (184.03s)
=== CONT  TestAccAWSInstance_creditSpecification_unlimitedCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2 (107.59s)
=== CONT  TestAccAWSInstance_creditSpecification_standardCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (149.72s)
=== CONT  TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (137.71s)
=== CONT  TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable
--- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (117.72s)
=== CONT  TestAccAWSInstance_CreditSpecification_Empty_NonBurstable
--- PASS: TestAccAWSInstance_CreditSpecification_Empty_NonBurstable (126.18s)
=== CONT  TestAccAWSInstance_getPasswordData_trueToFalse
--- PASS: TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable (182.66s)
=== CONT  TestAccAWSInstance_getPasswordData_falseToTrue
--- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (184.88s)
=== CONT  TestAccAWSInstance_associatePublic_overridePrivate
--- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (171.68s)
=== CONT  TestAccAWSInstance_associatePublic_overridePublic
--- PASS: TestAccAWSInstance_associatePublic_overridePublic (107.00s)
=== CONT  TestAccAWSInstance_associatePublic_explicitPrivate
--- PASS: TestAccAWSInstance_associatePublic_overridePrivate (118.01s)
=== CONT  TestAccAWSInstance_associatePublic_explicitPublic
--- PASS: TestAccAWSInstance_associatePublic_explicitPublic (106.18s)
=== CONT  TestAccAWSInstance_associatePublic_defaultPublic
--- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (117.28s)
=== CONT  TestAccAWSInstance_associatePublic_defaultPrivate
--- PASS: TestAccAWSInstance_associatePublic_defaultPublic (116.86s)
=== CONT  TestAccAWSInstance_addSecurityGroupNetworkInterface
--- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (117.21s)
=== CONT  TestAccAWSInstance_addSecondaryInterface
--- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (167.32s)
=== CONT  TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck
--- PASS: TestAccAWSInstance_addSecondaryInterface (166.13s)
=== CONT  TestAccAWSInstance_primaryNetworkInterface
--- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (112.14s)
=== CONT  TestAccAWSInstance_EbsRootDevice_MultipleDynamicEBSBlockDevices
--- PASS: TestAccAWSInstance_primaryNetworkInterface (112.11s)
=== CONT  TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination (125.10s)
=== CONT  TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleDynamicEBSBlockDevices (224.62s)
=== CONT  TestAccAWSInstance_EbsRootDevice_ModifyAll
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize (167.34s)
=== CONT  TestAccAWSInstance_NetworkInstanceSecurityGroups
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyAll (157.15s)
=== CONT  TestAccAWSInstance_EbsRootDevice_ModifyIOPS
--- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (121.72s)
=== CONT  TestAccAWSInstance_EbsRootDevice_ModifyType
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyIOPS (166.98s)
=== CONT  TestAccAWSInstance_EbsRootDevice_ModifySize
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyType (167.95s)
=== CONT  TestAccAWSInstance_EbsRootDevice_basic
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifySize (145.38s)
=== CONT  TestAccAWSInstance_changeInstanceType
--- PASS: TestAccAWSInstance_EbsRootDevice_basic (130.60s)
=== CONT  TestAccAWSInstance_forceNewAndTagsDrift
--- PASS: TestAccAWSInstance_changeInstanceType (186.02s)
=== CONT  TestAccAWSInstance_rootBlockDeviceMismatch
--- PASS: TestAccAWSInstance_forceNewAndTagsDrift (163.17s)
=== CONT  TestAccAWSInstance_keyPairCheck
--- PASS: TestAccAWSInstance_keyPairCheck (90.50s)
=== CONT  TestAccAWSInstance_Empty_PrivateIP
--- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (105.05s)
=== CONT  TestAccAWSInstance_associatePublicIPAndPrivateIP
--- PASS: TestAccAWSInstance_Empty_PrivateIP (106.76s)
=== CONT  TestAccAWSInstance_privateIP
--- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (106.93s)
=== CONT  TestAccAWSInstance_withIamInstanceProfile
--- PASS: TestAccAWSInstance_privateIP (108.34s)
=== CONT  TestAccAWSInstance_instanceProfileChange
--- PASS: TestAccAWSInstance_withIamInstanceProfile (142.17s)
=== CONT  TestAccAWSInstance_volumeTagsComputed
--- PASS: TestAccAWSInstance_volumeTagsComputed (149.82s)
=== CONT  TestAccAWSInstance_volumeTags
--- PASS: TestAccAWSInstance_instanceProfileChange (221.21s)
=== CONT  TestAccAWSInstance_tags
--- PASS: TestAccAWSInstance_tags (149.82s)
=== CONT  TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs
--- PASS: TestAccAWSInstance_volumeTags (190.35s)
=== CONT  TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups
--- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (122.22s)
=== CONT  TestAccAWSInstance_rootInstanceStore
--- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (139.89s)
=== CONT  TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
--- PASS: TestAccAWSInstance_rootInstanceStore (118.90s)
=== CONT  TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError
--- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (30.87s)
=== CONT  TestAccAWSInstance_ipv6_supportAddressCount
--- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (117.89s)
=== CONT  TestAccAWSInstance_placementGroup
--- PASS: TestAccAWSInstance_placementGroup (98.78s)
=== CONT  TestAccAWSInstance_outpost
--- SKIP: TestAccAWSInstance_outpost (4.75s)
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts Outpost found
=== CONT  TestAccAWSInstance_vpc
--- PASS: TestAccAWSInstance_ipv6_supportAddressCount (107.04s)
=== CONT  TestAccAWSInstance_disableApiTermination
--- PASS: TestAccAWSInstance_vpc (125.35s)
=== CONT  TestAccAWSInstance_sourceDestCheck
--- PASS: TestAccAWSInstance_disableApiTermination (170.21s)
=== CONT  TestAccAWSInstance_noAMIEphemeralDevices
--- PASS: TestAccAWSInstance_noAMIEphemeralDevices (103.57s)
=== CONT  TestAccAWSInstance_RootBlockDevice_KmsKeyArn
--- PASS: TestAccAWSInstance_sourceDestCheck (194.48s)
=== CONT  TestAccAWSInstance_blockDevices
--- PASS: TestAccAWSInstance_RootBlockDevice_KmsKeyArn (128.31s)
=== CONT  TestAccAWSInstance_GP2WithIopsValue
--- PASS: TestAccAWSInstance_blockDevices (112.01s)
=== CONT  TestAccAWSInstance_GP2IopsDevice
--- PASS: TestAccAWSInstance_GP2WithIopsValue (122.13s)
=== CONT  TestAccAWSInstance_userDataBase64
--- PASS: TestAccAWSInstance_GP2IopsDevice (99.54s)
=== CONT  TestAccAWSInstance_atLeastOneOtherEbsVolume
--- PASS: TestAccAWSInstance_userDataBase64 (136.21s)
=== CONT  TestAccAWSInstance_EbsBlockDevice_KmsKeyArn
--- PASS: TestAccAWSInstance_atLeastOneOtherEbsVolume (190.06s)
=== CONT  TestAccAWSInstance_basic
--- PASS: TestAccAWSInstance_EbsBlockDevice_KmsKeyArn (104.13s)
=== CONT  TestAccAWSInstance_inDefaultVpcBySgId
--- PASS: TestAccAWSInstance_basic (133.61s)
--- PASS: TestAccAWSInstance_inDefaultVpcBySgId (149.29s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	5324.969s

ewbankkit · 2020-07-14T12:45:42Z

Non-default test region (`us-east-1` with EC2-Classic):

$ AWS_DEFAULT_REGION=us-east-1 make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 2 -run=TestAccAWSInstance_ -timeout 120m
=== RUN   TestAccAWSInstance_inDefaultVpcBySgName
=== PAUSE TestAccAWSInstance_inDefaultVpcBySgName
=== RUN   TestAccAWSInstance_inDefaultVpcBySgId
=== PAUSE TestAccAWSInstance_inDefaultVpcBySgId
=== RUN   TestAccAWSInstance_inEc2Classic
=== PAUSE TestAccAWSInstance_inEc2Classic
=== RUN   TestAccAWSInstance_basic
=== PAUSE TestAccAWSInstance_basic
=== RUN   TestAccAWSInstance_atLeastOneOtherEbsVolume
=== PAUSE TestAccAWSInstance_atLeastOneOtherEbsVolume
=== RUN   TestAccAWSInstance_EbsBlockDevice_KmsKeyArn
=== PAUSE TestAccAWSInstance_EbsBlockDevice_KmsKeyArn
=== RUN   TestAccAWSInstance_RootBlockDevice_KmsKeyArn
=== PAUSE TestAccAWSInstance_RootBlockDevice_KmsKeyArn
=== RUN   TestAccAWSInstance_userDataBase64
=== PAUSE TestAccAWSInstance_userDataBase64
=== RUN   TestAccAWSInstance_GP2IopsDevice
=== PAUSE TestAccAWSInstance_GP2IopsDevice
=== RUN   TestAccAWSInstance_GP2WithIopsValue
=== PAUSE TestAccAWSInstance_GP2WithIopsValue
=== RUN   TestAccAWSInstance_blockDevices
=== PAUSE TestAccAWSInstance_blockDevices
=== RUN   TestAccAWSInstance_rootInstanceStore
=== PAUSE TestAccAWSInstance_rootInstanceStore
=== RUN   TestAccAWSInstance_noAMIEphemeralDevices
=== PAUSE TestAccAWSInstance_noAMIEphemeralDevices
=== RUN   TestAccAWSInstance_sourceDestCheck
=== PAUSE TestAccAWSInstance_sourceDestCheck
=== RUN   TestAccAWSInstance_disableApiTermination
=== PAUSE TestAccAWSInstance_disableApiTermination
=== RUN   TestAccAWSInstance_vpc
=== PAUSE TestAccAWSInstance_vpc
=== RUN   TestAccAWSInstance_outpost
=== PAUSE TestAccAWSInstance_outpost
=== RUN   TestAccAWSInstance_placementGroup
=== PAUSE TestAccAWSInstance_placementGroup
=== RUN   TestAccAWSInstance_ipv6_supportAddressCount
=== PAUSE TestAccAWSInstance_ipv6_supportAddressCount
=== RUN   TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError
=== PAUSE TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError
=== RUN   TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
=== PAUSE TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
=== RUN   TestAccAWSInstance_NetworkInstanceSecurityGroups
=== PAUSE TestAccAWSInstance_NetworkInstanceSecurityGroups
=== RUN   TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups
=== PAUSE TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups
=== RUN   TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs
=== PAUSE TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs
=== RUN   TestAccAWSInstance_tags
=== PAUSE TestAccAWSInstance_tags
=== RUN   TestAccAWSInstance_volumeTags
=== PAUSE TestAccAWSInstance_volumeTags
=== RUN   TestAccAWSInstance_volumeTagsComputed
=== PAUSE TestAccAWSInstance_volumeTagsComputed
=== RUN   TestAccAWSInstance_instanceProfileChange
=== PAUSE TestAccAWSInstance_instanceProfileChange
=== RUN   TestAccAWSInstance_withIamInstanceProfile
=== PAUSE TestAccAWSInstance_withIamInstanceProfile
=== RUN   TestAccAWSInstance_privateIP
=== PAUSE TestAccAWSInstance_privateIP
=== RUN   TestAccAWSInstance_associatePublicIPAndPrivateIP
=== PAUSE TestAccAWSInstance_associatePublicIPAndPrivateIP
=== RUN   TestAccAWSInstance_Empty_PrivateIP
=== PAUSE TestAccAWSInstance_Empty_PrivateIP
=== RUN   TestAccAWSInstance_keyPairCheck
=== PAUSE TestAccAWSInstance_keyPairCheck
=== RUN   TestAccAWSInstance_rootBlockDeviceMismatch
=== PAUSE TestAccAWSInstance_rootBlockDeviceMismatch
=== RUN   TestAccAWSInstance_forceNewAndTagsDrift
=== PAUSE TestAccAWSInstance_forceNewAndTagsDrift
=== RUN   TestAccAWSInstance_changeInstanceType
=== PAUSE TestAccAWSInstance_changeInstanceType
=== RUN   TestAccAWSInstance_EbsRootDevice_basic
=== PAUSE TestAccAWSInstance_EbsRootDevice_basic
=== RUN   TestAccAWSInstance_EbsRootDevice_ModifySize
=== PAUSE TestAccAWSInstance_EbsRootDevice_ModifySize
=== RUN   TestAccAWSInstance_EbsRootDevice_ModifyType
=== PAUSE TestAccAWSInstance_EbsRootDevice_ModifyType
=== RUN   TestAccAWSInstance_EbsRootDevice_ModifyIOPS
=== PAUSE TestAccAWSInstance_EbsRootDevice_ModifyIOPS
=== RUN   TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination
=== PAUSE TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination
=== RUN   TestAccAWSInstance_EbsRootDevice_ModifyAll
=== PAUSE TestAccAWSInstance_EbsRootDevice_ModifyAll
=== RUN   TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize
=== PAUSE TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize
=== RUN   TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination
=== PAUSE TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination
=== RUN   TestAccAWSInstance_EbsRootDevice_MultipleDynamicEBSBlockDevices
=== PAUSE TestAccAWSInstance_EbsRootDevice_MultipleDynamicEBSBlockDevices
=== RUN   TestAccAWSInstance_primaryNetworkInterface
=== PAUSE TestAccAWSInstance_primaryNetworkInterface
=== RUN   TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck
=== PAUSE TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck
=== RUN   TestAccAWSInstance_addSecondaryInterface
=== PAUSE TestAccAWSInstance_addSecondaryInterface
=== RUN   TestAccAWSInstance_addSecurityGroupNetworkInterface
=== PAUSE TestAccAWSInstance_addSecurityGroupNetworkInterface
=== RUN   TestAccAWSInstance_associatePublic_defaultPrivate
=== PAUSE TestAccAWSInstance_associatePublic_defaultPrivate
=== RUN   TestAccAWSInstance_associatePublic_defaultPublic
=== PAUSE TestAccAWSInstance_associatePublic_defaultPublic
=== RUN   TestAccAWSInstance_associatePublic_explicitPublic
=== PAUSE TestAccAWSInstance_associatePublic_explicitPublic
=== RUN   TestAccAWSInstance_associatePublic_explicitPrivate
=== PAUSE TestAccAWSInstance_associatePublic_explicitPrivate
=== RUN   TestAccAWSInstance_associatePublic_overridePublic
=== PAUSE TestAccAWSInstance_associatePublic_overridePublic
=== RUN   TestAccAWSInstance_associatePublic_overridePrivate
=== PAUSE TestAccAWSInstance_associatePublic_overridePrivate
=== RUN   TestAccAWSInstance_getPasswordData_falseToTrue
=== PAUSE TestAccAWSInstance_getPasswordData_falseToTrue
=== RUN   TestAccAWSInstance_getPasswordData_trueToFalse
=== PAUSE TestAccAWSInstance_getPasswordData_trueToFalse
=== RUN   TestAccAWSInstance_CreditSpecification_Empty_NonBurstable
=== PAUSE TestAccAWSInstance_CreditSpecification_Empty_NonBurstable
=== RUN   TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable
=== PAUSE TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable
=== RUN   TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard
=== PAUSE TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard
=== RUN   TestAccAWSInstance_creditSpecification_standardCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecification_standardCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_unlimitedCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecification_unlimitedCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2
=== PAUSE TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2
=== RUN   TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3
=== PAUSE TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3
=== RUN   TestAccAWSInstance_creditSpecification_updateCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecification_updateCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable
=== PAUSE TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable
=== RUN   TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited
=== PAUSE TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited
=== RUN   TestAccAWSInstance_creditSpecificationT3_standardCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecificationT3_standardCpuCredits
=== RUN   TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits
=== RUN   TestAccAWSInstance_creditSpecificationT3_updateCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecificationT3_updateCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint
=== PAUSE TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint
=== RUN   TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint
=== PAUSE TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint
=== RUN   TestAccAWSInstance_disappears
=== PAUSE TestAccAWSInstance_disappears
=== RUN   TestAccAWSInstance_UserData_EmptyStringToUnspecified
=== PAUSE TestAccAWSInstance_UserData_EmptyStringToUnspecified
=== RUN   TestAccAWSInstance_UserData_UnspecifiedToEmptyString
=== PAUSE TestAccAWSInstance_UserData_UnspecifiedToEmptyString
=== RUN   TestAccAWSInstance_hibernation
=== PAUSE TestAccAWSInstance_hibernation
=== RUN   TestAccAWSInstance_metadataOptions
=== PAUSE TestAccAWSInstance_metadataOptions
=== CONT  TestAccAWSInstance_inDefaultVpcBySgName
=== CONT  TestAccAWSInstance_EbsRootDevice_ModifyIOPS
--- FAIL: TestAccAWSInstance_inDefaultVpcBySgName (4.97s)
    testing.go:684: Step 0 error: errors during refresh:
        
        Error: no matching VPC found
        
          on /tmp/tf-test856123282/main.tf line 28:
          (source code not available)
        
        
=== CONT  TestAccAWSInstance_metadataOptions
--- FAIL: TestAccAWSInstance_metadataOptions (10.20s)
    testing.go:684: Step 0 error: errors during apply:
        
        Error: Error launching source instance: VPCResourceNotSpecified: The specified instance type can only be used in a VPC. A subnet ID or network interface ID is required to carry out the request.
        	status code: 400, request id: b90853a9-fe90-4f12-bd86-70ae28d4355f
        
          on /tmp/tf-test370334153/main.tf line 26:
          (source code not available)
        
        
=== CONT  TestAccAWSInstance_hibernation
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyIOPS (133.84s)
=== CONT  TestAccAWSInstance_UserData_UnspecifiedToEmptyString
--- PASS: TestAccAWSInstance_hibernation (198.09s)
=== CONT  TestAccAWSInstance_UserData_EmptyStringToUnspecified
--- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (119.13s)
=== CONT  TestAccAWSInstance_disappears
--- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (106.79s)
=== CONT  TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (193.74s)
=== CONT  TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint
--- PASS: TestAccAWSInstance_disappears (276.66s)
=== CONT  TestAccAWSInstance_creditSpecificationT3_updateCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (153.10s)
=== CONT  TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits
--- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (153.96s)
=== CONT  TestAccAWSInstance_creditSpecificationT3_standardCpuCredits
--- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (142.20s)
=== CONT  TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited
--- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (142.72s)
=== CONT  TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable
--- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (62.57s)
=== CONT  TestAccAWSInstance_creditSpecification_updateCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (133.17s)
=== CONT  TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3
=== CONT  TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2
--- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (133.80s)
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3 (102.45s)
=== CONT  TestAccAWSInstance_creditSpecification_unlimitedCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2 (82.47s)
=== CONT  TestAccAWSInstance_creditSpecification_standardCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (122.23s)
=== CONT  TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (111.13s)
=== CONT  TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable
--- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (81.50s)
=== CONT  TestAccAWSInstance_CreditSpecification_Empty_NonBurstable
--- PASS: TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable (132.43s)
=== CONT  TestAccAWSInstance_getPasswordData_trueToFalse
--- FAIL: TestAccAWSInstance_getPasswordData_trueToFalse (16.44s)
    testing.go:684: Step 0 error: errors during apply:
        
        Error: Error launching source instance: VPCResourceNotSpecified: The specified instance type can only be used in a VPC. A subnet ID or network interface ID is required to carry out the request.
        	status code: 400, request id: cf89f921-9ffa-4d0c-867b-270daec836e8
        
          on /tmp/tf-test906850603/main.tf line 17:
          (source code not available)
        
        
=== CONT  TestAccAWSInstance_getPasswordData_falseToTrue
--- FAIL: TestAccAWSInstance_getPasswordData_falseToTrue (18.15s)
    testing.go:684: Step 0 error: errors during apply:
        
        Error: Error launching source instance: VPCResourceNotSpecified: The specified instance type can only be used in a VPC. A subnet ID or network interface ID is required to carry out the request.
        	status code: 400, request id: d8b722ca-1046-4556-b3d0-49e010236f4b
        
          on /tmp/tf-test167880853/main.tf line 17:
          (source code not available)
        
        
=== CONT  TestAccAWSInstance_associatePublic_overridePrivate
--- PASS: TestAccAWSInstance_associatePublic_overridePrivate (102.88s)
=== CONT  TestAccAWSInstance_associatePublic_overridePublic
--- PASS: TestAccAWSInstance_associatePublic_overridePublic (91.36s)
=== CONT  TestAccAWSInstance_associatePublic_explicitPrivate
--- PASS: TestAccAWSInstance_CreditSpecification_Empty_NonBurstable (314.84s)
=== CONT  TestAccAWSInstance_associatePublic_explicitPublic
--- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (95.10s)
=== CONT  TestAccAWSInstance_associatePublic_defaultPublic
--- FAIL: TestAccAWSInstance_associatePublic_explicitPublic (93.10s)
    testing.go:684: Step 0 error: After applying this step, the plan was not empty:
        
        DIFF:
        
        UPDATE: aws_subnet.test
          arn:                             "arn:aws:ec2:us-east-1:346386234494:subnet/subnet-02780bc326aa719dc" => "arn:aws:ec2:us-east-1:346386234494:subnet/subnet-02780bc326aa719dc"
          assign_ipv6_address_on_creation: "false" => "false"
          availability_zone:               "us-east-1a" => "us-east-1a"
          availability_zone_id:            "use1-az4" => "use1-az4"
          cidr_block:                      "10.1.1.0/24" => "10.1.1.0/24"
          id:                              "subnet-02780bc326aa719dc" => "subnet-02780bc326aa719dc"
          ipv6_cidr_block:                 "" => ""
          ipv6_cidr_block_association_id:  "" => ""
          map_public_ip_on_launch:         "false" => "true"
          outpost_arn:                     "" => ""
          owner_id:                        "346386234494" => "346386234494"
          tags.Name:                       "tf-testacc-instance-kvzl7g0hl17o" => "tf-testacc-instance-kvzl7g0hl17o"
          vpc_id:                          "vpc-01b135f739adcbcc1" => "vpc-01b135f739adcbcc1"
        
        
        
        STATE:
        
        data.aws_ami.amzn-ami-minimal-hvm-ebs:
          ID = ami-0590a878ddb2390a9
          provider = provider.aws
          architecture = x86_64
          arn = arn:aws:ec2:us-east-1::image/ami-0590a878ddb2390a9
          block_device_mappings.# = 1
          block_device_mappings.0.device_name = /dev/xvda
          block_device_mappings.0.ebs.delete_on_termination = true
          block_device_mappings.0.ebs.encrypted = false
          block_device_mappings.0.ebs.iops = 0
          block_device_mappings.0.ebs.snapshot_id = snap-0412773dddd248a02
          block_device_mappings.0.ebs.volume_size = 2
          block_device_mappings.0.ebs.volume_type = standard
          block_device_mappings.0.no_device = 
          block_device_mappings.0.virtual_name = 
          creation_date = 2020-06-16T06:34:11.000Z
          description = Amazon Linux AMI 2018.03.0.20200602.1 x86_64 Minimal HVM ebs
          filter.# = 2
          filter.0.name = name
          filter.0.values.# = 1
          filter.0.values.0 = amzn-ami-minimal-hvm-*
          filter.1.name = root-device-type
          filter.1.values.# = 1
          filter.1.values.0 = ebs
          hypervisor = xen
          image_id = ami-0590a878ddb2390a9
          image_location = amazon/amzn-ami-minimal-hvm-2018.03.0.20200602.1-x86_64-ebs
          image_owner_alias = amazon
          image_type = machine
          most_recent = true
          name = amzn-ami-minimal-hvm-2018.03.0.20200602.1-x86_64-ebs
          owner_id = 137112412989
          owners.# = 1
          owners.0 = amazon
          public = true
          root_device_name = /dev/xvda
          root_device_type = ebs
          root_snapshot_id = snap-0412773dddd248a02
          sriov_net_support = simple
          state = available
          state_reason.code = UNSET
          state_reason.message = UNSET
          virtualization_type = hvm
        data.aws_availability_zones.current:
          ID = 2020-07-14 10:31:44.63694341 +0000 UTC
          provider = provider.aws
          exclude_zone_ids.# = 1
          exclude_zone_ids.0 = usw2-az4
          filter.# = 1
          filter.0.name = opt-in-status
          filter.0.values.# = 1
          filter.0.values.0 = opt-in-not-required
          group_names.# = 1
          group_names.0 = us-east-1
          names.# = 6
          names.0 = us-east-1a
          names.1 = us-east-1b
          names.2 = us-east-1c
          names.3 = us-east-1d
          names.4 = us-east-1e
          names.5 = us-east-1f
          state = available
          zone_ids.# = 6
          zone_ids.0 = use1-az4
          zone_ids.1 = use1-az6
          zone_ids.2 = use1-az1
          zone_ids.3 = use1-az2
          zone_ids.4 = use1-az3
          zone_ids.5 = use1-az5
        aws_instance.test:
          ID = i-0744460dfad4ec32f
          provider = provider.aws
          ami = ami-0590a878ddb2390a9
          arn = arn:aws:ec2:us-east-1:346386234494:instance/i-0744460dfad4ec32f
          associate_public_ip_address = true
          availability_zone = us-east-1a
          cpu_core_count = 1
          cpu_threads_per_core = 1
          credit_specification.# = 1
          credit_specification.0.cpu_credits = standard
          disable_api_termination = false
          ebs_optimized = false
          get_password_data = false
          hibernation = false
          iam_instance_profile = 
          instance_state = running
          instance_type = t2.micro
          ipv6_address_count = 0
          key_name = 
          metadata_options.# = 1
          metadata_options.0.http_endpoint = enabled
          metadata_options.0.http_put_response_hop_limit = 1
          metadata_options.0.http_tokens = optional
          monitoring = false
          outpost_arn = 
          password_data = 
          placement_group = 
          primary_network_interface_id = eni-0d1552ccce0a3d789
          private_dns = ip-10-1-1-217.ec2.internal
          private_ip = 10.1.1.217
          public_dns = 
          public_ip = 107.20.48.207
          root_block_device.# = 1
          root_block_device.0.delete_on_termination = true
          root_block_device.0.device_name = /dev/xvda
          root_block_device.0.encrypted = false
          root_block_device.0.iops = 0
          root_block_device.0.kms_key_id = 
          root_block_device.0.volume_id = vol-0231c391a5acc74b8
          root_block_device.0.volume_size = 2
          root_block_device.0.volume_type = standard
          source_dest_check = true
          subnet_id = subnet-02780bc326aa719dc
          tags.Name = tf-testacc-instance-kvzl7g0hl17o
          tenancy = default
          vpc_security_group_ids.# = 1
          vpc_security_group_ids.0 = sg-071d38b0a878a3e55
        
          Dependencies:
            aws_subnet.test
            data.aws_ami.amzn-ami-minimal-hvm-ebs
        aws_subnet.test:
          ID = subnet-02780bc326aa719dc
          provider = provider.aws
          arn = arn:aws:ec2:us-east-1:346386234494:subnet/subnet-02780bc326aa719dc
          assign_ipv6_address_on_creation = false
          availability_zone = us-east-1a
          availability_zone_id = use1-az4
          cidr_block = 10.1.1.0/24
          ipv6_cidr_block = 
          ipv6_cidr_block_association_id = 
          map_public_ip_on_launch = false
          outpost_arn = 
          owner_id = 346386234494
          tags.Name = tf-testacc-instance-kvzl7g0hl17o
          vpc_id = vpc-01b135f739adcbcc1
        
          Dependencies:
            aws_vpc.test
            data.aws_availability_zones.current
        aws_vpc.test:
          ID = vpc-01b135f739adcbcc1
          provider = provider.aws
          arn = arn:aws:ec2:us-east-1:346386234494:vpc/vpc-01b135f739adcbcc1
          assign_generated_ipv6_cidr_block = false
          cidr_block = 10.1.0.0/16
          default_network_acl_id = acl-0841d7e94584e3da9
          default_route_table_id = rtb-0398daad49e0ae4e0
          default_security_group_id = sg-071d38b0a878a3e55
          dhcp_options_id = dopt-2a21284d
          enable_classiclink = false
          enable_classiclink_dns_support = false
          enable_dns_hostnames = false
          enable_dns_support = true
          instance_tenancy = default
          ipv6_association_id = 
          ipv6_cidr_block = 
          main_route_table_id = rtb-0398daad49e0ae4e0
          owner_id = 346386234494
          tags.Name = tf-testacc-instance-kvzl7g0hl17o
=== CONT  TestAccAWSInstance_associatePublic_defaultPrivate
--- PASS: TestAccAWSInstance_associatePublic_defaultPublic (82.55s)
=== CONT  TestAccAWSInstance_addSecurityGroupNetworkInterface
--- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (92.20s)
=== CONT  TestAccAWSInstance_addSecondaryInterface
--- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (153.80s)
=== CONT  TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck
--- PASS: TestAccAWSInstance_addSecondaryInterface (143.68s)
=== CONT  TestAccAWSInstance_primaryNetworkInterface
--- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (105.34s)
=== CONT  TestAccAWSInstance_EbsRootDevice_MultipleDynamicEBSBlockDevices
--- PASS: TestAccAWSInstance_primaryNetworkInterface (105.20s)
=== CONT  TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination
--- FAIL: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination (105.62s)
    testing.go:684: Step 1 error: Check failed: Check 4/7 error: aws_instance.test: Attribute 'root_block_device.0.delete_on_termination' expected "true", got "false"
=== CONT  TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize
--- FAIL: TestAccAWSInstance_EbsRootDevice_MultipleDynamicEBSBlockDevices (207.72s)
    testing.go:684: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=17) "source_dest_check": (string) (len=4) "true"
        }
        
=== CONT  TestAccAWSInstance_EbsRootDevice_ModifyAll
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize (143.19s)
=== CONT  TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination
--- FAIL: TestAccAWSInstance_EbsRootDevice_ModifyAll (117.49s)
    testing.go:684: Step 1 error: Check failed: Check 4/6 error: aws_instance.test: Attribute 'root_block_device.0.delete_on_termination' expected "true", got "false"
=== CONT  TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
--- FAIL: TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination (126.16s)
    testing.go:684: Step 1 error: Check failed: Check 4/5 error: aws_instance.test: Attribute 'root_block_device.0.delete_on_termination' expected "true", got "false"
=== CONT  TestAccAWSInstance_EbsRootDevice_ModifyType
--- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (125.57s)
=== CONT  TestAccAWSInstance_EbsRootDevice_ModifySize
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyType (146.38s)
=== CONT  TestAccAWSInstance_EbsRootDevice_basic
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifySize (132.43s)
=== CONT  TestAccAWSInstance_changeInstanceType
--- PASS: TestAccAWSInstance_EbsRootDevice_basic (77.08s)
=== CONT  TestAccAWSInstance_forceNewAndTagsDrift
--- PASS: TestAccAWSInstance_changeInstanceType (166.54s)
=== CONT  TestAccAWSInstance_rootBlockDeviceMismatch
=== CONT  TestAccAWSInstance_keyPairCheck
--- SKIP: TestAccAWSInstance_rootBlockDeviceMismatch (1.70s)
    provider_test.go:525: skipping tests; AWS_DEFAULT_REGION (us-east-1) does not equal us-west-2
--- PASS: TestAccAWSInstance_forceNewAndTagsDrift (143.69s)
=== CONT  TestAccAWSInstance_Empty_PrivateIP
--- PASS: TestAccAWSInstance_keyPairCheck (97.47s)
=== CONT  TestAccAWSInstance_associatePublicIPAndPrivateIP
--- PASS: TestAccAWSInstance_Empty_PrivateIP (93.04s)
=== CONT  TestAccAWSInstance_privateIP
--- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (91.24s)
=== CONT  TestAccAWSInstance_withIamInstanceProfile
--- PASS: TestAccAWSInstance_privateIP (91.34s)
=== CONT  TestAccAWSInstance_instanceProfileChange
--- FAIL: TestAccAWSInstance_withIamInstanceProfile (115.72s)
    testing.go:684: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=17) "source_dest_check": (string) (len=4) "true"
        }
        
=== CONT  TestAccAWSInstance_volumeTagsComputed
--- FAIL: TestAccAWSInstance_instanceProfileChange (119.22s)
    testing.go:684: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=17) "source_dest_check": (string) (len=4) "true"
        }
        
=== CONT  TestAccAWSInstance_volumeTags
--- FAIL: TestAccAWSInstance_volumeTagsComputed (10.83s)
    testing.go:684: Step 0 error: errors during apply:
        
        Error: Error launching source instance: VPCResourceNotSpecified: The specified instance type can only be used in a VPC. A subnet ID or network interface ID is required to carry out the request.
        	status code: 400, request id: 4615f5ef-9bf1-4029-8412-68035d8ad2be
        
          on /tmp/tf-test272005481/main.tf line 17:
          (source code not available)
        
        
=== CONT  TestAccAWSInstance_tags
--- FAIL: TestAccAWSInstance_volumeTags (98.62s)
    testing.go:684: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=17) "source_dest_check": (string) (len=4) "true"
        }
        
=== CONT  TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs
--- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (93.73s)
=== CONT  TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups
--- FAIL: TestAccAWSInstance_tags (229.81s)
    testing.go:684: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=17) "source_dest_check": (string) (len=4) "true"
        }
        
=== CONT  TestAccAWSInstance_NetworkInstanceSecurityGroups
--- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (106.92s)
=== CONT  TestAccAWSInstance_blockDevices
--- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (116.05s)
=== CONT  TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError
--- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (20.43s)
=== CONT  TestAccAWSInstance_ipv6_supportAddressCount
--- FAIL: TestAccAWSInstance_blockDevices (167.03s)
    testing.go:684: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=17) "source_dest_check": (string) (len=4) "true"
        }
        
=== CONT  TestAccAWSInstance_placementGroup
--- PASS: TestAccAWSInstance_ipv6_supportAddressCount (103.40s)
=== CONT  TestAccAWSInstance_outpost
--- SKIP: TestAccAWSInstance_outpost (2.63s)
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts Outpost found
=== CONT  TestAccAWSInstance_vpc
--- PASS: TestAccAWSInstance_placementGroup (74.26s)
=== CONT  TestAccAWSInstance_disableApiTermination
--- PASS: TestAccAWSInstance_disableApiTermination (132.65s)
=== CONT  TestAccAWSInstance_sourceDestCheck
--- PASS: TestAccAWSInstance_sourceDestCheck (213.54s)
=== CONT  TestAccAWSInstance_noAMIEphemeralDevices
--- FAIL: TestAccAWSInstance_noAMIEphemeralDevices (85.09s)
    testing.go:684: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=17) "source_dest_check": (string) (len=4) "true"
        }
        
=== CONT  TestAccAWSInstance_rootInstanceStore
--- FAIL: TestAccAWSInstance_rootInstanceStore (103.55s)
    testing.go:684: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=17) "source_dest_check": (string) (len=4) "true"
        }
        
=== CONT  TestAccAWSInstance_EbsBlockDevice_KmsKeyArn
--- PASS: TestAccAWSInstance_EbsBlockDevice_KmsKeyArn (87.36s)
=== CONT  TestAccAWSInstance_GP2WithIopsValue
--- FAIL: TestAccAWSInstance_GP2WithIopsValue (109.48s)
    testing.go:684: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=17) "source_dest_check": (string) (len=4) "true"
        }
        
=== CONT  TestAccAWSInstance_GP2IopsDevice
--- FAIL: TestAccAWSInstance_GP2IopsDevice (85.14s)
    testing.go:684: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=17) "source_dest_check": (string) (len=4) "true"
        }
        
=== CONT  TestAccAWSInstance_userDataBase64
--- PASS: TestAccAWSInstance_userDataBase64 (111.67s)
=== CONT  TestAccAWSInstance_RootBlockDevice_KmsKeyArn
--- PASS: TestAccAWSInstance_RootBlockDevice_KmsKeyArn (86.89s)
=== CONT  TestAccAWSInstance_basic
--- FAIL: TestAccAWSInstance_basic (236.83s)
    testing.go:684: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=17) "source_dest_check": (string) (len=4) "true"
        }
        
=== CONT  TestAccAWSInstance_atLeastOneOtherEbsVolume
--- PASS: TestAccAWSInstance_atLeastOneOtherEbsVolume (170.02s)
=== CONT  TestAccAWSInstance_inEc2Classic
--- PASS: TestAccAWSInstance_inEc2Classic (79.51s)
=== CONT  TestAccAWSInstance_inDefaultVpcBySgId
--- FAIL: TestAccAWSInstance_inDefaultVpcBySgId (4.92s)
    testing.go:684: Step 0 error: errors during refresh:
        
        Error: no matching VPC found
        
          on /tmp/tf-test171636584/main.tf line 28:
          (source code not available)
        
        
--- FAIL: TestAccAWSInstance_vpc (2859.95s)
    testing.go:684: Step 0 error: errors during apply:
        
        Error: Error launching source instance: InsufficientInstanceCapacity: We currently do not have sufficient m1.small capacity in the Availability Zone you requested (us-east-1a). Our system will be working on provisioning additional capacity. You can currently get m1.small capacity by not specifying an Availability Zone in your request or choosing us-east-1b, us-east-1c, us-east-1d.
        	status code: 500, request id: f0149123-20d8-4e6f-9e3e-b5ed23e22298
        
          on /tmp/tf-test674578750/main.tf line 47:
          (source code not available)
        
        
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	6396.222s
FAIL
GNUmakefile:26: recipe for target 'testacc' failed
make: *** [testacc] Error 1

Many of these errors are due to instance creation in EC2-Classic (e.g. source_dest_check import diffs) or assuming a default VPC is present because no subnet_id was specified in configuration. Others can be fixed by dynamically selecting the instance type.
The diff on the aws_subnet.map_public_ip_on_launch attribute in TestAccAWSInstance_associatePublic_explicitPublic may be an eventual consistency or state change issue - I'll investigate.
We have issues to make the tests independent of default VPC/subnets and tidy up EC2-Classic cases:

I don't intend to address the failing test cases as part of this PR as none of them are due to invalid AMI IDs,

Running that test in isolation shows no errors:

$ AWS_DEFAULT_REGION=us-east-1 make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstance_associatePublic_explicitPublic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSInstance_associatePublic_explicitPublic -timeout 120m
=== RUN   TestAccAWSInstance_associatePublic_explicitPublic
=== PAUSE TestAccAWSInstance_associatePublic_explicitPublic
=== CONT  TestAccAWSInstance_associatePublic_explicitPublic
--- PASS: TestAccAWSInstance_associatePublic_explicitPublic (102.60s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	102.646s

ewbankkit · 2020-07-29T17:45:56Z

aws/data_source_aws_instance_test.go

@@ -893,11 +889,13 @@ data "aws_instance" "test" {
 func testAccInstanceDataSourceConfig_metadataOptions(rName string) string {
 	return composeConfig(
 		testAccLatestAmazonLinuxHvmEbsAmiConfig(),
+		testAccAwsInstanceVpcConfig(rName, false),


Add a VPC so that we remove dependence on default VPC and subnets.

ewbankkit · 2020-07-29T17:48:39Z

aws/resource_aws_instance_test.go

@@ -236,52 +236,51 @@ func TestAccAWSInstance_inEc2Classic(t *testing.T) {

 func TestAccAWSInstance_basic(t *testing.T) {


Modify TestAccAWSInstance_basic to test the minimal configuration.
Move the previous test functionality into new test TestAccAWSInstance_atLeastOneOtherEbsVolume.

I like this 👍

ewbankkit · 2020-07-29T17:49:37Z

aws/resource_aws_instance_test.go


 	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:      func() { testAccPreCheck(t) },
 		IDRefreshName: resourceName,
 		Providers:     testAccProviders,
 		CheckDestroy:  testAccCheckInstanceDestroy,
 		Steps: []resource.TestStep{
-			// Create a volume to cover https://github.com/hashicorp/terraform/issues/1249


Additional EBS volume is now created within Terraform configuration.

ewbankkit · 2020-07-29T17:52:02Z

aws/resource_aws_instance_test.go

-					testAccCheckInstanceExists(resourceName, &conf),
-					testAccCheckInstanceDisappears(&conf),
+					testAccCheckInstanceExists(resourceName, &v),
+					testAccCheckResourceDisappears(testAccProvider, resourceAwsInstance(), resourceName),


ewbankkit · 2020-07-29T17:54:26Z

aws/resource_aws_instance_test.go

 }

-func testAccCurrentAvailableAZsNoOptInExcludeConfig(exclude string) string {
+func testAccCurrentAvailableAZsNoOptInExcludeConfig(excludeZoneIds ...string) string {


Similar to testAccAvailableEc2InstanceTypeForRegion().

ewbankkit · 2020-07-30T17:14:14Z

Rebased and resolved merge conflicts.
Re-ran acceptance tests (in us-west-2):

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSInstance_ -timeout 120m
=== RUN   TestAccAWSInstance_inDefaultVpcBySgName
=== PAUSE TestAccAWSInstance_inDefaultVpcBySgName
=== RUN   TestAccAWSInstance_inDefaultVpcBySgId
=== PAUSE TestAccAWSInstance_inDefaultVpcBySgId
=== RUN   TestAccAWSInstance_inEc2Classic
    resource_aws_instance_test.go:210: Not running this test as it overrides the test region
--- SKIP: TestAccAWSInstance_inEc2Classic (0.00s)
=== RUN   TestAccAWSInstance_basic
=== PAUSE TestAccAWSInstance_basic
=== RUN   TestAccAWSInstance_atLeastOneOtherEbsVolume
=== PAUSE TestAccAWSInstance_atLeastOneOtherEbsVolume
=== RUN   TestAccAWSInstance_EbsBlockDevice_KmsKeyArn
=== PAUSE TestAccAWSInstance_EbsBlockDevice_KmsKeyArn
=== RUN   TestAccAWSInstance_EbsBlockDevice_InvalidIopsForVolumeType
=== PAUSE TestAccAWSInstance_EbsBlockDevice_InvalidIopsForVolumeType
=== RUN   TestAccAWSInstance_RootBlockDevice_KmsKeyArn
=== PAUSE TestAccAWSInstance_RootBlockDevice_KmsKeyArn
=== RUN   TestAccAWSInstance_userDataBase64
=== PAUSE TestAccAWSInstance_userDataBase64
=== RUN   TestAccAWSInstance_GP2IopsDevice
=== PAUSE TestAccAWSInstance_GP2IopsDevice
=== RUN   TestAccAWSInstance_GP2WithIopsValue
=== PAUSE TestAccAWSInstance_GP2WithIopsValue
=== RUN   TestAccAWSInstance_blockDevices
=== PAUSE TestAccAWSInstance_blockDevices
=== RUN   TestAccAWSInstance_rootInstanceStore
=== PAUSE TestAccAWSInstance_rootInstanceStore
=== RUN   TestAccAWSInstance_noAMIEphemeralDevices
=== PAUSE TestAccAWSInstance_noAMIEphemeralDevices
=== RUN   TestAccAWSInstance_sourceDestCheck
=== PAUSE TestAccAWSInstance_sourceDestCheck
=== RUN   TestAccAWSInstance_disableApiTermination
=== PAUSE TestAccAWSInstance_disableApiTermination
=== RUN   TestAccAWSInstance_vpc
=== PAUSE TestAccAWSInstance_vpc
=== RUN   TestAccAWSInstance_outpost
=== PAUSE TestAccAWSInstance_outpost
=== RUN   TestAccAWSInstance_placementGroup
=== PAUSE TestAccAWSInstance_placementGroup
=== RUN   TestAccAWSInstance_ipv6_supportAddressCount
=== PAUSE TestAccAWSInstance_ipv6_supportAddressCount
=== RUN   TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError
=== PAUSE TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError
=== RUN   TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
=== PAUSE TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
=== RUN   TestAccAWSInstance_multipleRegions
=== PAUSE TestAccAWSInstance_multipleRegions
=== RUN   TestAccAWSInstance_NetworkInstanceSecurityGroups
=== PAUSE TestAccAWSInstance_NetworkInstanceSecurityGroups
=== RUN   TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups
=== PAUSE TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups
=== RUN   TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs
=== PAUSE TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs
=== RUN   TestAccAWSInstance_tags
=== PAUSE TestAccAWSInstance_tags
=== RUN   TestAccAWSInstance_volumeTags
=== PAUSE TestAccAWSInstance_volumeTags
=== RUN   TestAccAWSInstance_volumeTagsComputed
=== PAUSE TestAccAWSInstance_volumeTagsComputed
=== RUN   TestAccAWSInstance_instanceProfileChange
=== PAUSE TestAccAWSInstance_instanceProfileChange
=== RUN   TestAccAWSInstance_withIamInstanceProfile
=== PAUSE TestAccAWSInstance_withIamInstanceProfile
=== RUN   TestAccAWSInstance_privateIP
=== PAUSE TestAccAWSInstance_privateIP
=== RUN   TestAccAWSInstance_associatePublicIPAndPrivateIP
=== PAUSE TestAccAWSInstance_associatePublicIPAndPrivateIP
=== RUN   TestAccAWSInstance_Empty_PrivateIP
=== PAUSE TestAccAWSInstance_Empty_PrivateIP
=== RUN   TestAccAWSInstance_keyPairCheck
=== PAUSE TestAccAWSInstance_keyPairCheck
=== RUN   TestAccAWSInstance_rootBlockDeviceMismatch
=== PAUSE TestAccAWSInstance_rootBlockDeviceMismatch
=== RUN   TestAccAWSInstance_forceNewAndTagsDrift
=== PAUSE TestAccAWSInstance_forceNewAndTagsDrift
=== RUN   TestAccAWSInstance_changeInstanceType
=== PAUSE TestAccAWSInstance_changeInstanceType
=== RUN   TestAccAWSInstance_EbsRootDevice_basic
=== PAUSE TestAccAWSInstance_EbsRootDevice_basic
=== RUN   TestAccAWSInstance_EbsRootDevice_ModifySize
=== PAUSE TestAccAWSInstance_EbsRootDevice_ModifySize
=== RUN   TestAccAWSInstance_EbsRootDevice_ModifyType
=== PAUSE TestAccAWSInstance_EbsRootDevice_ModifyType
=== RUN   TestAccAWSInstance_EbsRootDevice_ModifyIOPS
=== PAUSE TestAccAWSInstance_EbsRootDevice_ModifyIOPS
=== RUN   TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination
=== PAUSE TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination
=== RUN   TestAccAWSInstance_EbsRootDevice_ModifyAll
=== PAUSE TestAccAWSInstance_EbsRootDevice_ModifyAll
=== RUN   TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize
=== PAUSE TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize
=== RUN   TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination
=== PAUSE TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination
=== RUN   TestAccAWSInstance_EbsRootDevice_MultipleDynamicEBSBlockDevices
=== PAUSE TestAccAWSInstance_EbsRootDevice_MultipleDynamicEBSBlockDevices
=== RUN   TestAccAWSInstance_primaryNetworkInterface
=== PAUSE TestAccAWSInstance_primaryNetworkInterface
=== RUN   TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck
=== PAUSE TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck
=== RUN   TestAccAWSInstance_addSecondaryInterface
=== PAUSE TestAccAWSInstance_addSecondaryInterface
=== RUN   TestAccAWSInstance_addSecurityGroupNetworkInterface
=== PAUSE TestAccAWSInstance_addSecurityGroupNetworkInterface
=== RUN   TestAccAWSInstance_NewNetworkInterface_PublicIPAndSecondaryPrivateIPs
=== PAUSE TestAccAWSInstance_NewNetworkInterface_PublicIPAndSecondaryPrivateIPs
=== RUN   TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPs
=== PAUSE TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPs
=== RUN   TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPsUpdate
=== PAUSE TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPsUpdate
=== RUN   TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPs
=== PAUSE TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPs
=== RUN   TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPsUpdate
=== PAUSE TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPsUpdate
=== RUN   TestAccAWSInstance_associatePublic_defaultPrivate
=== PAUSE TestAccAWSInstance_associatePublic_defaultPrivate
=== RUN   TestAccAWSInstance_associatePublic_defaultPublic
=== PAUSE TestAccAWSInstance_associatePublic_defaultPublic
=== RUN   TestAccAWSInstance_associatePublic_explicitPublic
=== PAUSE TestAccAWSInstance_associatePublic_explicitPublic
=== RUN   TestAccAWSInstance_associatePublic_explicitPrivate
=== PAUSE TestAccAWSInstance_associatePublic_explicitPrivate
=== RUN   TestAccAWSInstance_associatePublic_overridePublic
=== PAUSE TestAccAWSInstance_associatePublic_overridePublic
=== RUN   TestAccAWSInstance_associatePublic_overridePrivate
=== PAUSE TestAccAWSInstance_associatePublic_overridePrivate
=== RUN   TestAccAWSInstance_getPasswordData_falseToTrue
=== PAUSE TestAccAWSInstance_getPasswordData_falseToTrue
=== RUN   TestAccAWSInstance_getPasswordData_trueToFalse
=== PAUSE TestAccAWSInstance_getPasswordData_trueToFalse
=== RUN   TestAccAWSInstance_CreditSpecification_Empty_NonBurstable
=== PAUSE TestAccAWSInstance_CreditSpecification_Empty_NonBurstable
=== RUN   TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable
=== PAUSE TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable
=== RUN   TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard
=== PAUSE TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard
=== RUN   TestAccAWSInstance_creditSpecification_standardCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecification_standardCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_unlimitedCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecification_unlimitedCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2
=== PAUSE TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2
=== RUN   TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3
=== PAUSE TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3
=== RUN   TestAccAWSInstance_creditSpecification_updateCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecification_updateCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable
=== PAUSE TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable
=== RUN   TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited
=== PAUSE TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited
=== RUN   TestAccAWSInstance_creditSpecificationT3_standardCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecificationT3_standardCpuCredits
=== RUN   TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits
=== RUN   TestAccAWSInstance_creditSpecificationT3_updateCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecificationT3_updateCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint
=== PAUSE TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint
=== RUN   TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint
=== PAUSE TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint
=== RUN   TestAccAWSInstance_disappears
=== PAUSE TestAccAWSInstance_disappears
=== RUN   TestAccAWSInstance_UserData_EmptyStringToUnspecified
=== PAUSE TestAccAWSInstance_UserData_EmptyStringToUnspecified
=== RUN   TestAccAWSInstance_UserData_UnspecifiedToEmptyString
=== PAUSE TestAccAWSInstance_UserData_UnspecifiedToEmptyString
=== RUN   TestAccAWSInstance_hibernation
=== PAUSE TestAccAWSInstance_hibernation
=== RUN   TestAccAWSInstance_metadataOptions
=== PAUSE TestAccAWSInstance_metadataOptions
=== CONT  TestAccAWSInstance_inDefaultVpcBySgName
=== CONT  TestAccAWSInstance_EbsRootDevice_ModifyAll
--- PASS: TestAccAWSInstance_inDefaultVpcBySgName (92.11s)
=== CONT  TestAccAWSInstance_metadataOptions
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyAll (134.16s)
=== CONT  TestAccAWSInstance_hibernation
--- PASS: TestAccAWSInstance_metadataOptions (130.14s)
=== CONT  TestAccAWSInstance_UserData_UnspecifiedToEmptyString
--- PASS: TestAccAWSInstance_hibernation (195.72s)
=== CONT  TestAccAWSInstance_UserData_EmptyStringToUnspecified
--- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (110.62s)
=== CONT  TestAccAWSInstance_disappears
--- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (110.42s)
=== CONT  TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint
--- PASS: TestAccAWSInstance_disappears (182.83s)
=== CONT  TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (200.82s)
=== CONT  TestAccAWSInstance_creditSpecificationT3_updateCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (221.84s)
=== CONT  TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits
--- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (128.54s)
=== CONT  TestAccAWSInstance_creditSpecificationT3_standardCpuCredits
--- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (114.84s)
=== CONT  TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited
--- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (143.93s)
=== CONT  TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable
--- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (71.04s)
=== CONT  TestAccAWSInstance_creditSpecification_updateCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (120.82s)
=== CONT  TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3
--- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (140.16s)
=== CONT  TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3 (72.04s)
=== CONT  TestAccAWSInstance_creditSpecification_unlimitedCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2 (101.82s)
=== CONT  TestAccAWSInstance_creditSpecification_standardCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (112.67s)
=== CONT  TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (123.93s)
=== CONT  TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable
--- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (102.82s)
=== CONT  TestAccAWSInstance_CreditSpecification_Empty_NonBurstable
--- PASS: TestAccAWSInstance_CreditSpecification_Empty_NonBurstable (78.70s)
=== CONT  TestAccAWSInstance_getPasswordData_trueToFalse
--- PASS: TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable (124.24s)
=== CONT  TestAccAWSInstance_getPasswordData_falseToTrue
--- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (147.07s)
=== CONT  TestAccAWSInstance_associatePublic_overridePrivate
--- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (179.52s)
=== CONT  TestAccAWSInstance_associatePublic_overridePublic
--- PASS: TestAccAWSInstance_associatePublic_overridePrivate (113.11s)
=== CONT  TestAccAWSInstance_associatePublic_explicitPrivate
--- PASS: TestAccAWSInstance_associatePublic_overridePublic (112.78s)
=== CONT  TestAccAWSInstance_associatePublic_explicitPublic
--- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (103.58s)
=== CONT  TestAccAWSInstance_associatePublic_defaultPublic
--- PASS: TestAccAWSInstance_associatePublic_explicitPublic (102.09s)
=== CONT  TestAccAWSInstance_associatePublic_defaultPrivate
--- PASS: TestAccAWSInstance_associatePublic_defaultPublic (103.27s)
=== CONT  TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPsUpdate
--- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (92.06s)
=== CONT  TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPs
--- PASS: TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPs (71.75s)
=== CONT  TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPsUpdate
--- PASS: TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPsUpdate (120.58s)
=== CONT  TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPs
--- PASS: TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPsUpdate (119.11s)
=== CONT  TestAccAWSInstance_NewNetworkInterface_PublicIPAndSecondaryPrivateIPs
--- PASS: TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPs (82.30s)
=== CONT  TestAccAWSInstance_addSecurityGroupNetworkInterface
--- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (143.36s)
=== CONT  TestAccAWSInstance_addSecondaryInterface
--- PASS: TestAccAWSInstance_NewNetworkInterface_PublicIPAndSecondaryPrivateIPs (226.24s)
=== CONT  TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck
--- PASS: TestAccAWSInstance_addSecondaryInterface (161.88s)
=== CONT  TestAccAWSInstance_primaryNetworkInterface
--- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (108.37s)
=== CONT  TestAccAWSInstance_EbsRootDevice_MultipleDynamicEBSBlockDevices
--- PASS: TestAccAWSInstance_primaryNetworkInterface (97.17s)
=== CONT  TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination (112.15s)
=== CONT  TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleDynamicEBSBlockDevices (210.18s)
=== CONT  TestAccAWSInstance_multipleRegions
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize (132.12s)
=== CONT  TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination (133.01s)
=== CONT  TestAccAWSInstance_EbsRootDevice_ModifyIOPS
--- PASS: TestAccAWSInstance_multipleRegions (245.05s)
=== CONT  TestAccAWSInstance_EbsRootDevice_ModifyType
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyIOPS (131.78s)
=== CONT  TestAccAWSInstance_EbsRootDevice_ModifySize
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyType (130.58s)
=== CONT  TestAccAWSInstance_EbsRootDevice_basic
--- PASS: TestAccAWSInstance_EbsRootDevice_basic (74.62s)
=== CONT  TestAccAWSInstance_changeInstanceType
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifySize (122.16s)
=== CONT  TestAccAWSInstance_forceNewAndTagsDrift
--- PASS: TestAccAWSInstance_changeInstanceType (181.98s)
=== CONT  TestAccAWSInstance_rootBlockDeviceMismatch
--- PASS: TestAccAWSInstance_forceNewAndTagsDrift (151.18s)
=== CONT  TestAccAWSInstance_keyPairCheck
--- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (80.27s)
=== CONT  TestAccAWSInstance_Empty_PrivateIP
--- PASS: TestAccAWSInstance_keyPairCheck (74.76s)
=== CONT  TestAccAWSInstance_associatePublicIPAndPrivateIP
--- PASS: TestAccAWSInstance_Empty_PrivateIP (91.48s)
=== CONT  TestAccAWSInstance_privateIP
--- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (102.52s)
=== CONT  TestAccAWSInstance_withIamInstanceProfile
--- PASS: TestAccAWSInstance_privateIP (91.41s)
=== CONT  TestAccAWSInstance_instanceProfileChange
--- PASS: TestAccAWSInstance_withIamInstanceProfile (128.88s)
=== CONT  TestAccAWSInstance_volumeTagsComputed
--- PASS: TestAccAWSInstance_volumeTagsComputed (125.96s)
=== CONT  TestAccAWSInstance_volumeTags
--- PASS: TestAccAWSInstance_instanceProfileChange (187.44s)
=== CONT  TestAccAWSInstance_tags
--- PASS: TestAccAWSInstance_volumeTags (156.85s)
=== CONT  TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs
--- PASS: TestAccAWSInstance_tags (219.09s)
=== CONT  TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups
--- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (100.18s)
=== CONT  TestAccAWSInstance_NetworkInstanceSecurityGroups
--- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (112.63s)
=== CONT  TestAccAWSInstance_rootInstanceStore
--- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (118.93s)
=== CONT  TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
--- PASS: TestAccAWSInstance_rootInstanceStore (104.24s)
=== CONT  TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError
--- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (20.88s)
=== CONT  TestAccAWSInstance_ipv6_supportAddressCount
--- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (113.57s)
=== CONT  TestAccAWSInstance_placementGroup
--- PASS: TestAccAWSInstance_ipv6_supportAddressCount (102.96s)
=== CONT  TestAccAWSInstance_outpost
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts Outpost found
=== CONT  TestAccAWSInstance_vpc
=== CONT  TestAccAWSInstance_outpost
--- SKIP: TestAccAWSInstance_outpost (1.73s)
--- PASS: TestAccAWSInstance_placementGroup (83.47s)
=== CONT  TestAccAWSInstance_disableApiTermination
--- PASS: TestAccAWSInstance_vpc (110.25s)
=== CONT  TestAccAWSInstance_sourceDestCheck
--- PASS: TestAccAWSInstance_disableApiTermination (135.86s)
=== CONT  TestAccAWSInstance_noAMIEphemeralDevices
--- PASS: TestAccAWSInstance_noAMIEphemeralDevices (99.22s)
=== CONT  TestAccAWSInstance_RootBlockDevice_KmsKeyArn
--- PASS: TestAccAWSInstance_sourceDestCheck (157.65s)
=== CONT  TestAccAWSInstance_blockDevices
--- PASS: TestAccAWSInstance_blockDevices (85.83s)
=== CONT  TestAccAWSInstance_GP2WithIopsValue
--- PASS: TestAccAWSInstance_GP2WithIopsValue (8.27s)
=== CONT  TestAccAWSInstance_GP2IopsDevice
--- PASS: TestAccAWSInstance_RootBlockDevice_KmsKeyArn (124.55s)
=== CONT  TestAccAWSInstance_userDataBase64
--- PASS: TestAccAWSInstance_GP2IopsDevice (95.40s)
=== CONT  TestAccAWSInstance_atLeastOneOtherEbsVolume
--- PASS: TestAccAWSInstance_userDataBase64 (122.07s)
=== CONT  TestAccAWSInstance_EbsBlockDevice_InvalidIopsForVolumeType
--- PASS: TestAccAWSInstance_EbsBlockDevice_InvalidIopsForVolumeType (8.98s)
=== CONT  TestAccAWSInstance_EbsBlockDevice_KmsKeyArn
--- PASS: TestAccAWSInstance_atLeastOneOtherEbsVolume (143.49s)
=== CONT  TestAccAWSInstance_basic
--- PASS: TestAccAWSInstance_EbsBlockDevice_KmsKeyArn (109.85s)
=== CONT  TestAccAWSInstance_inDefaultVpcBySgId
--- PASS: TestAccAWSInstance_inDefaultVpcBySgId (91.98s)
--- PASS: TestAccAWSInstance_basic (127.89s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4996.060s

YakDriver · 2020-08-06T14:34:23Z

These are the failures I'm seeing today on us-west-2. Not sure if these are network-related or not.

--- FAIL: TestAccAWSInstance_addSecondaryInterface (46.81s)
--- FAIL: TestAccAWSInstance_associatePublic_explicitPublic (75.52s)
--- FAIL: TestAccAWSInstance_blockDevices (83.61s)
--- FAIL: TestAccAWSInstance_changeInstanceType (66.77s)
--- FAIL: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3 (112.60s)
--- FAIL: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (413.79s)
--- FAIL: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (25.79s)
--- FAIL: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (1222.66s)
--- FAIL: TestAccAWSInstance_EbsRootDevice_ModifyAll (114.26s)
--- FAIL: TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination (76.46s)
--- FAIL: TestAccAWSInstance_EbsRootDevice_ModifySize (69.77s)
--- FAIL: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination (89.70s)
--- FAIL: TestAccAWSInstance_EbsRootDevice_MultipleDynamicEBSBlockDevices (185.06s)
--- FAIL: TestAccAWSInstance_Empty_PrivateIP (41.72s)
--- FAIL: TestAccAWSInstance_forceNewAndTagsDrift (99.52s)
--- FAIL: TestAccAWSInstance_getPasswordData_falseToTrue (6.38s)
--- FAIL: TestAccAWSInstance_getPasswordData_trueToFalse (11.85s)
--- FAIL: TestAccAWSInstance_GP2IopsDevice (74.43s)
--- FAIL: TestAccAWSInstance_inDefaultVpcBySgId (6.48s)
--- FAIL: TestAccAWSInstance_inDefaultVpcBySgName (10.76s)
--- FAIL: TestAccAWSInstance_instanceProfileChange (137.00s)
--- FAIL: TestAccAWSInstance_keyPairCheck (30.29s)
--- FAIL: TestAccAWSInstance_metadataOptions (28.93s)
--- FAIL: TestAccAWSInstance_NewNetworkInterface_PublicIPAndSecondaryPrivateIPs (306.83s)
--- FAIL: TestAccAWSInstance_noAMIEphemeralDevices (63.00s)
--- FAIL: TestAccAWSInstance_rootInstanceStore (81.86s)
--- FAIL: TestAccAWSInstance_tags (126.26s)
--- FAIL: TestAccAWSInstance_volumeTags (96.95s)
--- FAIL: TestAccAWSInstance_volumeTagsComputed (7.27s)
--- FAIL: TestAccAWSInstance_withIamInstanceProfile (269.10s)

…2Classic'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstance_inEc2Classic' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSInstance_inEc2Classic -timeout 120m === RUN TestAccAWSInstance_inEc2Classic === PAUSE TestAccAWSInstance_inEc2Classic === CONT TestAccAWSInstance_inEc2Classic --- PASS: TestAccAWSInstance_inEc2Classic (89.61s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 89.665s

…lockDevice_KmsKeyArn'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstance_EbsBlockDevice_KmsKeyArn' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSInstance_EbsBlockDevice_KmsKeyArn -timeout 120m === RUN TestAccAWSInstance_EbsBlockDevice_KmsKeyArn === PAUSE TestAccAWSInstance_EbsBlockDevice_KmsKeyArn === CONT TestAccAWSInstance_EbsBlockDevice_KmsKeyArn --- PASS: TestAccAWSInstance_EbsBlockDevice_KmsKeyArn (114.53s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 114.602s

…BlockDevice_KmsKeyArn'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstance_RootBlockDevice_KmsKeyArn' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSInstance_RootBlockDevice_KmsKeyArn -timeout 120m === RUN TestAccAWSInstance_RootBlockDevice_KmsKeyArn === PAUSE TestAccAWSInstance_RootBlockDevice_KmsKeyArn === CONT TestAccAWSInstance_RootBlockDevice_KmsKeyArn --- PASS: TestAccAWSInstance_RootBlockDevice_KmsKeyArn (121.92s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 121.975s

…DataBase64'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstance_userDataBase64' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSInstance_userDataBase64 -timeout 120m === RUN TestAccAWSInstance_userDataBase64 === PAUSE TestAccAWSInstance_userDataBase64 === CONT TestAccAWSInstance_userDataBase64 --- PASS: TestAccAWSInstance_userDataBase64 (136.34s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 136.400s

…opsDevice'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstance_GP2IopsDevice' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSInstance_GP2IopsDevice -timeout 120m === RUN TestAccAWSInstance_GP2IopsDevice === PAUSE TestAccAWSInstance_GP2IopsDevice === CONT TestAccAWSInstance_GP2IopsDevice --- PASS: TestAccAWSInstance_GP2IopsDevice (100.62s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 100.710s

…ithIopsValue'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstance_GP2WithIopsValue' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSInstance_GP2WithIopsValue -timeout 120m === RUN TestAccAWSInstance_GP2WithIopsValue === PAUSE TestAccAWSInstance_GP2WithIopsValue === CONT TestAccAWSInstance_GP2WithIopsValue --- PASS: TestAccAWSInstance_GP2WithIopsValue (121.63s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 121.675s

…kDevices', 'TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize', 'TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstance_blockDevices' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSInstance_blockDevices -timeout 120m === RUN TestAccAWSInstance_blockDevices === PAUSE TestAccAWSInstance_blockDevices === CONT TestAccAWSInstance_blockDevices --- PASS: TestAccAWSInstance_blockDevices (100.71s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 100.772s $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize -timeout 120m === RUN TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize === PAUSE TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize === CONT TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize --- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize (166.25s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 166.294s $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination -timeout 120m === RUN TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination === PAUSE TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination === CONT TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination --- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination (146.25s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 146.295s

…InstanceStore'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstance_rootInstanceStore' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSInstance_rootInstanceStore -timeout 120m === RUN TestAccAWSInstance_rootInstanceStore === PAUSE TestAccAWSInstance_rootInstanceStore === CONT TestAccAWSInstance_rootInstanceStore --- PASS: TestAccAWSInstance_rootInstanceStore (129.72s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 129.765s

…IEphemeralDevices'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstance_noAMIEphemeralDevices' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSInstance_noAMIEphemeralDevices -timeout 120m === RUN TestAccAWSInstance_noAMIEphemeralDevices === PAUSE TestAccAWSInstance_noAMIEphemeralDevices === CONT TestAccAWSInstance_noAMIEphemeralDevices --- PASS: TestAccAWSInstance_noAMIEphemeralDevices (104.58s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 104.674s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstance_tags' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSInstance_tags -timeout 120m === RUN TestAccAWSInstance_tags === PAUSE TestAccAWSInstance_tags === CONT TestAccAWSInstance_tags --- PASS: TestAccAWSInstance_tags (182.94s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 182.992s

…meTags' and 'TestAccAWSInstance_volumeTagsComputed'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstance_volumeTags' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSInstance_volumeTags -timeout 120m === RUN TestAccAWSInstance_volumeTags === PAUSE TestAccAWSInstance_volumeTags === RUN TestAccAWSInstance_volumeTagsComputed === PAUSE TestAccAWSInstance_volumeTagsComputed === CONT TestAccAWSInstance_volumeTags === CONT TestAccAWSInstance_volumeTagsComputed --- PASS: TestAccAWSInstance_volumeTagsComputed (182.98s) --- PASS: TestAccAWSInstance_volumeTags (203.35s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 203.400s

…geInstanceType'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstance_changeInstanceType' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSInstance_changeInstanceType -timeout 120m === RUN TestAccAWSInstance_changeInstanceType === PAUSE TestAccAWSInstance_changeInstanceType === CONT TestAccAWSInstance_changeInstanceType --- PASS: TestAccAWSInstance_changeInstanceType (217.76s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 217.804s

… run in `us-west-2`. $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstance_rootBlockDeviceMismatch' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSInstance_rootBlockDeviceMismatch -timeout 120m === RUN TestAccAWSInstance_rootBlockDeviceMismatch === PAUSE TestAccAWSInstance_rootBlockDeviceMismatch === CONT TestAccAWSInstance_rootBlockDeviceMismatch --- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (105.21s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 105.295s $ AWS_DEFAULT_REGION=us-east-2 make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstance_rootBlockDeviceMismatch' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSInstance_rootBlockDeviceMismatch -timeout 120m === RUN TestAccAWSInstance_rootBlockDeviceMismatch === PAUSE TestAccAWSInstance_rootBlockDeviceMismatch === CONT TestAccAWSInstance_rootBlockDeviceMismatch --- SKIP: TestAccAWSInstance_rootBlockDeviceMismatch (2.42s) provider_test.go:525: skipping tests; AWS_DEFAULT_REGION (us-east-2) does not equal us-west-2 PASS ok github.com/terraform-providers/terraform-provider-aws/aws 2.472s

…nce_atLeastOneOtherEbsVolume'. Add new 'TestAccAWSInstance_basic'. Remove hardcoded AMI ID from 'TestAccAWSInstance_disappears', plus hashicorp#13527. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstance_basic' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSInstance_basic -timeout 120m === RUN TestAccAWSInstance_basic === PAUSE TestAccAWSInstance_basic === CONT TestAccAWSInstance_basic --- PASS: TestAccAWSInstance_basic (131.62s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 131.681s $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstance_disappears' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSInstance_disappears -timeout 120m === RUN TestAccAWSInstance_disappears === PAUSE TestAccAWSInstance_disappears === CONT TestAccAWSInstance_disappears --- PASS: TestAccAWSInstance_disappears (260.98s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 261.031s

…astOneOtherEbsVolume'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstance_atLeastOneOtherEbsVolume' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSInstance_atLeastOneOtherEbsVolume -timeout 120m === RUN TestAccAWSInstance_atLeastOneOtherEbsVolume === PAUSE TestAccAWSInstance_atLeastOneOtherEbsVolume === CONT TestAccAWSInstance_atLeastOneOtherEbsVolume --- PASS: TestAccAWSInstance_atLeastOneOtherEbsVolume (190.19s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 190.234s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstanceDataSource_metadataOptions' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSInstanceDataSource_metadataOptions -timeout 120m === RUN TestAccAWSInstanceDataSource_metadataOptions === PAUSE TestAccAWSInstanceDataSource_metadataOptions === CONT TestAccAWSInstanceDataSource_metadataOptions --- PASS: TestAccAWSInstanceDataSource_metadataOptions (108.64s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 108.691s $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstance_metadataOptions' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSInstance_metadataOptions -timeout 120m === RUN TestAccAWSInstance_metadataOptions === PAUSE TestAccAWSInstance_metadataOptions === CONT TestAccAWSInstance_metadataOptions --- PASS: TestAccAWSInstance_metadataOptions (111.01s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 111.055s $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstance_basic' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSInstance_basic -timeout 120m === RUN TestAccAWSInstance_basic === PAUSE TestAccAWSInstance_basic === CONT TestAccAWSInstance_basic --- PASS: TestAccAWSInstance_basic (75.67s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 75.781s

This reverts commit 9532c8a06c2fc3a1afc017d91de381b9f25feccb.

…Instance_multipleRegions'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstance_multipleRegions' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSInstance_multipleRegions -timeout 120m === RUN TestAccAWSInstance_multipleRegions === PAUSE TestAccAWSInstance_multipleRegions === CONT TestAccAWSInstance_multipleRegions --- PASS: TestAccAWSInstance_multipleRegions (243.89s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 243.949s

ewbankkit · 2020-08-06T17:06:19Z

Rebased and re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSInstance_ -timeout 120m
=== RUN   TestAccAWSInstance_inDefaultVpcBySgName
=== PAUSE TestAccAWSInstance_inDefaultVpcBySgName
=== RUN   TestAccAWSInstance_inDefaultVpcBySgId
=== PAUSE TestAccAWSInstance_inDefaultVpcBySgId
=== RUN   TestAccAWSInstance_basic
=== PAUSE TestAccAWSInstance_basic
=== RUN   TestAccAWSInstance_atLeastOneOtherEbsVolume
=== PAUSE TestAccAWSInstance_atLeastOneOtherEbsVolume
=== RUN   TestAccAWSInstance_EbsBlockDevice_KmsKeyArn
=== PAUSE TestAccAWSInstance_EbsBlockDevice_KmsKeyArn
=== RUN   TestAccAWSInstance_EbsBlockDevice_InvalidIopsForVolumeType
=== PAUSE TestAccAWSInstance_EbsBlockDevice_InvalidIopsForVolumeType
=== RUN   TestAccAWSInstance_RootBlockDevice_KmsKeyArn
=== PAUSE TestAccAWSInstance_RootBlockDevice_KmsKeyArn
=== RUN   TestAccAWSInstance_userDataBase64
=== PAUSE TestAccAWSInstance_userDataBase64
=== RUN   TestAccAWSInstance_GP2IopsDevice
=== PAUSE TestAccAWSInstance_GP2IopsDevice
=== RUN   TestAccAWSInstance_GP2WithIopsValue
=== PAUSE TestAccAWSInstance_GP2WithIopsValue
=== RUN   TestAccAWSInstance_blockDevices
=== PAUSE TestAccAWSInstance_blockDevices
=== RUN   TestAccAWSInstance_rootInstanceStore
=== PAUSE TestAccAWSInstance_rootInstanceStore
=== RUN   TestAccAWSInstance_noAMIEphemeralDevices
=== PAUSE TestAccAWSInstance_noAMIEphemeralDevices
=== RUN   TestAccAWSInstance_sourceDestCheck
=== PAUSE TestAccAWSInstance_sourceDestCheck
=== RUN   TestAccAWSInstance_disableApiTermination
=== PAUSE TestAccAWSInstance_disableApiTermination
=== RUN   TestAccAWSInstance_vpc
=== PAUSE TestAccAWSInstance_vpc
=== RUN   TestAccAWSInstance_outpost
=== PAUSE TestAccAWSInstance_outpost
=== RUN   TestAccAWSInstance_placementGroup
=== PAUSE TestAccAWSInstance_placementGroup
=== RUN   TestAccAWSInstance_ipv6_supportAddressCount
=== PAUSE TestAccAWSInstance_ipv6_supportAddressCount
=== RUN   TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError
=== PAUSE TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError
=== RUN   TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
=== PAUSE TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
=== RUN   TestAccAWSInstance_multipleRegions
=== PAUSE TestAccAWSInstance_multipleRegions
=== RUN   TestAccAWSInstance_NetworkInstanceSecurityGroups
=== PAUSE TestAccAWSInstance_NetworkInstanceSecurityGroups
=== RUN   TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups
=== PAUSE TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups
=== RUN   TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs
=== PAUSE TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs
=== RUN   TestAccAWSInstance_tags
=== PAUSE TestAccAWSInstance_tags
=== RUN   TestAccAWSInstance_volumeTags
=== PAUSE TestAccAWSInstance_volumeTags
=== RUN   TestAccAWSInstance_volumeTagsComputed
=== PAUSE TestAccAWSInstance_volumeTagsComputed
=== RUN   TestAccAWSInstance_instanceProfileChange
=== PAUSE TestAccAWSInstance_instanceProfileChange
=== RUN   TestAccAWSInstance_withIamInstanceProfile
=== PAUSE TestAccAWSInstance_withIamInstanceProfile
=== RUN   TestAccAWSInstance_privateIP
=== PAUSE TestAccAWSInstance_privateIP
=== RUN   TestAccAWSInstance_associatePublicIPAndPrivateIP
=== PAUSE TestAccAWSInstance_associatePublicIPAndPrivateIP
=== RUN   TestAccAWSInstance_Empty_PrivateIP
=== PAUSE TestAccAWSInstance_Empty_PrivateIP
=== RUN   TestAccAWSInstance_keyPairCheck
=== PAUSE TestAccAWSInstance_keyPairCheck
=== RUN   TestAccAWSInstance_rootBlockDeviceMismatch
=== PAUSE TestAccAWSInstance_rootBlockDeviceMismatch
=== RUN   TestAccAWSInstance_forceNewAndTagsDrift
=== PAUSE TestAccAWSInstance_forceNewAndTagsDrift
=== RUN   TestAccAWSInstance_changeInstanceType
=== PAUSE TestAccAWSInstance_changeInstanceType
=== RUN   TestAccAWSInstance_EbsRootDevice_basic
=== PAUSE TestAccAWSInstance_EbsRootDevice_basic
=== RUN   TestAccAWSInstance_EbsRootDevice_ModifySize
=== PAUSE TestAccAWSInstance_EbsRootDevice_ModifySize
=== RUN   TestAccAWSInstance_EbsRootDevice_ModifyType
=== PAUSE TestAccAWSInstance_EbsRootDevice_ModifyType
=== RUN   TestAccAWSInstance_EbsRootDevice_ModifyIOPS
=== PAUSE TestAccAWSInstance_EbsRootDevice_ModifyIOPS
=== RUN   TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination
=== PAUSE TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination
=== RUN   TestAccAWSInstance_EbsRootDevice_ModifyAll
=== PAUSE TestAccAWSInstance_EbsRootDevice_ModifyAll
=== RUN   TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize
=== PAUSE TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize
=== RUN   TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination
=== PAUSE TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination
=== RUN   TestAccAWSInstance_EbsRootDevice_MultipleDynamicEBSBlockDevices
=== PAUSE TestAccAWSInstance_EbsRootDevice_MultipleDynamicEBSBlockDevices
=== RUN   TestAccAWSInstance_primaryNetworkInterface
=== PAUSE TestAccAWSInstance_primaryNetworkInterface
=== RUN   TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck
=== PAUSE TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck
=== RUN   TestAccAWSInstance_addSecondaryInterface
=== PAUSE TestAccAWSInstance_addSecondaryInterface
=== RUN   TestAccAWSInstance_addSecurityGroupNetworkInterface
=== PAUSE TestAccAWSInstance_addSecurityGroupNetworkInterface
=== RUN   TestAccAWSInstance_NewNetworkInterface_PublicIPAndSecondaryPrivateIPs
=== PAUSE TestAccAWSInstance_NewNetworkInterface_PublicIPAndSecondaryPrivateIPs
=== RUN   TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPs
=== PAUSE TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPs
=== RUN   TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPsUpdate
=== PAUSE TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPsUpdate
=== RUN   TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPs
=== PAUSE TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPs
=== RUN   TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPsUpdate
=== PAUSE TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPsUpdate
=== RUN   TestAccAWSInstance_associatePublic_defaultPrivate
=== PAUSE TestAccAWSInstance_associatePublic_defaultPrivate
=== RUN   TestAccAWSInstance_associatePublic_defaultPublic
=== PAUSE TestAccAWSInstance_associatePublic_defaultPublic
=== RUN   TestAccAWSInstance_associatePublic_explicitPublic
=== PAUSE TestAccAWSInstance_associatePublic_explicitPublic
=== RUN   TestAccAWSInstance_associatePublic_explicitPrivate
=== PAUSE TestAccAWSInstance_associatePublic_explicitPrivate
=== RUN   TestAccAWSInstance_associatePublic_overridePublic
=== PAUSE TestAccAWSInstance_associatePublic_overridePublic
=== RUN   TestAccAWSInstance_associatePublic_overridePrivate
=== PAUSE TestAccAWSInstance_associatePublic_overridePrivate
=== RUN   TestAccAWSInstance_getPasswordData_falseToTrue
=== PAUSE TestAccAWSInstance_getPasswordData_falseToTrue
=== RUN   TestAccAWSInstance_getPasswordData_trueToFalse
=== PAUSE TestAccAWSInstance_getPasswordData_trueToFalse
=== RUN   TestAccAWSInstance_CreditSpecification_Empty_NonBurstable
=== PAUSE TestAccAWSInstance_CreditSpecification_Empty_NonBurstable
=== RUN   TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable
=== PAUSE TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable
=== RUN   TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard
=== PAUSE TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard
=== RUN   TestAccAWSInstance_creditSpecification_standardCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecification_standardCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_unlimitedCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecification_unlimitedCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2
=== PAUSE TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2
=== RUN   TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3
=== PAUSE TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3
=== RUN   TestAccAWSInstance_creditSpecification_updateCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecification_updateCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable
=== PAUSE TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable
=== RUN   TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited
=== PAUSE TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited
=== RUN   TestAccAWSInstance_creditSpecificationT3_standardCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecificationT3_standardCpuCredits
=== RUN   TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits
=== RUN   TestAccAWSInstance_creditSpecificationT3_updateCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecificationT3_updateCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint
=== PAUSE TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint
=== RUN   TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint
=== PAUSE TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint
=== RUN   TestAccAWSInstance_disappears
=== PAUSE TestAccAWSInstance_disappears
=== RUN   TestAccAWSInstance_UserData_EmptyStringToUnspecified
=== PAUSE TestAccAWSInstance_UserData_EmptyStringToUnspecified
=== RUN   TestAccAWSInstance_UserData_UnspecifiedToEmptyString
=== PAUSE TestAccAWSInstance_UserData_UnspecifiedToEmptyString
=== RUN   TestAccAWSInstance_hibernation
=== PAUSE TestAccAWSInstance_hibernation
=== RUN   TestAccAWSInstance_metadataOptions
=== PAUSE TestAccAWSInstance_metadataOptions
=== CONT  TestAccAWSInstance_inDefaultVpcBySgName
=== CONT  TestAccAWSInstance_EbsRootDevice_ModifyAll
--- PASS: TestAccAWSInstance_inDefaultVpcBySgName (105.31s)
=== CONT  TestAccAWSInstance_metadataOptions
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyAll (146.79s)
=== CONT  TestAccAWSInstance_hibernation
--- PASS: TestAccAWSInstance_metadataOptions (125.75s)
=== CONT  TestAccAWSInstance_UserData_UnspecifiedToEmptyString
--- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (115.90s)
=== CONT  TestAccAWSInstance_UserData_EmptyStringToUnspecified
--- PASS: TestAccAWSInstance_hibernation (220.16s)
=== CONT  TestAccAWSInstance_disappears
--- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (124.81s)
=== CONT  TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint
--- PASS: TestAccAWSInstance_disappears (186.04s)
=== CONT  TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (196.03s)
=== CONT  TestAccAWSInstance_creditSpecificationT3_updateCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (196.48s)
=== CONT  TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits
--- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (167.46s)
=== CONT  TestAccAWSInstance_creditSpecificationT3_standardCpuCredits
--- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (159.30s)
=== CONT  TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited
--- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (149.88s)
=== CONT  TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable
--- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (106.66s)
=== CONT  TestAccAWSInstance_creditSpecification_updateCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (126.48s)
=== CONT  TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3
--- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (154.75s)
=== CONT  TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3 (75.18s)
=== CONT  TestAccAWSInstance_creditSpecification_unlimitedCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2 (105.44s)
=== CONT  TestAccAWSInstance_creditSpecification_standardCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (129.97s)
=== CONT  TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (138.78s)
=== CONT  TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable
--- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (105.00s)
=== CONT  TestAccAWSInstance_CreditSpecification_Empty_NonBurstable
--- PASS: TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable (129.82s)
=== CONT  TestAccAWSInstance_getPasswordData_trueToFalse
--- PASS: TestAccAWSInstance_CreditSpecification_Empty_NonBurstable (128.18s)
=== CONT  TestAccAWSInstance_getPasswordData_falseToTrue
--- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (142.06s)
=== CONT  TestAccAWSInstance_associatePublic_overridePrivate
--- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (194.23s)
=== CONT  TestAccAWSInstance_associatePublic_overridePublic
=== CONT  TestAccAWSInstance_associatePublic_overridePrivate
    testing.go:684: Step 0 error: Check failed: Check 2/3 error: aws_instance.test: Attribute 'associate_public_ip_address' expected "false", got "true"
--- FAIL: TestAccAWSInstance_associatePublic_overridePrivate (91.28s)
=== CONT  TestAccAWSInstance_associatePublic_explicitPrivate
    testing.go:684: Step 0 error: Check failed: Check 2/3 error: aws_instance.test: Attribute 'associate_public_ip_address' expected "false", got "true"
--- PASS: TestAccAWSInstance_associatePublic_overridePublic (95.03s)
=== CONT  TestAccAWSInstance_associatePublic_explicitPublic
--- FAIL: TestAccAWSInstance_associatePublic_explicitPrivate (81.43s)
=== CONT  TestAccAWSInstance_associatePublic_defaultPublic
--- PASS: TestAccAWSInstance_associatePublic_explicitPublic (96.23s)
=== CONT  TestAccAWSInstance_associatePublic_defaultPrivate
--- PASS: TestAccAWSInstance_associatePublic_defaultPublic (96.16s)
=== CONT  TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPsUpdate
--- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (116.56s)
=== CONT  TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPs
--- PASS: TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPsUpdate (180.17s)
=== CONT  TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPsUpdate
--- PASS: TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPs (116.74s)
=== CONT  TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPs
--- PASS: TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPs (96.21s)
=== CONT  TestAccAWSInstance_NewNetworkInterface_PublicIPAndSecondaryPrivateIPs
--- PASS: TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPsUpdate (158.06s)
=== CONT  TestAccAWSInstance_addSecurityGroupNetworkInterface
--- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (158.18s)
=== CONT  TestAccAWSInstance_addSecondaryInterface
--- PASS: TestAccAWSInstance_NewNetworkInterface_PublicIPAndSecondaryPrivateIPs (231.31s)
=== CONT  TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck
--- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (101.24s)
=== CONT  TestAccAWSInstance_primaryNetworkInterface
--- PASS: TestAccAWSInstance_addSecondaryInterface (156.29s)
=== CONT  TestAccAWSInstance_EbsRootDevice_MultipleDynamicEBSBlockDevices
--- PASS: TestAccAWSInstance_primaryNetworkInterface (113.49s)
=== CONT  TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination (115.88s)
=== CONT  TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleDynamicEBSBlockDevices (213.06s)
=== CONT  TestAccAWSInstance_multipleRegions
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize (148.32s)
=== CONT  TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination
--- PASS: TestAccAWSInstance_multipleRegions (149.03s)
=== CONT  TestAccAWSInstance_EbsRootDevice_ModifyIOPS
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination (126.44s)
=== CONT  TestAccAWSInstance_EbsRootDevice_ModifyType
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyIOPS (136.26s)
=== CONT  TestAccAWSInstance_EbsRootDevice_ModifySize
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyType (145.99s)
=== CONT  TestAccAWSInstance_EbsRootDevice_basic
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifySize (148.23s)
=== CONT  TestAccAWSInstance_changeInstanceType
--- PASS: TestAccAWSInstance_EbsRootDevice_basic (91.18s)
=== CONT  TestAccAWSInstance_forceNewAndTagsDrift
--- PASS: TestAccAWSInstance_changeInstanceType (176.38s)
=== CONT  TestAccAWSInstance_rootBlockDeviceMismatch
--- PASS: TestAccAWSInstance_forceNewAndTagsDrift (153.62s)
=== CONT  TestAccAWSInstance_keyPairCheck
--- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (93.00s)
=== CONT  TestAccAWSInstance_Empty_PrivateIP
--- PASS: TestAccAWSInstance_keyPairCheck (77.69s)
=== CONT  TestAccAWSInstance_associatePublicIPAndPrivateIP
--- PASS: TestAccAWSInstance_Empty_PrivateIP (95.77s)
=== CONT  TestAccAWSInstance_privateIP
--- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (95.74s)
=== CONT  TestAccAWSInstance_withIamInstanceProfile
--- PASS: TestAccAWSInstance_privateIP (106.02s)
=== CONT  TestAccAWSInstance_instanceProfileChange
--- PASS: TestAccAWSInstance_withIamInstanceProfile (128.88s)
=== CONT  TestAccAWSInstance_volumeTagsComputed
--- PASS: TestAccAWSInstance_volumeTagsComputed (137.56s)
=== CONT  TestAccAWSInstance_volumeTags
--- PASS: TestAccAWSInstance_instanceProfileChange (212.23s)
=== CONT  TestAccAWSInstance_tags
--- PASS: TestAccAWSInstance_volumeTags (154.15s)
=== CONT  TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs
--- PASS: TestAccAWSInstance_tags (139.14s)
=== CONT  TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups
--- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (112.13s)
=== CONT  TestAccAWSInstance_NetworkInstanceSecurityGroups
--- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (123.87s)
=== CONT  TestAccAWSInstance_rootInstanceStore
--- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (111.46s)
=== CONT  TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
--- PASS: TestAccAWSInstance_rootInstanceStore (106.72s)
=== CONT  TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError
--- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (22.36s)
=== CONT  TestAccAWSInstance_ipv6_supportAddressCount
--- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (95.96s)
=== CONT  TestAccAWSInstance_placementGroup
--- PASS: TestAccAWSInstance_ipv6_supportAddressCount (128.02s)
=== CONT  TestAccAWSInstance_outpost
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts Outpost found
--- SKIP: TestAccAWSInstance_outpost (1.68s)
=== CONT  TestAccAWSInstance_vpc
--- PASS: TestAccAWSInstance_placementGroup (87.11s)
=== CONT  TestAccAWSInstance_disableApiTermination
--- PASS: TestAccAWSInstance_vpc (114.34s)
=== CONT  TestAccAWSInstance_sourceDestCheck
--- PASS: TestAccAWSInstance_disableApiTermination (160.66s)
=== CONT  TestAccAWSInstance_noAMIEphemeralDevices
--- PASS: TestAccAWSInstance_noAMIEphemeralDevices (92.29s)
=== CONT  TestAccAWSInstance_RootBlockDevice_KmsKeyArn
--- PASS: TestAccAWSInstance_sourceDestCheck (165.97s)
=== CONT  TestAccAWSInstance_blockDevices
--- PASS: TestAccAWSInstance_blockDevices (88.03s)
=== CONT  TestAccAWSInstance_GP2WithIopsValue
--- PASS: TestAccAWSInstance_GP2WithIopsValue (10.35s)
=== CONT  TestAccAWSInstance_GP2IopsDevice
--- PASS: TestAccAWSInstance_RootBlockDevice_KmsKeyArn (130.92s)
=== CONT  TestAccAWSInstance_userDataBase64
--- PASS: TestAccAWSInstance_GP2IopsDevice (88.41s)
=== CONT  TestAccAWSInstance_atLeastOneOtherEbsVolume
--- PASS: TestAccAWSInstance_userDataBase64 (124.09s)
=== CONT  TestAccAWSInstance_EbsBlockDevice_InvalidIopsForVolumeType
--- PASS: TestAccAWSInstance_EbsBlockDevice_InvalidIopsForVolumeType (10.29s)
=== CONT  TestAccAWSInstance_EbsBlockDevice_KmsKeyArn
--- PASS: TestAccAWSInstance_atLeastOneOtherEbsVolume (158.80s)
=== CONT  TestAccAWSInstance_basic
--- PASS: TestAccAWSInstance_EbsBlockDevice_KmsKeyArn (103.02s)
=== CONT  TestAccAWSInstance_inDefaultVpcBySgId
--- PASS: TestAccAWSInstance_basic (77.94s)
--- PASS: TestAccAWSInstance_inDefaultVpcBySgId (85.12s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	5194.118s
FAIL
GNUmakefile:26: recipe for target 'testacc' failed
make: *** [testacc] Error 1

ewbankkit · 2020-08-06T17:13:48Z

Investigating the failing cases...
Hmm, failing when running independently:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstance_associatePublic_explicitPrivate'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSInstance_associatePublic_explicitPrivate -timeout 120m
=== RUN   TestAccAWSInstance_associatePublic_explicitPrivate
=== PAUSE TestAccAWSInstance_associatePublic_explicitPrivate
=== CONT  TestAccAWSInstance_associatePublic_explicitPrivate
    testing.go:684: Step 0 error: Check failed: Check 2/3 error: aws_instance.test: Attribute 'associate_public_ip_address' expected "false", got "true"
--- FAIL: TestAccAWSInstance_associatePublic_explicitPrivate (81.42s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	81.470s
FAIL
GNUmakefile:26: recipe for target 'testacc' failed
make: *** [testacc] Error 1
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInstance_associatePublic_overridePrivate'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSInstance_associatePublic_overridePrivate -timeout 120m
=== RUN   TestAccAWSInstance_associatePublic_overridePrivate
=== PAUSE TestAccAWSInstance_associatePublic_overridePrivate
=== CONT  TestAccAWSInstance_associatePublic_overridePrivate
    testing.go:684: Step 0 error: Check failed: Check 2/3 error: aws_instance.test: Attribute 'associate_public_ip_address' expected "false", got "true"
--- FAIL: TestAccAWSInstance_associatePublic_overridePrivate (82.56s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	82.618s
FAIL
GNUmakefile:26: recipe for target 'testacc' failed
make: *** [testacc] Error 1

The EC2 API calls look correct:

{
    "eventVersion": "1.05",
    "eventTime": "2020-08-06T18:10:07Z",
    "eventSource": "ec2.amazonaws.com",
    "eventName": "RunInstances",
    "awsRegion": "us-west-2",
    "userAgent": "aws-sdk-go/1.32.12 (go1.14.6; linux; amd64) APN/1.0 HashiCorp/1.0 Terraform/0.12.26 (+https://www.terraform.io)",
    "requestParameters": {
        "instancesSet": {
            "items": [
                {
                    "imageId": "ami-060fda6c514402640",
                    "minCount": 1,
                    "maxCount": 1
                }
            ]
        },
        "instanceType": "t2.micro",
        "blockDeviceMapping": {},
        "monitoring": {
            "enabled": false
        },
        "disableApiTermination": false,
        "clientToken": "4514C548-8606-44FE-BB12-9455D4BDB04A",
        "networkInterfaceSet": {
            "items": [
                {
                    "deviceIndex": 0,
                    "subnetId": "subnet-02e8a7938f433e176",
                    "associatePublicIpAddress": false
                }
            ]
        },
        "iamInstanceProfile": {},
        "ebsOptimized": false,
        "tagSpecificationSet": {
            "items": [
                {
                    "resourceType": "instance",
                    "tags": [
                        {
                            "key": "Name",
                            "value": "test-ec2-instance-public-ip"
                        }
                    ]
                }
            ]
        },
        "hibernationOptions": {
            "configured": false
        }
    },
    "responseElements": {
        "requestId": "0ea0542e-e0ea-4ed9-8696-e1ec15b5796f",
        "reservationId": "r-04c8422f890668f1f",
        "groupSet": {},
        "instancesSet": {
            "items": [
                {
                    "instanceId": "i-02107eda837a9bea7",
                    "imageId": "ami-060fda6c514402640",
                    "instanceState": {
                        "code": 0,
                        "name": "pending"
                    },
                    "privateDnsName": "ip-10-1-1-166.us-west-2.compute.internal",
                    "amiLaunchIndex": 0,
                    "productCodes": {},
                    "instanceType": "t2.micro",
                    "launchTime": 1596737407000,
                    "placement": {
                        "availabilityZone": "us-west-2a",
                        "tenancy": "default"
                    },
                    "monitoring": {
                        "state": "disabled"
                    },
                    "subnetId": "subnet-02e8a7938f433e176",
                    "vpcId": "vpc-0b0c6d93d05f4da0b",
                    "privateIpAddress": "10.1.1.166",
                    "stateReason": {
                        "code": "pending",
                        "message": "pending"
                    },
                    "architecture": "x86_64",
                    "rootDeviceType": "ebs",
                    "rootDeviceName": "/dev/xvda",
                    "blockDeviceMapping": {},
                    "virtualizationType": "hvm",
                    "hypervisor": "xen",
                    "tagSet": {
                        "items": [
                            {
                                "key": "Name",
                                "value": "test-ec2-instance-public-ip"
                            }
                        ]
                    },
                    "clientToken": "4514C548-8606-44FE-BB12-9455D4BDB04A",
                    "groupSet": {
                        "items": [
                            {
                                "groupId": "sg-03c8d5976f382d963",
                                "groupName": "default"
                            }
                        ]
                    },
                    "sourceDestCheck": true,
                    "networkInterfaceSet": {
                        "items": [
                            {
                                "networkInterfaceId": "eni-0e6a9531930c4f4e5",
                                "subnetId": "subnet-02e8a7938f433e176",
                                "vpcId": "vpc-0b0c6d93d05f4da0b",
                                "status": "in-use",
                                "macAddress": "02:5b:80:8e:3e:b7",
                                "privateIpAddress": "10.1.1.166",
                                "sourceDestCheck": true,
                                "interfaceType": "interface",
                                "groupSet": {
                                    "items": [
                                        {
                                            "groupId": "sg-03c8d5976f382d963",
                                            "groupName": "default"
                                        }
                                    ]
                                },
                                "attachment": {
                                    "attachmentId": "eni-attach-00517af03b72edac6",
                                    "deviceIndex": 0,
                                    "status": "attaching",
                                    "attachTime": 1596737407000,
                                    "deleteOnTermination": true
                                },
                                "privateIpAddressesSet": {
                                    "item": [
                                        {
                                            "privateIpAddress": "10.1.1.166",
                                            "primary": true
                                        }
                                    ]
                                },
                                "ipv6AddressesSet": {},
                                "tagSet": {}
                            }
                        ]
                    },
                    "ebsOptimized": false,
                    "cpuOptions": {
                        "coreCount": 1,
                        "threadsPerCore": 1
                    },
                    "capacityReservationSpecification": {
                        "capacityReservationPreference": "open"
                    },
                    "hibernationOptions": {
                        "configured": false
                    },
                    "enclaveOptions": {
                        "enabled": false
                    },
                    "metadataOptions": {
                        "state": "pending",
                        "httpTokens": "optional",
                        "httpPutResponseHopLimit": 1,
                        "httpEndpoint": "enabled"
                    }
                }
            ]
        }
    },
    "requestID": "0ea0542e-e0ea-4ed9-8696-e1ec15b5796f",
    "eventID": "bf053c3a-d89c-457d-b8e2-b40e781840e7",
    "eventType": "AwsApiCall",
    "recipientAccountId": "346386234494"
}

but the instance still ends up with a public IP address when the state becomes running.
There are similar issues open:

YakDriver · 2020-08-06T18:43:04Z

All the tests pass except one, TestAccAWSInstance_vpc, which normally fails.

--- FAIL: TestAccAWSInstance_vpc (450.13s)

--- PASS: TestAccAWSInstance_addSecondaryInterface (179.57s)
--- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (185.77s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (114.56s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPublic (105.26s)
--- +PASS: TestAccAWSInstance_associatePublic_explicitPrivate (105.12s)
--- PASS: TestAccAWSInstance_associatePublic_explicitPublic (150.04s)
--- +PASS: TestAccAWSInstance_associatePublic_overridePrivate (114.47s)
--- PASS: TestAccAWSInstance_associatePublic_overridePublic (115.79s)
--- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (112.71s)
--- PASS: TestAccAWSInstance_atLeastOneOtherEbsVolume (197.74s)
--- PASS: TestAccAWSInstance_basic (82.09s)
--- PASS: TestAccAWSInstance_blockDevices (100.41s)
--- PASS: TestAccAWSInstance_changeInstanceType (200.58s)
--- PASS: TestAccAWSInstance_CreditSpecification_Empty_NonBurstable (121.35s)
--- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (128.81s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (136.22s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (213.32s)
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2 (98.89s)
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3 (122.73s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (135.79s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (204.00s)
--- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (110.14s)
--- PASS: TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable (116.06s)
--- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (170.12s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (125.70s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (126.69s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (110.30s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (168.39s)
--- PASS: TestAccAWSInstance_disableApiTermination (170.78s)
--- PASS: TestAccAWSInstance_disappears (187.48s)
--- PASS: TestAccAWSInstance_EbsBlockDevice_InvalidIopsForVolumeType (10.54s)
--- PASS: TestAccAWSInstance_EbsBlockDevice_KmsKeyArn (105.00s)
--- PASS: TestAccAWSInstance_EbsRootDevice_basic (186.64s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyAll (151.03s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination (119.73s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyIOPS (149.07s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifySize (127.75s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyType (129.25s)
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination (129.55s)
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize (140.09s)
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleDynamicEBSBlockDevices (208.12s)
--- PASS: TestAccAWSInstance_Empty_PrivateIP (112.60s)
--- PASS: TestAccAWSInstance_forceNewAndTagsDrift (196.08s)
--- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (159.06s)
--- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (190.63s)
--- PASS: TestAccAWSInstance_GP2IopsDevice (100.51s)
--- PASS: TestAccAWSInstance_GP2WithIopsValue (10.14s)
--- PASS: TestAccAWSInstance_hibernation (224.25s)
--- PASS: TestAccAWSInstance_inDefaultVpcBySgId (98.13s)
--- PASS: TestAccAWSInstance_inDefaultVpcBySgName (104.22s)
--- PASS: TestAccAWSInstance_inEc2Classic (189.92s)
--- PASS: TestAccAWSInstance_instanceProfileChange (209.26s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCount (101.63s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (174.78s)
--- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (25.09s)
--- PASS: TestAccAWSInstance_keyPairCheck (79.26s)
--- PASS: TestAccAWSInstance_metadataOptions (166.80s)
--- +PASS: TestAccAWSInstance_multipleRegions (243.44s)
--- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (128.43s)
--- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (125.80s)
--- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (115.36s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPs (112.45s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPsUpdate (161.41s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPs (151.84s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPsUpdate (154.52s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_PublicIPAndSecondaryPrivateIPs (164.03s)
--- PASS: TestAccAWSInstance_noAMIEphemeralDevices (93.32s)
--- PASS: TestAccAWSInstance_placementGroup (90.34s)
--- PASS: TestAccAWSInstance_primaryNetworkInterface (125.73s)
--- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (110.37s)
--- PASS: TestAccAWSInstance_privateIP (99.27s)
--- PASS: TestAccAWSInstance_RootBlockDevice_KmsKeyArn (125.31s)
--- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (98.35s)
--- PASS: TestAccAWSInstance_rootInstanceStore (97.30s)
--- PASS: TestAccAWSInstance_sourceDestCheck (173.27s)
--- PASS: TestAccAWSInstance_tags (132.42s)
--- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (123.28s)
--- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (132.61s)
--- PASS: TestAccAWSInstance_userDataBase64 (161.81s)
--- PASS: TestAccAWSInstance_volumeTags (159.18s)
--- PASS: TestAccAWSInstance_volumeTagsComputed (132.28s)
--- PASS: TestAccAWSInstance_withIamInstanceProfile (124.13s)
--- SKIP: TestAccAWSInstance_outpost (2.02s)

+ Initially failed but succeeded after re-running.

YakDriver · 2020-08-06T18:46:46Z

@ewbankkit Thanks for all your work (and patience) on this!

ghost · 2020-08-07T23:29:35Z

This has been released in version 3.1.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2020-09-06T17:10:43Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

ewbankkit requested a review from a team July 13, 2020 14:20

ewbankkit assigned YakDriver Jul 14, 2020

ewbankkit changed the title ~~[WIP] r/aws_instance: Remove hardcoded AMI IDs from acceptance tests~~ r/aws_instance: Remove hardcoded AMI IDs from acceptance tests Jul 14, 2020

anGie44 force-pushed the master branch from 54db70d to 48ba2f7 Compare July 21, 2020 18:26

breathingdust mentioned this pull request Jul 23, 2020

awsproviderlint: New Check: Prefer aws_ami data source instead of hardcoded Amazon Machine Image identifiers #12994

Closed

17 tasks

ewbankkit force-pushed the td-aws_instance-resource-remove-hardcoded-ami branch from f9d731b to 806c37b Compare July 24, 2020 21:04

ewbankkit mentioned this pull request Jul 27, 2020

Add and use 'testAccAvailableEc2InstanceTypeForAvailabilityZone' config generator #13091

Merged

ewbankkit force-pushed the td-aws_instance-resource-remove-hardcoded-ami branch from 806c37b to 8d62f29 Compare July 28, 2020 20:57

ewbankkit mentioned this pull request Jul 28, 2020

Acceptance tests: Check for default subnets when no subnet_id specified #13361

Closed

ewbankkit commented Jul 29, 2020

View reviewed changes

ewbankkit force-pushed the td-aws_instance-resource-remove-hardcoded-ami branch from 108911f to c96ff6b Compare July 30, 2020 13:36

ewbankkit added 3 commits August 6, 2020 11:15

ewbankkit added 17 commits August 6, 2020 11:15

r/aws_instance: Delete 'TestAccAWSInstance_multipleRegions'.

1278a19

Revert "r/aws_instance: Delete 'TestAccAWSInstance_multipleRegions'."

ea06387

This reverts commit 9532c8a06c2fc3a1afc017d91de381b9f25feccb.

Correction after rename of aws_availability_zones data source.

41d077e

ewbankkit force-pushed the td-aws_instance-resource-remove-hardcoded-ami branch from 873b9bb to 41d077e Compare August 6, 2020 15:28

YakDriver added this to the v3.1.0 milestone Aug 6, 2020

YakDriver merged commit 9b17cf1 into hashicorp:master Aug 6, 2020

ewbankkit deleted the td-aws_instance-resource-remove-hardcoded-ami branch August 6, 2020 18:44

ghost locked and limited conversation to collaborators Sep 6, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/aws_instance: Remove hardcoded AMI IDs from acceptance tests #14159

r/aws_instance: Remove hardcoded AMI IDs from acceptance tests #14159

ewbankkit commented Jul 13, 2020 •

edited

Loading

ewbankkit commented Jul 14, 2020 •

edited

Loading

ewbankkit Jul 29, 2020

ewbankkit Jul 29, 2020

YakDriver Aug 5, 2020

ewbankkit Jul 29, 2020

ewbankkit Jul 29, 2020

ewbankkit Jul 29, 2020

ewbankkit commented Jul 30, 2020

YakDriver commented Aug 6, 2020

ewbankkit commented Aug 6, 2020

ewbankkit commented Aug 6, 2020 •

edited

Loading

YakDriver commented Aug 6, 2020

YakDriver commented Aug 6, 2020

ghost commented Aug 7, 2020

ghost commented Sep 6, 2020

		@@ -236,52 +236,51 @@ func TestAccAWSInstance_inEc2Classic(t *testing.T) {

		func TestAccAWSInstance_basic(t *testing.T) {

r/aws_instance: Remove hardcoded AMI IDs from acceptance tests #14159

r/aws_instance: Remove hardcoded AMI IDs from acceptance tests #14159

Conversation

ewbankkit commented Jul 13, 2020 • edited Loading

Community Note

Default test region (us-west-2):

ewbankkit commented Jul 14, 2020 • edited Loading

Non-default test region (us-east-1 with EC2-Classic):

ewbankkit Jul 29, 2020

Choose a reason for hiding this comment

ewbankkit Jul 29, 2020

Choose a reason for hiding this comment

YakDriver Aug 5, 2020

Choose a reason for hiding this comment

ewbankkit Jul 29, 2020

Choose a reason for hiding this comment

ewbankkit Jul 29, 2020

Choose a reason for hiding this comment

ewbankkit Jul 29, 2020

Choose a reason for hiding this comment

ewbankkit commented Jul 30, 2020

YakDriver commented Aug 6, 2020

ewbankkit commented Aug 6, 2020

ewbankkit commented Aug 6, 2020 • edited Loading

YakDriver commented Aug 6, 2020

YakDriver commented Aug 6, 2020

ghost commented Aug 7, 2020

ghost commented Sep 6, 2020

ewbankkit commented Jul 13, 2020 •

edited

Loading

Default test region (`us-west-2`):

ewbankkit commented Jul 14, 2020 •

edited

Loading

Non-default test region (`us-east-1` with EC2-Classic):

ewbankkit commented Aug 6, 2020 •

edited

Loading