Remove hardcoded AMIs in spot instance request tests

[YakDriver]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Central management issue: #12994

Release note for CHANGELOG:

NONE

See AWSAT002

Current stats of acceptance tests for this PR:

Partition	Passing	Failing	Test
us-gov	5	6*	With-PR
us-gov	0	11	Pre-PR
standard	11	0	With-PR
standard	11	0	Pre-PR

• All the current failures are the same. I think we'll need to handle them in a separate PR (not sure of the cause):

Error: Error while waiting for spot request ({
          ...
          State: "open",
          Status: {
            Code: "pending-evaluation",
            Message: "Your Spot request has been submitted for review, and is pending evaluation.",
            UpdateTime: 2020-07-07 23:40:40 +0000 UTC
          },
          Type: "persistent"
        }) to resolve: unexpected state 'bad-parameters', wanted target 'fulfilled'. last error: %!s(<nil>)

[bflad]

These changes look good, looks like other technical debt is preventing them from getting clean testing runs 🚀

Output from acceptance testing in AWS Commercial (unrelated test failure is very recently flaky with capacity-not-available, likely to be fixed with upcoming instance type data source changes):

--- FAIL: TestAccAWSSpotInstanceRequest_withBlockDuration (22.07s)

--- PASS: TestAccAWSSpotInstanceRequest_withLaunchGroup (76.04s)
--- PASS: TestAccAWSSpotInstanceRequest_vpc (77.05s)
--- PASS: TestAccAWSSpotInstanceRequest_SubnetAndSGAndPublicIpAddress (79.02s)
--- PASS: TestAccAWSSpotInstanceRequest_NetworkInterfaceAttributes (79.97s)
--- PASS: TestAccAWSSpotInstanceRequest_basic (86.02s)
--- PASS: TestAccAWSSpotInstanceRequest_validUntil (86.45s)
--- PASS: TestAccAWSSpotInstanceRequest_withoutSpotPrice (96.39s)
--- PASS: TestAccAWSSpotInstanceRequest_getPasswordData (213.13s)
--- PASS: TestAccAWSSpotInstanceRequest_InterruptStop (287.00s)
--- PASS: TestAccAWSSpotInstanceRequest_InterruptHibernate (297.01s)

Output from acceptance testing in AWS GovCloud (US) (unrelated test failures will require separate investigation/fixes):

--- FAIL: TestAccAWSSpotInstanceRequest_withLaunchGroup (19.61s)
--- FAIL: TestAccAWSSpotInstanceRequest_basic (19.80s)
--- FAIL: TestAccAWSSpotInstanceRequest_validUntil (20.12s)
--- FAIL: TestAccAWSSpotInstanceRequest_withoutSpotPrice (20.49s)
--- FAIL: TestAccAWSSpotInstanceRequest_withBlockDuration (20.38s)
--- FAIL: TestAccAWSSpotInstanceRequest_getPasswordData (20.53s)
--- PASS: TestAccAWSSpotInstanceRequest_SubnetAndSGAndPublicIpAddress (103.85s)
--- PASS: TestAccAWSSpotInstanceRequest_vpc (113.31s)
--- PASS: TestAccAWSSpotInstanceRequest_NetworkInterfaceAttributes (124.58s)
--- PASS: TestAccAWSSpotInstanceRequest_InterruptStop (293.39s)
--- PASS: TestAccAWSSpotInstanceRequest_InterruptHibernate (302.07s)

[ghost]

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!