-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hardcoded AMIs in spot instance request tests #14082
Conversation
11634aa
to
24a8a1d
Compare
1e23433
to
4d991d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good, looks like other technical debt is preventing them from getting clean testing runs 🚀
Output from acceptance testing in AWS Commercial (unrelated test failure is very recently flaky with capacity-not-available, likely to be fixed with upcoming instance type data source changes):
--- FAIL: TestAccAWSSpotInstanceRequest_withBlockDuration (22.07s)
--- PASS: TestAccAWSSpotInstanceRequest_withLaunchGroup (76.04s)
--- PASS: TestAccAWSSpotInstanceRequest_vpc (77.05s)
--- PASS: TestAccAWSSpotInstanceRequest_SubnetAndSGAndPublicIpAddress (79.02s)
--- PASS: TestAccAWSSpotInstanceRequest_NetworkInterfaceAttributes (79.97s)
--- PASS: TestAccAWSSpotInstanceRequest_basic (86.02s)
--- PASS: TestAccAWSSpotInstanceRequest_validUntil (86.45s)
--- PASS: TestAccAWSSpotInstanceRequest_withoutSpotPrice (96.39s)
--- PASS: TestAccAWSSpotInstanceRequest_getPasswordData (213.13s)
--- PASS: TestAccAWSSpotInstanceRequest_InterruptStop (287.00s)
--- PASS: TestAccAWSSpotInstanceRequest_InterruptHibernate (297.01s)
Output from acceptance testing in AWS GovCloud (US) (unrelated test failures will require separate investigation/fixes):
--- FAIL: TestAccAWSSpotInstanceRequest_withLaunchGroup (19.61s)
--- FAIL: TestAccAWSSpotInstanceRequest_basic (19.80s)
--- FAIL: TestAccAWSSpotInstanceRequest_validUntil (20.12s)
--- FAIL: TestAccAWSSpotInstanceRequest_withoutSpotPrice (20.49s)
--- FAIL: TestAccAWSSpotInstanceRequest_withBlockDuration (20.38s)
--- FAIL: TestAccAWSSpotInstanceRequest_getPasswordData (20.53s)
--- PASS: TestAccAWSSpotInstanceRequest_SubnetAndSGAndPublicIpAddress (103.85s)
--- PASS: TestAccAWSSpotInstanceRequest_vpc (113.31s)
--- PASS: TestAccAWSSpotInstanceRequest_NetworkInterfaceAttributes (124.58s)
--- PASS: TestAccAWSSpotInstanceRequest_InterruptStop (293.39s)
--- PASS: TestAccAWSSpotInstanceRequest_InterruptHibernate (302.07s)
This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Central management issue: #12994
Release note for CHANGELOG:
See AWSAT002
Current stats of acceptance tests for this PR: