Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/provider: Use 0.12 interpolation syntax #14096

Merged
merged 1 commit into from
Jul 10, 2020
Merged

docs/provider: Use 0.12 interpolation syntax #14096

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions website/docs/r/route53_zone.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,17 +40,11 @@ resource "aws_route53_zone" "dev" {
}

resource "aws_route53_record" "dev-ns" {
zone_id = "${aws_route53_zone.main.zone_id}"
zone_id = aws_route53_zone.main.zone_id
name = "dev.example.com"
type = "NS"
ttl = "30"

records = [
"${aws_route53_zone.dev.name_servers.0}",
"${aws_route53_zone.dev.name_servers.1}",
"${aws_route53_zone.dev.name_servers.2}",
"${aws_route53_zone.dev.name_servers.3}",
]
records = aws_route53_zone.dev.name_servers
Comment on lines -48 to +47
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bflad do you mind clarifying -- is the switch from declaring all the name servers to referencing the list in line with changes that you think should be made where available? If so, I'll try to utilize any shortcuts like this one in followup PRs to other resource examples.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavidJFelix yes, its a good change and there will likely be other places where similar 0.12 optimizations can be done. Please do note though that we will be running an automated script as part of #8950 to update all the web page examples at once in the next week, so I would suggest waiting until that is ran and merged before submitting more 0.12 syntax updates. 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

}
```

Expand All @@ -65,7 +59,7 @@ resource "aws_route53_zone" "private" {
name = "example.com"

vpc {
vpc_id = "${aws_vpc.example.id}"
vpc_id = aws_vpc.example.id
}
}
```
Expand Down