-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/provider: Use 0.12 interpolation syntax #14096
Conversation
The examples used <0.12 interpolation syntax which made them more verbose than necessary.
I opened this PR because I wanted to discuss some of the more powerful 0.12 interpolation syntax changes. This example featured a list to list interpolation that I thought could be dramatically reduced and wanted to see if this was in line with the direction of the updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We will likely merge this tomorrow as we switch over to 3.0 work. Thanks, @DavidJFelix 🚀
records = [ | ||
"${aws_route53_zone.dev.name_servers.0}", | ||
"${aws_route53_zone.dev.name_servers.1}", | ||
"${aws_route53_zone.dev.name_servers.2}", | ||
"${aws_route53_zone.dev.name_servers.3}", | ||
] | ||
records = aws_route53_zone.dev.name_servers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bflad do you mind clarifying -- is the switch from declaring all the name servers to referencing the list in line with changes that you think should be made where available? If so, I'll try to utilize any shortcuts like this one in followup PRs to other resource examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DavidJFelix yes, its a good change and there will likely be other places where similar 0.12 optimizations can be done. Please do note though that we will be running an automated script as part of #8950 to update all the web page examples at once in the next week, so I would suggest waiting until that is ran and merged before submitting more 0.12 syntax updates. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
The examples used <0.12 interpolation syntax which made them more verbose than necessary.
Community Note
Relates to #8950
Release note for CHANGELOG: