Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/provider: Use 0.12 interpolation syntax #14096

Merged
merged 1 commit into from
Jul 10, 2020
Merged

docs/provider: Use 0.12 interpolation syntax #14096

merged 1 commit into from
Jul 10, 2020

Conversation

DavidJFelix
Copy link
Contributor

The examples used <0.12 interpolation syntax which made them more verbose than necessary.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates to #8950

Release note for CHANGELOG:

Update Route53 documentation for 0.12

The examples used <0.12 interpolation syntax which made them more verbose than necessary.
@DavidJFelix DavidJFelix requested a review from a team July 8, 2020 20:26
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/route53 Issues and PRs that pertain to the route53 service. documentation Introduces or discusses updates to documentation. labels Jul 8, 2020
@DavidJFelix
Copy link
Contributor Author

I opened this PR because I wanted to discuss some of the more powerful 0.12 interpolation syntax changes. This example featured a list to list interpolation that I thought could be dramatically reduced and wanted to see if this was in line with the direction of the updates.

@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Jul 9, 2020
@bflad bflad added this to the v3.0.0 milestone Jul 9, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We will likely merge this tomorrow as we switch over to 3.0 work. Thanks, @DavidJFelix 🚀

Comment on lines -48 to +47
records = [
"${aws_route53_zone.dev.name_servers.0}",
"${aws_route53_zone.dev.name_servers.1}",
"${aws_route53_zone.dev.name_servers.2}",
"${aws_route53_zone.dev.name_servers.3}",
]
records = aws_route53_zone.dev.name_servers
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bflad do you mind clarifying -- is the switch from declaring all the name servers to referencing the list in line with changes that you think should be made where available? If so, I'll try to utilize any shortcuts like this one in followup PRs to other resource examples.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavidJFelix yes, its a good change and there will likely be other places where similar 0.12 optimizations can be done. Please do note though that we will be running an automated script as part of #8950 to update all the web page examples at once in the next week, so I would suggest waiting until that is ran and merged before submitting more 0.12 syntax updates. 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@bflad bflad merged commit 4e75535 into hashicorp:master Jul 10, 2020
@DavidJFelix DavidJFelix deleted the patch-1 branch July 13, 2020 16:48
@ghost
Copy link

ghost commented Jul 31, 2020

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Aug 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/route53 Issues and PRs that pertain to the route53 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants