-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CodePipeline cross-region action support #12549
Conversation
Adds support for the region parameter of Codepipeline actions. This was added in November: https://aws.amazon.com/about-aws/whats-new/2018/11/aws-codepipeline-now-supports-cross-region-actions/
Adds support for specifying Artifact Stores to enable multi region pipelines.
@gdavison is there any help you could use on this PR or any way that the community could help move this forward :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is looking pretty good, just requesting some changes for the testing. 👍
…adds missing CodePipeline precheck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 🚀
Output from acceptance testing:
--- PASS: TestResourceAWSCodePipelineExpandArtifactStoresValidation (0.00s)
--- PASS: TestAccAWSCodePipelineWebhook_basic (24.22s)
--- PASS: TestAccAWSCodePipeline_basic (33.62s)
--- PASS: TestAccAWSCodePipelineWebhook_unauthenticated (34.61s)
--- PASS: TestAccAWSCodePipeline_deployWithServiceRole (36.14s)
--- PASS: TestAccAWSCodePipelineWebhook_ipAuth (37.23s)
--- PASS: TestAccAWSCodePipeline_emptyArtifacts (43.23s)
--- PASS: TestAccAWSCodePipeline_multiregion_basic (48.49s)
--- PASS: TestAccAWSCodePipeline_tags (54.44s)
--- PASS: TestAccAWSCodePipelineWebhook_UpdateAuthenticationConfiguration_SecretToken (59.03s)
--- PASS: TestAccAWSCodePipeline_multiregion_Update (66.93s)
--- PASS: TestAccAWSCodePipelineWebhook_tags (68.17s)
--- PASS: TestAccAWSCodePipeline_multiregion_ConvertSingleRegion (71.34s)
This has been released in version 2.56.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
This PR picks up on the work done by @bashton-ajenkins in #7866 to add cross-region actions.
Community Note
Closes #7866
Closes #6871
Release note for CHANGELOG:
Output from acceptance testing: