Add stage action namespace to resource_aws_codepipeline #11910

suchpuppet · 2020-02-05T19:16:34Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

Adds support for action stage namespace.  This allows variable namespacing for use in other stages.

Output from acceptance testing:

⚡ [~/development/terraform-providers/terraform-provider-aws]--> make testacc TESTARGS='-run=TestAccAWSCodePipelineWithNamespace'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSCodePipelineWithNamespace -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSCodePipelineWithNamespace
=== PAUSE TestAccAWSCodePipelineWithNamespace
=== CONT  TestAccAWSCodePipelineWithNamespace
--- PASS: TestAccAWSCodePipelineWithNamespace (46.47s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       47.927s
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap      0.506s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags 0.059s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/service/eks/token    0.091s [no tests to run]
?       github.com/terraform-providers/terraform-provider-aws/awsproviderlint   [no test files]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-aws/awsproviderlint/passes    0.260s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-aws/awsproviderlint/passes/AWSAT001   0.286s [no tests to run]
⚡ [~/development/terraform-providers/terraform-provider-aws]--> git pull'
...

The ability to use namespace in build actions is necessary to be able to do things like use the Github provider and reference the BranchName from the source stage. I ran into this when trying to use a Lambda to dynamically create pipelines similar to what is shown here: https://github.com/nicolai86/awesome-codepipeline-ci

When using the GitHub source provider, it wasn't possible to do that because I was not able to use namespaced variables from the source stage in the build stage without the updates in this pull request. When testing the updates in the pull request out, the pipeline was successfully created with the proper variable namespace and my build stage was able to use them.

jacobeatsspam · 2020-04-02T14:20:39Z

@bflad Could this get some attention? It's been waiting a long time and seems to have a lot of support.

bflad · 2020-04-02T14:44:26Z

Hi @jacobisaliveandwell 👋 There are some inflight changes to the aws_codepipeline resource here: #12549

After that's been merged, we can take a look at this one. Thanks.

ilyalukyanov · 2020-04-04T22:44:13Z

@suchpuppet would you be able to resolve conflicts please? Now that #12549 has been merged this can proceed.

Thanks for making the change, btw. It's needed like air.

suchpuppet · 2020-04-08T05:47:14Z

@ilyalukyanov Sorry for the delay. Been busy. Conflicts have been resolved. Thanks for getting attention on this change as well.

sonoman · 2020-04-08T16:21:18Z

aws/resource_aws_codepipeline_test.go

+		t.Skip("Environment variable GITHUB_TOKEN is not set")
+	}
+
+	var p1, p2 codepipeline.PipelineDeclaration


Lint is failing because p2 is declared but never used

Thanks. I'll remove that.

DrFaust92 · 2020-04-08T17:10:12Z

aws/resource_aws_codepipeline_test.go

+					resource.TestMatchResourceAttr(resourceName, "arn",
+						regexp.MustCompile(fmt.Sprintf("^arn:aws:codepipeline:[^:]+:[0-9]{12}:test-pipeline-%s", name))),


can you change this to use testAccMatchResourceAttrRegionalARN instead?

DrFaust92 · 2020-04-08T17:10:47Z

aws/resource_aws_codepipeline.go

@@ -434,6 +442,10 @@ func flattenAwsCodePipelineStageActions(actions []*codepipeline.ActionDeclaratio
 			values["region"] = *action.Region
 		}

+		if action.Namespace != nil {
+			values["namespace"] = *action.Namespace


can you change this to values["namespace"] = aws.StringValue(action.Namespace)

nl-brett-stime · 2020-04-13T18:44:48Z

aws/resource_aws_codepipeline_test.go

+				Config: testAccAWSCodePipelineConfigWithNamespace(name),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckAWSCodePipelineExists(resourceName, &p1),
+					resource.testAccMatchResourceAttrRegionalARN(resourceName, "arn", regexp.MustCompile(fmt.Sprintf("^arn:aws:codepipeline:[^:]+:[0-9]{12}:test-pipeline-%s", name))),


To fix the linting/tests in Travis, I believe you need to remove the resource. prefix and add a third argument with the value of "codepipeline" here:

testAccMatchResourceAttrRegionalARN(resourceName, "arn", "codepipeline", regexp.MustCompile(fmt.Sprintf("^arn:aws:codepipeline:[^:]+:[0-9]{12}:test-pipeline-%s", name))),

nl-brett-stime · 2020-04-14T15:06:21Z

@bflad It looks like this can move forward now that #12549 is merged. I'm not sure what the right etiquette is for moving someone else's PR (@suchpuppet) forward but I'm available to help however I can.

nl-brett-stime · 2020-04-15T14:31:05Z

FWIW, I've filed a PR for @suchpuppet 's fork: suchpuppet#1

...using my fix for the Travis lint/test stages: nl-brett-stime@b6dfbb9

Fixes testAccMatchResourceAttrRegionalARN

aws/resource_aws_codepipeline_test.go

…ipelineWithNamespace

bflad

Thanks so much for this, @suchpuppet 🚀

Output from acceptance testing:

--- PASS: TestResourceAWSCodePipelineExpandArtifactStoresValidation (0.00s)
--- PASS: TestAccAWSCodePipelineWithNamespace (28.70s)
--- PASS: TestAccAWSCodePipeline_deployWithServiceRole (32.42s)
--- PASS: TestAccAWSCodePipelineWebhook_basic (38.44s)
--- PASS: TestAccAWSCodePipelineWebhook_UpdateAuthenticationConfiguration_SecretToken (38.75s)
--- PASS: TestAccAWSCodePipeline_emptyArtifacts (41.79s)
--- PASS: TestAccAWSCodePipeline_multiregion_basic (45.82s)
--- PASS: TestAccAWSCodePipelineWebhook_unauthenticated (48.52s)
--- PASS: TestAccAWSCodePipelineWebhook_ipAuth (52.47s)
--- PASS: TestAccAWSCodePipelineWebhook_tags (52.76s)
--- PASS: TestAccAWSCodePipeline_basic (57.69s)
--- PASS: TestAccAWSCodePipeline_tags (60.91s)
--- PASS: TestAccAWSCodePipeline_multiregion_Update (66.88s)
--- PASS: TestAccAWSCodePipeline_multiregion_ConvertSingleRegion (69.45s)

ghost · 2020-04-24T00:38:33Z

This has been released in version 2.59.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2020-05-23T17:10:31Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

Add action namespace

6162465

suchpuppet requested a review from a team February 5, 2020 19:16

matllubos approved these changes Feb 25, 2020

View reviewed changes

jacobeatsspam approved these changes Apr 2, 2020

View reviewed changes

bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 2, 2020

This comment has been minimized.

Sign in to view

Merge branch 'master' into master

f0a5d8d

suchpuppet added 3 commits April 8, 2020 00:05

gofmt after conflict resolution

bc750fe

Fix linting

aba2bf0

Add missing var

0427c8b

sonoman reviewed Apr 8, 2020

View reviewed changes

Remove unused var

66ddd97

DrFaust92 suggested changes Apr 8, 2020

View reviewed changes

Address PR change requests

2914ef8

nl-brett-stime reviewed Apr 13, 2020

View reviewed changes

Fixes testAccMatchResourceAttrRegionalARN

b6dfbb9

Merge pull request #1 from nl-brett-stime/master

be10af3

Fixes testAccMatchResourceAttrRegionalARN

bflad self-assigned this Apr 16, 2020

bflad added this to the v2.59.0 milestone Apr 16, 2020

bflad reviewed Apr 22, 2020

View reviewed changes

aws/resource_aws_codepipeline_test.go Outdated Show resolved Hide resolved

tests/resource/aws_codepipeline: Fix failing ARN check

0e18112

bflad reviewed Apr 22, 2020

View reviewed changes

aws/resource_aws_codepipeline_test.go Outdated Show resolved Hide resolved

tests/resource/aws_codepipeline: Additional fixes for TestAccAWSCodeP…

d982c30

…ipelineWithNamespace

bflad approved these changes Apr 22, 2020

View reviewed changes

bflad merged commit 4a9cc12 into hashicorp:master Apr 22, 2020

ghost locked and limited conversation to collaborators May 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add stage action namespace to resource_aws_codepipeline #11910

Add stage action namespace to resource_aws_codepipeline #11910

suchpuppet commented Feb 5, 2020

jacobeatsspam commented Apr 2, 2020

bflad commented Apr 2, 2020

ilyalukyanov commented Apr 4, 2020

This comment has been minimized.

suchpuppet commented Apr 8, 2020

sonoman Apr 8, 2020

suchpuppet Apr 8, 2020

DrFaust92 Apr 8, 2020

suchpuppet Apr 8, 2020

DrFaust92 Apr 8, 2020

suchpuppet Apr 8, 2020

nl-brett-stime Apr 13, 2020 •

edited

Loading

nl-brett-stime commented Apr 14, 2020

nl-brett-stime commented Apr 15, 2020

bflad left a comment

ghost commented Apr 24, 2020

ghost commented May 23, 2020

		resource.TestMatchResourceAttr(resourceName, "arn",
		regexp.MustCompile(fmt.Sprintf("^arn:aws:codepipeline:[^:]+:[0-9]{12}:test-pipeline-%s", name))),

Add stage action namespace to resource_aws_codepipeline #11910

Add stage action namespace to resource_aws_codepipeline #11910

Conversation

suchpuppet commented Feb 5, 2020

Community Note

jacobeatsspam commented Apr 2, 2020

bflad commented Apr 2, 2020

ilyalukyanov commented Apr 4, 2020

This comment has been minimized.

suchpuppet commented Apr 8, 2020

sonoman Apr 8, 2020

Choose a reason for hiding this comment

suchpuppet Apr 8, 2020

Choose a reason for hiding this comment

DrFaust92 Apr 8, 2020

Choose a reason for hiding this comment

suchpuppet Apr 8, 2020

Choose a reason for hiding this comment

DrFaust92 Apr 8, 2020

Choose a reason for hiding this comment

suchpuppet Apr 8, 2020

Choose a reason for hiding this comment

nl-brett-stime Apr 13, 2020 • edited Loading

Choose a reason for hiding this comment

nl-brett-stime commented Apr 14, 2020

nl-brett-stime commented Apr 15, 2020

bflad left a comment

Choose a reason for hiding this comment

ghost commented Apr 24, 2020

ghost commented May 23, 2020

nl-brett-stime Apr 13, 2020 •

edited

Loading