Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]aws_finspace_kx_dataview #34828

Merged
merged 19 commits into from
Dec 14, 2023

Conversation

ItsYou
Copy link
Contributor

@ItsYou ItsYou commented Dec 8, 2023

Description

Introduces a new resource for finspace_kx_dataview. Includes resource handlers, tests, and documentation changes.

Relations

Relates #34831 - changes in aws_finspace_kx_cluster includes support for this resource
Relates #34833 - aws_finspace_kx_volume dependency for for this resource
Relates #34832 - aws_finspace_kx_scaling_group needed as a dependency for aws_finspace_kx_volumes

References

Output from Acceptance Testing

% make testacc TESTS=TestAccFinSpaceKxDataview_basic PKG=finspace
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxDataview_basic'  -timeout 360m
=== RUN   TestAccFinSpaceKxDataview_basic
=== PAUSE TestAccFinSpaceKxDataview_basic
=== CONT  TestAccFinSpaceKxDataview_basic
--- PASS: TestAccFinSpaceKxDataview_basic (1323.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	1328.244s

% make testacc TESTS=TestAccFinSpaceKxDataview_disappears PKG=finspace
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxDataview_disappears'  -timeout 360m
=== RUN   TestAccFinSpaceKxDataview_disappears
=== PAUSE TestAccFinSpaceKxDataview_disappears
=== CONT  TestAccFinSpaceKxDataview_disappears
--- PASS: TestAccFinSpaceKxDataview_disappears (1249.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	1255.294s

% make testacc TESTS=TestAccFinSpaceKxDataview_withKxVolume PKG=finspace
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxDataview_withKxVolume'  -timeout 360m
=== RUN   TestAccFinSpaceKxDataview_withKxVolume
=== PAUSE TestAccFinSpaceKxDataview_withKxVolume
=== CONT  TestAccFinSpaceKxDataview_withKxVolume
--- PASS: TestAccFinSpaceKxDataview_withKxVolume (1908.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	1913.114s

Copy link

github-actions bot commented Dec 8, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/finspace Issues and PRs that pertain to the finspace service. labels Dec 8, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 8, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @ItsYou 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ItsYou ItsYou changed the title [New Resource]aws_finspace_kx_environment [New Resource]aws_finspace_kx_dataview Dec 8, 2023
@ItsYou ItsYou marked this pull request as ready for review December 8, 2023 22:09
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 12, 2023
@jar-b jar-b added the partner Contribution from a partner. label Dec 13, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc TESTS=TestAccFinSpaceKxDataview_basic PKG=finspace ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 1 -run='TestAccFinSpaceKxDataview_basic'  -timeout 360m
=== RUN   TestAccFinSpaceKxDataview_basic
=== PAUSE TestAccFinSpaceKxDataview_basic
=== CONT  TestAccFinSpaceKxDataview_basic
--- PASS: TestAccFinSpaceKxDataview_basic (1042.20s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/finspace   1045.442s

@jar-b jar-b merged commit 3de2fd3 into hashicorp:main Dec 14, 2023
43 checks passed
@jar-b
Copy link
Member

jar-b commented Dec 14, 2023

Thanks for your contribution, @ItsYou! 👍

@github-actions github-actions bot added this to the v5.31.0 milestone Dec 14, 2023
Copy link

This functionality has been released in v5.31.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/finspace Issues and PRs that pertain to the finspace service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants