Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
internal/provider(test): remove DMS from unusual endpoint tests (#38694)
DMS has been migrated to AWS SDK for Go V2, and thus the corresponding `DMSConn` method to create a V1 client no longer exists. The generic `TestAccProvider_endpoints` test effectively ignores services which use V2 AWS SDK clients with the following conditional in the test check function (`serviceConn` will always return a method name ending in `Conn`): ```go methodName := serviceConn(serviceKey) method := reflect.ValueOf(providerClient).MethodByName(methodName) if !method.IsValid() { continue } ``` Because this generic test check ignores V2 clients, the DMS case for the unusual endpoints tests has been removed entirely rather than including new conditional logic which would effectively just skip the case before executing any real checks. ```console % TF_ACC=1 go test -count=1 ./internal/provider/... -run="TestAccProvider_unusualEndpoints" ? github.com/hashicorp/terraform-provider-aws/internal/provider/fwprovider [no test files] ok github.com/hashicorp/terraform-provider-aws/internal/provider 23.263s ```
- Loading branch information