Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/provider(test): remove DMS from unusual endpoint tests #38694

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Aug 5, 2024

Description

DMS has been migrated to AWS SDK for Go V2, and thus the corresponding DMSConn method to create a V1 client no longer exists. The generic TestAccProvider_endpoints test effectively ignores services which use V2 AWS SDK clients with the following conditional in the test check function (serviceConn will always return a method name ending in Conn):

			methodName := serviceConn(serviceKey)
			method := reflect.ValueOf(providerClient).MethodByName(methodName)
			if !method.IsValid() {
				continue
			}

Because this generic test check ignores V2 clients, the DMS case for the unusual endpoints tests has been removed entirely rather than including new conditional logic which would effectively just skip the case before executing any real checks.

Relations

Relates #37780

Output from Acceptance Testing

% TF_ACC=1 go test -count=1 ./internal/provider/... -run="TestAccProvider_unusualEndpoints"
?       github.com/hashicorp/terraform-provider-aws/internal/provider/fwprovider        [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/provider   23.263s

DMS has been migrated to AWS SDK for Go V2, and thus the corresponding `DMSConn` method to create a V1 client no longer exists. The generic `TestAccProvider_endpoints` test effectively ignores services which use V2 AWS SDK clients with the following conditional in the test check function (`serviceConn` will always return a method name ending in `Conn`):

```go
			methodName := serviceConn(serviceKey)
			method := reflect.ValueOf(providerClient).MethodByName(methodName)
			if !method.IsValid() {
				continue
			}
```

Because this generic test check ignores V2 clients, the DMS case for the unusual endpoints tests has been removed entirely rather than including new conditional logic which would effectively just skip the case before executing any real checks.

```console
% TF_ACC=1 go test -count=1 ./internal/provider/... -run="TestAccProvider_unusualEndpoints"
?       github.com/hashicorp/terraform-provider-aws/internal/provider/fwprovider        [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/provider   23.263s
```
@jar-b jar-b requested a review from a team as a code owner August 5, 2024 18:55
@jar-b jar-b added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. labels Aug 5, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 5, 2024
@jar-b jar-b added technical-debt Addresses areas of the codebase that need refactoring or redesign. and removed prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Aug 5, 2024
Copy link

github-actions bot commented Aug 5, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@jar-b jar-b merged commit 78c1240 into main Aug 5, 2024
71 of 72 checks passed
@jar-b jar-b deleted the td-unusual-endpoint-testfix branch August 5, 2024 20:34
@github-actions github-actions bot added this to the v5.62.0 milestone Aug 5, 2024
Copy link

github-actions bot commented Aug 9, 2024

This functionality has been released in v5.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. provider Pertains to the provider itself, rather than any interaction with AWS. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants