-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/provider(test): remove DMS from unusual endpoint tests #38694
Conversation
DMS has been migrated to AWS SDK for Go V2, and thus the corresponding `DMSConn` method to create a V1 client no longer exists. The generic `TestAccProvider_endpoints` test effectively ignores services which use V2 AWS SDK clients with the following conditional in the test check function (`serviceConn` will always return a method name ending in `Conn`): ```go methodName := serviceConn(serviceKey) method := reflect.ValueOf(providerClient).MethodByName(methodName) if !method.IsValid() { continue } ``` Because this generic test check ignores V2 clients, the DMS case for the unusual endpoints tests has been removed entirely rather than including new conditional logic which would effectively just skip the case before executing any real checks. ```console % TF_ACC=1 go test -count=1 ./internal/provider/... -run="TestAccProvider_unusualEndpoints" ? github.com/hashicorp/terraform-provider-aws/internal/provider/fwprovider [no test files] ok github.com/hashicorp/terraform-provider-aws/internal/provider 23.263s ```
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
This functionality has been released in v5.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
DMS has been migrated to AWS SDK for Go V2, and thus the corresponding
DMSConn
method to create a V1 client no longer exists. The genericTestAccProvider_endpoints
test effectively ignores services which use V2 AWS SDK clients with the following conditional in the test check function (serviceConn
will always return a method name ending inConn
):Because this generic test check ignores V2 clients, the DMS case for the unusual endpoints tests has been removed entirely rather than including new conditional logic which would effectively just skip the case before executing any real checks.
Relations
Relates #37780
Output from Acceptance Testing