helper/schema: Additional validation for schema attribute references #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onflictsWith and list index/map key syntax Reference: hashicorp#71 Reference: bflad/tfproviderlint#104 The `TestSchemaMap_InternalValidate` tests also include TODOs for potential schema validation improvements.
|
@appilon sure thing, I'll submit another PR after rebasing this one so the difference is super easy to replicate. 👍 |
|
v1-maint pull request with cherry-picked commits 👍 #416 |
appilon
approved these changes
Apr 28, 2020
bflad
added a commit
to bflad/terraform-plugin-sdk
that referenced
this pull request
Apr 29, 2020
…OneOf/ExactlyOneOf Reference: hashicorp#407 Reference: hashicorp#416 Includes TODO items for logic that needs adjustment to work as expected. `AtLeastOneOf` and `ExactlyOneOf` at the attribute level should not only allow self-reference, but also require it.
bflad
added a commit
to bflad/terraform-plugin-sdk
that referenced
this pull request
Apr 29, 2020
…ExactlyOneOf in InternalValidate Reference: hashicorp#407 Reference: hashicorp#416
bflad
added a commit
to bflad/terraform-plugin-sdk
that referenced
this pull request
Apr 30, 2020
…OneOf/ExactlyOneOf Reference: hashicorp#407 Reference: hashicorp#416 Includes TODO items for logic that needs adjustment to work as expected. `AtLeastOneOf` and `ExactlyOneOf` at the attribute level should not only allow self-reference, but also require it.
bflad
added a commit
to bflad/terraform-plugin-sdk
that referenced
this pull request
Apr 30, 2020
…ExactlyOneOf in InternalValidate Reference: hashicorp#407 Reference: hashicorp#416
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #365
Reference: #71
Builds on testing from #364 (targeting v1). This PR currently targets v2.