Spot Fleet Launch Template Support

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Replaces #4866
Closes #4267

Release note for CHANGELOG:

resource_aws_spot_fleet_request: add `launch_template_config` support

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSpotFleetRequest_'
--- PASS: TestAccAWSSpotFleetRequest_basic (281.16s)
--- PASS: TestAccAWSSpotFleetRequest_tags (417.55s)
--- PASS: TestAccAWSSpotFleetRequest_associatePublicIpAddress (263.50s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate (278.78s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateConflictLaunchSpecification (3.86s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateWithOverrides (271.12s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateToLaunchSpec (544.95s)
--- PASS: TestAccAWSSpotFleetRequest_launchSpecToLaunchTemplate (811.98s)
--- PASS: TestAccAWSSpotFleetRequest_fleetType (333.26s)
--- PASS: TestAccAWSSpotFleetRequest_iamInstanceProfileArn (309.88s)
--- PASS: TestAccAWSSpotFleetRequest_changePriceForcesNewRequest (483.73s)
--- PASS: TestAccAWSSpotFleetRequest_updateTargetCapacity (893.50s)
--- PASS: TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy (602.37s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion (326.32s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList (351.75s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList (340.60s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz (351.36s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet (352.60s)
--- PASS: TestAccAWSSpotFleetRequest_overriddingSpotPrice (431.92s)
--- PASS: TestAccAWSSpotFleetRequest_withoutSpotPrice (290.77s)
--- PASS: TestAccAWSSpotFleetRequest_diversifiedAllocation (362.86s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstancePools (352.32s)
--- PASS: TestAccAWSSpotFleetRequest_withWeightedCapacity (371.93s)
--- PASS: TestAccAWSSpotFleetRequest_withEBSDisk (307.90s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId (177.76s)
--- PASS: TestAccAWSSpotFleetRequest_withTags (267.05s)
--- PASS: TestAccAWSSpotFleetRequest_placementTenancyAndGroup (103.40s)
--- PASS: TestAccAWSSpotFleetRequest_WithELBs (354.51s)
--- PASS: TestAccAWSSpotFleetRequest_WithTargetGroups (423.99s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId (193.76s)
--- PASS: TestAccAWSSpotFleetRequest_disappears (327.77s)

[scalp42]

Thanks a lot for the PR!

[bflad]

Hey there, @DrFaust92 -- first of all, thank you so much for rebasing and tackling this. 🥇 This is a very complex implementation (no fault of your own) and this resource logic is pretty dated in some parts, so kudos for shimming this in here. I left some initial feedback below on things I noticed from a first pass of looking over the code. Please let me know if you have questions and ping me when this is ready for another review, I'll try to provide feedback cycles ASAP. Thanks again.

[bflad]

Open question -- does this work without the Set function? We should prefer to omit it, unless the resource behaviors explicitly require it. 👍

[bflad]

Shaping up nicely! This round is mostly just fixing up the Terraform state setting and test naming randomization. After this we should be just on little fixes to finalize it. 🎉

[DrFaust92]

@bflad , i addressed the changes and running some more tests and check regarding dropping the Set function. it did give me some trouble testing after dropping it but ill check again after the last changes

[DrFaust92]

launch template tests are now passing

--- PASS: TestAccAWSSpotFleetRequest_launchTemplate (351.85s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateWithOverrides (320.83s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateToLaunchSpec (641.99s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate_multiple (288.88s)

with the exclusion of TestAccAWSSpotFleetRequest_launchTemplateConflictLaunchSpecification
as the way to get this to fail changed, any idea on how to change the regex? or should this be dropped as it became a plan time validation check?

[bflad]

with the exclusion of TestAccAWSSpotFleetRequest_launchTemplateConflictLaunchSpecification
as the way to get this to fail changed, any idea on how to change the regex? or should this be dropped as it became a plan time validation check?

We can skip it for now since its just validating plan-time behaviors that are tested in the Terraform Plugin SDK. For future reference when testing with ExpectError, you need to ensure the last TestStep has a valid configuration or the acceptance testing cannot destroy resources. See also: bflad/tfproviderlint#162

I'll drop it and merge this when CI passes after that, since I've verified the rest of the acceptance testing passes as expected. 👍

[bflad]

LGTM, thanks @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSSpotFleetRequest_associatePublicIpAddress (416.10s)
--- PASS: TestAccAWSSpotFleetRequest_basic (346.62s)
--- PASS: TestAccAWSSpotFleetRequest_changePriceForcesNewRequest (612.73s)
--- PASS: TestAccAWSSpotFleetRequest_disappears (229.25s)
--- PASS: TestAccAWSSpotFleetRequest_diversifiedAllocation (351.50s)
--- PASS: TestAccAWSSpotFleetRequest_fleetType (286.87s)
--- PASS: TestAccAWSSpotFleetRequest_iamInstanceProfileArn (285.22s)
--- PASS: TestAccAWSSpotFleetRequest_instanceInterruptionBehavior (284.16s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId (142.74s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId (145.99s)
--- PASS: TestAccAWSSpotFleetRequest_launchSpecToLaunchTemplate (540.97s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate (284.34s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate_multiple (213.22s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateToLaunchSpec (542.07s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateWithOverrides (216.46s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList (273.30s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion (345.74s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList (285.52s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstancePools (351.19s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz (337.09s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet (216.98s)
--- PASS: TestAccAWSSpotFleetRequest_overriddingSpotPrice (320.64s)
--- PASS: TestAccAWSSpotFleetRequest_placementTenancyAndGroup (63.07s)
--- PASS: TestAccAWSSpotFleetRequest_tags (354.51s)
--- PASS: TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy (542.49s)
--- PASS: TestAccAWSSpotFleetRequest_updateTargetCapacity (828.53s)
--- PASS: TestAccAWSSpotFleetRequest_withEBSDisk (279.53s)
--- PASS: TestAccAWSSpotFleetRequest_WithELBs (268.50s)
--- PASS: TestAccAWSSpotFleetRequest_withoutSpotPrice (350.86s)
--- PASS: TestAccAWSSpotFleetRequest_withTags (282.52s)
--- PASS: TestAccAWSSpotFleetRequest_WithTargetGroups (410.53s)
--- PASS: TestAccAWSSpotFleetRequest_withWeightedCapacity (289.97s)

[ghost]

This has been released in version 2.60.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!