This repository has been archived by the owner on Nov 20, 2024. It is now read-only.
Adding support for workspace secret per namespace #133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
This PR is adding the possibility to have
workspacesecrets
per namespace if the TFCO is run to watch all namespaces (when there is--k8s-watch-namespace=<namespace>
command line option specified). This allows to have multiple teams, where each team occupies one namespace, to have their own secrets that are passed to Terraform. This PR needs to be rebased once the PR #129 is merged to remove most of the changes in the CRD.The secret is referenced in the
Workspace
using thespec.secretName
:The secret referenced by with the
spec.secretName
must be located in the same namespace like theWorkspace
resource. Those secrets are merged with the workspace secret in the namespace where TFCO is installed and that is mounted into the container using thespec.secretsMountPath
.Release note for CHANGELOG: