Skip to content
This repository has been archived by the owner on Nov 20, 2024. It is now read-only.

Adding support for workspace secret per namespace #133

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jtyr
Copy link
Contributor

@jtyr jtyr commented Apr 11, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

This PR is adding the possibility to have workspacesecrets per namespace if the TFCO is run to watch all namespaces (when there is --k8s-watch-namespace=<namespace> command line option specified). This allows to have multiple teams, where each team occupies one namespace, to have their own secrets that are passed to Terraform. This PR needs to be rebased once the PR #129 is merged to remove most of the changes in the CRD.

The secret is referenced in the Workspace using the spec.secretName:

...
spec:
  secretName: mysecret
...

The secret referenced by with the spec.secretName must be located in the same namespace like the Workspace resource. Those secrets are merged with the workspace secret in the namespace where TFCO is installed and that is mounted into the container using the spec.secretsMountPath.

Release note for CHANGELOG:

Added support for workspace secret per namespace

@jtyr jtyr force-pushed the jtyr-ns_secret branch from 386af46 to c1600dc Compare July 5, 2022 09:13
@jtyr
Copy link
Contributor Author

jtyr commented Jul 5, 2022

This PR is rebased now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant