Skip to content
This repository has been archived by the owner on Nov 20, 2024. It is now read-only.

Updating Makefile and CRD to latest version #129

Merged
merged 6 commits into from
May 10, 2022

Conversation

jtyr
Copy link
Contributor

@jtyr jtyr commented Apr 11, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

This PR is updating the Makefile to be usable with latest kubebulkder (v3.3.0) and controller-gen (v0.8.0). As a consequence of this update, the CRD to is updated to the latest apiVersion: apiextensions.k8s.io/v1. It was generated by running make manifests.

Output:

$ kubectl describe workspace test
Name:         test
Namespace:    default
Labels:       <none>
Annotations:  <none>
API Version:  app.terraform.io/v1alpha1
Kind:         Workspace
...

Release note for CHANGELOG:

Updated Makefile to be usable with latest version of kubebuilder and controller-gen.
CRD apiVersion updated to apiextensions.k8s.io/v1.

@hashicorp-cla
Copy link

hashicorp-cla commented Apr 11, 2022

CLA assistant check
All committers have signed the CLA.

@jtyr jtyr changed the title Updating CRD to latest version Updating Makefile and CRD to latest version Apr 18, 2022
@alexsomesan
Copy link
Member

Hi, I tried to re-run make manifests again on a local clone of this branch and it's failing with not finding the controller-gen binary.

The strange thing is that it's looking for it under the local repo directory. Here's what I'm getting:

/Users/alex/work/terraform-k8s/bin/controller-gen rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
bash: /Users/alex/work/terraform-k8s/bin/controller-gen: No such file or directory
make: *** [manifests] Error 127

Copy link
Member

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making the changes I suggested to the Makefile seems to get everything to work again.

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@alexsomesan alexsomesan merged commit 0c7c35a into hashicorp:master May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants