Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider-generator): support renaming provider names in order to allow using two providers sharing the same name at the same time #3442

Merged
merged 4 commits into from
Jan 19, 2024

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented Jan 19, 2024

Adds support for the Terraform feature described here: https://developer.hashicorp.com/terraform/language/providers/requirements#handling-local-name-conflicts

Resolves #1258

Open items

  • add test case for JSON and HCL output when using two providers with the same name

@ansgarm ansgarm changed the title support provider renaming feat(provider-generator): support renaming provider names in order to allow using two providers sharing the same name at the same time Jan 19, 2024
@ansgarm ansgarm merged commit 7840fd6 into main Jan 19, 2024
31 of 32 checks passed
@ansgarm ansgarm deleted the support-provider-renaming branch January 19, 2024 13:09
ansgarm pushed a commit that referenced this pull request Jan 23, 2024
## 0.20.2

### feat

- feat(provider-generator): support renaming provider names in order to
allow using two providers sharing the same name at the same time
[\#3442](#3442)
- feat(provider-generator): Ensure we have unique names for modules
[\#3439](#3439)
- feat(docs): Mention Maven examples in note on project setup page
[\#3437](#3437)

### fix

- fix(docs): Run prettier
[\#3445](#3445)
- fix(lib): support dot-seperated nested accessors
[\#3444](#3444)
- fix(docs): Update CLI docs to refer to Gradle instead of Maven
[\#3434](#3434)
- fix(lib): Print a warning with manual steps to move a module when
UpgradeIds aspect encounters modules
[\#3432](#3432)
- fix(cli): don't prompt for providers during convert
[\#3431](#3431)
- fix(lib): inline zip creation
[\#3428](#3428)

### chore

- chore: Upgrade dependencies for @cdktf/hcl2cdk
[\#3452](#3452)
- chore: Upgrade dependencies for @cdktf/hcl2json
[\#3451](#3451)
- chore: Upgrade dependencies for @cdktf/provider-schema
[\#3450](#3450)
- chore: Upgrade dependencies for @cdktf/commons
[\#3449](#3449)
- chore: add CodeTabs component
[\#3443](#3443)
- chore(docs): update stacks documentation
[\#3440](#3440)
- chore: upgrade registry docs tool
[\#3430](#3430)
- chore: Upgrade dependencies for @cdktf/commons
[\#3424](#3424)
- chore(docs): fix currently-404 link to built-in templates
[\#3418](#3418)
- chore: Rk/suggestions for error codes
[\#3417](#3417)
- chore: fix updating script
[\#3396](#3396)
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure two providers with same name but from different namespaces can be used at the same time
2 participants