fix(lib): inline zip creation #3428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansgarm
previously approved these changes
Jan 16, 2024
DanielMSchmidt
force-pushed
the
make-asset-zip-more-robust
branch
from
ce7932e
to
d637c89
Compare
DanielMSchmidt
changed the title
DanielMSchmidt
force-pushed
the
make-asset-zip-more-robust
branch
from
98c68f4
to
bcd7176
Compare
We previously used an execSync to use a promise based API in a synchronous environment and due to a misunderstanding in how bundledDependencies can be used. Closes #3176
DanielMSchmidt
force-pushed
the
make-asset-zip-more-robust
branch
from
bcd7176
to
095e101
Compare
DanielMSchmidt
requested review from
mutahhir and
Maed223
and removed request for
a team
ansgarm
approved these changes
Jan 17, 2024
Merged
ansgarm
pushed a commit
that referenced
this pull request
Jan 23, 2024
## 0.20.2 ### feat - feat(provider-generator): support renaming provider names in order to allow using two providers sharing the same name at the same time [\#3442](#3442) - feat(provider-generator): Ensure we have unique names for modules [\#3439](#3439) - feat(docs): Mention Maven examples in note on project setup page [\#3437](#3437) ### fix - fix(docs): Run prettier [\#3445](#3445) - fix(lib): support dot-seperated nested accessors [\#3444](#3444) - fix(docs): Update CLI docs to refer to Gradle instead of Maven [\#3434](#3434) - fix(lib): Print a warning with manual steps to move a module when UpgradeIds aspect encounters modules [\#3432](#3432) - fix(cli): don't prompt for providers during convert [\#3431](#3431) - fix(lib): inline zip creation [\#3428](#3428) ### chore - chore: Upgrade dependencies for @cdktf/hcl2cdk [\#3452](#3452) - chore: Upgrade dependencies for @cdktf/hcl2json [\#3451](#3451) - chore: Upgrade dependencies for @cdktf/provider-schema [\#3450](#3450) - chore: Upgrade dependencies for @cdktf/commons [\#3449](#3449) - chore: add CodeTabs component [\#3443](#3443) - chore(docs): update stacks documentation [\#3440](#3440) - chore: upgrade registry docs tool [\#3430](#3430) - chore: Upgrade dependencies for @cdktf/commons [\#3424](#3424) - chore(docs): fix currently-404 link to built-in templates [\#3418](#3418) - chore: Rk/suggestions for error codes [\#3417](#3417) - chore: fix updating script [\#3396](#3396)
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously used an execSync on a different file in the bin folder. having this path was brittle, now we use __filename to run against the same file and use a check to see if this file is invoked via CLI or required.
Closes #3176