Add support for discard and ssd storage options. #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lbajolet-hashicorp
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Hi @jeinwag,
This looks good to me, thanks for taking care of that feature!
I left a couple of nits and a docs suggestion, once you've addressed them, feel free to update this PR and I'll take another look, but I think we should be ready to merge soon.
Thanks!
Co-authored-by: Lucas Bajolet <[email protected]>
|
thanks for the review, I applied your suggestions. |
|
Hi @jeinwag, Thanks for the quick reroll, since tests are all green, I'm merging this now. |
This was referenced Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the discard and ssd storage options.
Closes #69