Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iothread parameter is incorrectly used as the value for the ssd parameter #201

Closed
romantomjak opened this issue Jul 9, 2023 · 0 comments · Fixed by #204
Closed

iothread parameter is incorrectly used as the value for the ssd parameter #201

romantomjak opened this issue Jul 9, 2023 · 0 comments · Fixed by #204
Labels
bug

Comments

@romantomjak
Copy link
Contributor

Overview of the Issue

#199 introduced a bug where setting io_thread = true will also inadvertently enable ssd emulation.

Reproduction Steps

Build an image using this config:

source "proxmox-iso" "debian" {
  # ...
  disks {
    io_thread    = true
    # ...

The resulting image will have the ssd=1 set.

Plugin and Packer version

Packer v1.9.1
@romantomjak romantomjak added the bug label Jul 9, 2023
jeinwag added a commit to jeinwag/packer-plugin-proxmox that referenced this issue Jul 10, 2023
@jeinwag
Fix handling of SSD parameter.
fa2f770 
Closes hashicorp#201.
@jeinwag jeinwag mentioned this issue Jul 10, 2023
Merged
lbajolet-hashicorp pushed a commit that referenced this issue Jul 10, 2023
@jeinwag @lbajolet-hashicorp
Fix handling of SSD parameter.
6c76fbb 
Closes #201.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix handling of SSD parameter. jeinwag/packer-plugin-proxmox
1 participant
@romantomjak