UI: convert to angle bracket invocation #8075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the result of running the codemod and manually inserting line breaks where there were previously multiline invocations. I used file line length as a guide, aiming to keep them the same, with one exception: app/templates/components/gutter-menu.hbs, where I made the LinkTo @route instances be on their own lines which added two lines to the file. There was an error processing one file, as in ember-codemods/ember-angle-brackets-codemod#185 Uses of link-to with standalone data attributes were also missed ember-codemods/ember-angle-brackets-codemod#237
Ember Asset Size actionAs of 8fe0dff Files that got Smaller 🎉:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
This is the result of running the codemod with this config:
{
"includeValuelessDataTestAttributes": true
}
I applied the same line-length-preserving manual formatting
as in the previous commit. Thanks to @steventsao for
ember-codemods/ember-angle-brackets-codemod#241
This fixes errors such as these: https://app.circleci.com/pipelines/github/hashicorp/nomad/9595/workflows/69183c14-c50d-4076-a1f7-da5a36fb8b24/jobs/71633/tests It seems that there’s now a shadowing situation where {{task}} is being interpreted as an Ember Concurrency helper…? Since this is actually a task state anyway, easier to just rename it.
backspace
force-pushed
the
f-ui/angle-brackets
branch
from
3ae3f75 to
2078c2a
Compare
This is a manual fix for this instance missed because of ember-codemods/ember-angle-brackets-codemod#185
# Conflicts: # ui/app/routes/allocations/allocation/task/fs.js # ui/app/templates/allocations/allocation/task/fs.hbs # ui/app/templates/components/fs-breadcrumbs.hbs # ui/app/templates/components/fs/directory-entry.hbs
This is a repetition of 2078c2a post-merge.
backspace
commented
Jun 1, 2020
| Jobs | ||
| {{/link-to}} | ||
| </LinkTo> |
There was a problem hiding this comment.
This is an example of the pattern where the invocation becomes one line longer because @route is not a positional argument like it was with curly bracket invocation and it seemed to me to be more consistent to have it on a separate line as with other named arguments.
There was a problem hiding this comment.
I agree with this. Consistency over line count every time.
20 tasks
DingoEatingFuzz
approved these changes
Jun 1, 2020
backspace
added a commit
that referenced
this pull request
Jul 9, 2020
This includes fixes for newer template lint rules that came along with updating that dependency, which was necessary to be able to use the no-curly-component-invocation rule. It also updates some curly invocations that I missed in #8075.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a direct application of the ember-angle-brackets-codemod.
I manually restored newlines in multi-line component invocations, mostly
preserving file line length except as noted.
I needed to rename task to taskState in some cases to avoid Ember
Concurrency naming conflicts like this:
https://app.circleci.com/pipelines/github/hashicorp/nomad/9595/workflows/69183c14-c50d-4076-a1f7-da5a36fb8b24/jobs/71633/tests