Add config to enable transform on valueless attrs #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suchitadoshi1987
requested changes
Feb 4, 2020
| block | ||
| </Common::AccordionComponent> | ||
|
|
||
| <XFoo data-foo @name=\\"Sophie\\" /> |
There was a problem hiding this comment.
IMO This transformation is not correct since the component itself will not see data-foo as a string. It would be whatever value data-foo references to.
data-test is special because of ember-test-selectors, and hence we should only assume this logic for data-test selectors and not for others.
@rwjblue thoughts?
There was a problem hiding this comment.
a good example is here
{{#link-to
"cart"
data-test-foo
class="nav-actions__cart link--wo-style"
}}
Will render as:
<a data-test-foo href="/cart" id="ember183" class="nav-actions__cart link--wo-style ember-view">
</a>
whereas:
{{#link-to
"cart"
data-foo
class="nav-actions__cart link--wo-style"
}}
would output:
<a href="#" id="ember183" class="nav-actions__cart link--wo-style loading ember-view">
</a>
There was a problem hiding this comment.
That makes sense. I've updated my PR so it only transforms data-test attributes.
suchitadoshi1987
requested changes
Feb 7, 2020
suchitadoshi1987
requested changes
Feb 12, 2020
tylerturdenpants
approved these changes
Feb 13, 2020
backspace
added a commit
to hashicorp/nomad
that referenced
this pull request
May 29, 2020
This is the result of running the codemod with this config:
{
"includeValuelessDataTestAttributes": true
}
I applied the same line-length-preserving manual formatting
as in the previous commit. Thanks to @steventsao for
ember-codemods/ember-angle-brackets-codemod#241
backspace
added a commit
to backspace/ember-angle-brackets-codemod
that referenced
this pull request
May 29, 2020
This adds documentation for ember-codemods#241.
backspace
added a commit
to backspace/ember-angle-brackets-codemod
that referenced
this pull request
May 29, 2020
This adds documentation for ember-codemods#241.
backspace
added a commit
to backspace/ember-angle-brackets-codemod
that referenced
this pull request
May 29, 2020
This adds documentation for ember-codemods#241.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current codemod skips on transforming nodes with valueless attributes. This prevents a full migration for those who use libraries like ember-test-selectors.
This PR adds the config
includeValuelessDataAttributesso the codemod includes data attributes that are valueless.#237