Split the plugin-example into two binaries. #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reflects actual usage, and will close #11.
sethvargo
approved these changes
Nov 4, 2016
xiaoyao1991
reviewed
Dec 4, 2016
| HandshakeConfig: handshakeConfig, | ||
| Plugins: pluginMap, | ||
| }) | ||
| } | ||
|
|
||
| // handshakeConfigs are used to just do a basic handshake between | ||
| // a plugin and host. If the handshake fails, a user friendly error is shown. |
There was a problem hiding this comment.
Are we supposed to remove the plugin implementations below?
xiaoyao1991
reviewed
Dec 4, 2016
| @@ -26,7 +19,7 @@ func main() { | |||
| client := plugin.NewClient(&plugin.ClientConfig{ | |||
| HandshakeConfig: handshakeConfig, | |||
| Plugins: pluginMap, | |||
There was a problem hiding this comment.
I guess this is a more general usage question. Do we really need these configs, especially pluginMap here? That means it needs to know what plugins are available at compile time right? Kinda destroy the whole purpose of having plugins
Merged
|
Whoops, I saw #20 first (top of list :( ). Sorry. Merged that which should fix the same issue! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reflects actual usage, and will close #11.