Feature/aws ecs support #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @fdr2 Thanks for taking this up! We'll get this reviewed and merged in soon. Afterwards we'll have to update go-discover in the consul repo, so this won't be reflected in the main branch until the next patch release. The team did want to caution though that we haven't evaluated the effects of running consul servers inside of ECS ( aside from a single node cluster for dev/testing ) . So for the moment we only officially support using servers outside of ECS. There was a couple of factors that went into that decision -- one of them being some performance concerns around the EFS that ECS uses under the hood. Regardless, we're still cool with this as an experimental feature so please report back on the main consul repo sometime & let us know how this is working for you 👍 😄 |
|
Thanks @Amier3 I didn't mean to go against the grain 😅 It seemed like a common topic and I really enjoyed digging through go-discover to implement it. If you happen to know any way I can benchmark consul or what the particular performance concerns may be on ecs-efs I would be interesting in digging in deeper. |
pglass
reviewed
Jul 7, 2022
pglass
reviewed
Jul 12, 2022
pglass
approved these changes
Jul 14, 2022
|
Thanks @fdr2! To enable use of this in Consul, the next step is to open a PR to bump the library version in the consul repo. |
3 tasks
acaloiaro
pushed a commit
to acaloiaro/go-discover
that referenced
this pull request
Nov 24, 2022
* Add service argument to aws provider, where service can be either ec2 or ecs (defaulting to ec2) * Add optional ecs_cluster and ecs_family arguments
acaloiaro
pushed a commit
to acaloiaro/go-discover
that referenced
this pull request
Nov 24, 2022
* Add service argument to aws provider, where service can be either ec2 or ecs (defaulting to ec2) * Add optional ecs_cluster and ecs_family arguments
elprans
pushed a commit
to edgedb/go-discover
that referenced
this pull request
Dec 2, 2022
* Add service argument to aws provider, where service can be either ec2 or ecs (defaulting to ec2) * Add optional ecs_cluster and ecs_family arguments
This was referenced Jan 12, 2023
Merged
Merged
peczenyj
pushed a commit
to peczenyj/go-discover
that referenced
this pull request
Dec 21, 2023
author Jeff Widman <[email protected]> 1621366525 -0700 committer Tiago Peczenyj <[email protected]> 1703171978 +0100 Update tencent version Tencent pulled the previous tag of their API and switched to `v1` starting here: https://github.com/TencentCloud/tencentcloud-sdk-go#%E9%80%9A%E8%BF%87go-get%E5%AE%89%E8%A3%85%E6%8E%A8%E8%8D%90 As a result, currently `go get -d` is complaining in downstream repos, breaking Dependabot (among other things). So this fixes that. Fix hashicorp#172. Update CI badge to CircleCI The old badge was travis, and we have not used travis in some time. update dependency fix incompatibity issue hashicorp#183 Revert "fix incompatibity issue hashicorp#183" This reverts commit 986207c. Revert "update dependency" This reverts commit bc42ce5. update dependency github.com/denverdino/aliyungo fix incompatibity issue hashicorp#183 go mod tidy Add AWS SessionToken Support (hashicorp#189) * add support for SessionToken in AWS credential resolver * add AWS AssumeRole configuration to AWS tests Fix "Config options" links Apply suggestions from code review Co-authored-by: Blake Covarrubias <[email protected]> deps: bump Azure/go-autorest to remove transitive jwt-go dependency with known vulnerability (hashicorp#174) update dependency github.com/denverdino/aliyungo Add AWS SessionToken Support (hashicorp#189) * add support for SessionToken in AWS credential resolver * add AWS AssumeRole configuration to AWS tests Fix "Config options" links Apply suggestions from code review Co-authored-by: Blake Covarrubias <[email protected]> Add AWS endpoint definition as an option (hashicorp#194) Signed-off-by: obeyler <[email protected]> Feature/aws ecs support (hashicorp#197) * Add service argument to aws provider, where service can be either ec2 or ecs (defaulting to ec2) * Add optional ecs_cluster and ecs_family arguments Update tencentcloud-sdk-go modules Dependencies are available as individual go modules now. [COMPLIANCE] Update MPL 2.0 LICENSE Adding workflow .github/actions/acctest/action.yml .github/actions/tf-install/action.yml .github/workflows/acceptance.yml SHA-pin all 3rd-party actions Restrict workflow permissions Add actionslint Add dependabot Add CODEOWNERS Remove CircleCI configuration Remove unused local actions Update migration enable scleway acceptance test add success job add success job fix copy pasta Result of tsccr-helper -pin-all-workflows . Fix CVEs Need at least go 1.16 for the golang.org/x/net fixes Update github action to use go 1.16 Some dependencies needed 1.17 Set miekg/dns to 1.1.50 Result of tsccr-helper -log-level=info -pin-all-workflows . Update README.md Update README.md Update README.md Update README.md update vendor github.com/denverdino/aliyungo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add ECS support to AWS Go-Discover plugin.
Fixes: 6802
Revives/Simplifies PR #54
PR Checklist