Backport of Update go-discover to support ECS discovery into release/1.12.x #15964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/updates/go-discover/enormously-quick-boxer
branch
2 times, most recently
from
0686ae6
to
8e7022c
Compare
github-actions
bot
added
pr/dependencies
github-team-consul-core-pr-approver
approved these changes
Jan 12, 2023
Co-authored-by: trujillo-adam <[email protected]>
pglass
force-pushed
the
backport/updates/go-discover/enormously-quick-boxer
branch
from
8e7022c
to
914b1b9
Compare
pglass
deleted the
backport/updates/go-discover/enormously-quick-boxer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #13782 to be assessed for backporting due to the inclusion of the label backport/1.12.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
Description
Go-Discover now supports ECS container instance discovery. This change updates the go-discover dependency and corresponding documentation outlining new options.
Testing & Reproduction steps
test/load-ecs has been added with load testing capabilities for 25 vus at 10 minutes. see test/load-ecs/README.md for more info.test/load-ecs has been moved to terraform-aws-consul-ecs PR:139Links
Issue: GH-6802
Dependency: PR-197
PR Checklist
Overview of commits