Hardcode links to CCM to be false #20730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-hut
added
theme/ui
Remove changelog item for breaking Ui change - since CCM linking no longer exists
chris-hut
force-pushed
the
backport/remove-ctas-to-CCM
branch
from
da7c801 to
c77c306
Compare
|
@chris-hut do you have the link to the original PR approved by the team? thank you |
chris-hut
changed the title
|
@NicoletaPopoviciu sorry about that: #20732 |
NicoletaPopoviciu
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR just hardcodes all of the CTAS to never display - so we can ensure the 1.18 release does not display them!
We will pull all this code out in a follow up PR
Testing & Reproduction steps
Load the UI - see that there's no CTAs to Consul Cental
PR Against Main: #20732
Screenshots
References