Hardcode links to CCM to be false (#20730)

Hardcode links to CCM to be false - due to CCM deprecation Remove changelog item for breaking Ui change - since CCM linking no longer exists
hashicorp · Feb 26, 2024 · 349cec1 · 349cec1
1 parent fe8bbb3
commit 349cec1
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 7 deletions.
diff --git a/.changelog/20474.txt b/.changelog/20474.txt
diff --git a/ui/packages/consul-ui/app/components/hcp-nav-item/index.js b/ui/packages/consul-ui/app/components/hcp-nav-item/index.js
@@ -41,7 +41,8 @@ export default class HcpLinkItemComponent extends Component {
       return false;
     }
 
-    return true;
+    // With the death of Consul Central, we don't want to display the link nav item
+    return false;
   }
 
   get shouldShowBackToHcpItem() {

diff --git a/ui/packages/consul-ui/app/services/hcp-link-status.js b/ui/packages/consul-ui/app/services/hcp-link-status.js
@@ -14,7 +14,8 @@ export default class HcpLinkStatus extends Service {
   userDismissedBanner = false;
 
   get shouldDisplayBanner() {
-    return !this.userDismissedBanner && this.hasPermissionToLink;
+    // With the death of Consul Central, we don't want to display the link nav item
+    return false;
   }
 
   get hasPermissionToLink() {

diff --git a/ui/packages/consul-ui/tests/acceptance/link-to-hcp-test.js b/ui/packages/consul-ui/tests/acceptance/link-to-hcp-test.js
@@ -12,7 +12,7 @@ const linkToHcpSelector = '[data-test-link-to-hcp]';
 const linkToHcpBannerButtonSelector = '[data-test-link-to-hcp-banner-button]';
 const linkToHcpModalSelector = '[data-test-link-to-hcp-modal]';
 const linkToHcpModalCancelButtonSelector = '[data-test-link-to-hcp-modal-cancel-button]';
-module('Acceptance | link to hcp', function (hooks) {
+module.skip('Acceptance | link to hcp', function (hooks) {
   setupApplicationTest(hooks);
 
   hooks.beforeEach(function () {

diff --git a/ui/packages/consul-ui/tests/integration/components/hcp-nav-item-test.js b/ui/packages/consul-ui/tests/integration/components/hcp-nav-item-test.js
@@ -86,7 +86,7 @@ module('Integration | Component | hcp nav item', function (hooks) {
     });
   });
 
-  module('when rendered in self managed mode', function (hooks) {
+  module.skip('when rendered in self managed mode', function (hooks) {
     hooks.beforeEach(function () {
       this.owner.register(
         'service:env',