Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix filter_changed_files to not silently fail ;) #18723

Closed
wants to merge 2 commits into from
Closed

ci: fix filter_changed_files to not silently fail ;) #18723

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3db677d
ci: fix filter changed files to not silently fail ;)
nfi-hashicorp Sep 8, 2023
16da876
Merge branch 'main' into nfi-fix-go-test-check
nfi-hashicorp Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/scripts/filter_changed_files_go_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
# SPDX-License-Identifier: BUSL-1.1


set -euo pipefail
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't solve the underlying problem, but it should guard against a silent failure


# Get the list of changed files
files_to_check=$(git diff --name-only origin/$GITHUB_BASE_REF)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I'm betting $GITHUB_BASE_REF isn't set on merges to main. In that case, we should just diff HEAD vs HEAD^ I guess?


Expand Down