Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix filter_changed_files to not silently fail ;) #18723

Closed
wants to merge 2 commits into from
Closed

ci: fix filter_changed_files to not silently fail ;) #18723

wants to merge 2 commits into from

Conversation

nfi-hashicorp
Copy link
Collaborator

@nfi-hashicorp nfi-hashicorp commented Sep 8, 2023 •
edited
Loading

@github-actions github-actions bot added the theme/contributing Additions and enhancements to community contributing materials label Sep 8, 2023
@nfi-hashicorp nfi-hashicorp added pr/no-changelog PR does not need a corresponding .changelog entry backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. labels Sep 8, 2023
nfi-hashicorp
nfi-hashicorp commented Sep 8, 2023
View reviewed changes
.github/scripts/filter_changed_files_go_test.sh
@@ -1,5 +1,7 @@
#!/bin/bash

set -euo pipefail
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't solve the underlying problem, but it should guard against a silent failure

nfi-hashicorp
nfi-hashicorp commented Sep 8, 2023
View reviewed changes
.github/scripts/filter_changed_files_go_test.sh
@@ -1,5 +1,7 @@
#!/bin/bash

set -euo pipefail

# Get the list of changed files
files_to_check=$(git diff --name-only origin/$GITHUB_BASE_REF)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I'm betting $GITHUB_BASE_REF isn't set on merges to main. In that case, we should just diff HEAD vs HEAD^ I guess?

@nfi-hashicorp nfi-hashicorp requested a review from a team September 8, 2023 17:56
NiniOak
NiniOak reviewed Sep 18, 2023
View reviewed changes
Copy link
Contributor

@NiniOak NiniOak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be closed. See #18851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiniOak NiniOak NiniOak left review comments

Assignees
No one assigned
Labels
backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. pr/no-changelog PR does not need a corresponding .changelog entry theme/contributing Additions and enhancements to community contributing materials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nfi-hashicorp @NiniOak