Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checks: Add Interval and Timeout to API response #10717

Merged
merged 10 commits into from
Aug 3, 2021
Merged

checks: Add Interval and Timeout to API response #10717

merged 10 commits into from
Aug 3, 2021

Conversation

eculver
Copy link
Contributor

@eculver eculver commented Jul 28, 2021

This comes from a customer support ticket. The customer is requesting to include
more fields in the response for health checks. Specifically, they would like for
Interval and Timeout to be included.

Some historical context: #7330 and #1680.

@eculver eculver requested review from dnephin, freddygv and a team July 28, 2021 22:06
@github-actions github-actions bot added type/docs Documentation needs to be created/updated/clarified and removed theme/health-checks Health Check functionality labels Jul 28, 2021
@hashicorp-ci
Copy link
Contributor

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@vercel vercel bot temporarily deployed to Preview – consul-ui-staging July 28, 2021 22:11 Inactive
@vercel vercel bot temporarily deployed to Preview – consul July 28, 2021 22:11 Inactive
@eculver eculver requested review from a team and removed request for a team July 29, 2021 16:02
@eculver eculver merged commit 710bd90 into main Aug 3, 2021
@eculver eculver deleted the eculver/new-health-check-fields branch August 3, 2021 22:26
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/420662.

@hc-github-team-consul-core
Copy link
Collaborator

🍒❌ Cherry pick of commit 710bd90 onto stable-website failed! Build Log

@hc-github-team-consul-core
Copy link
Collaborator

🍒❌ Cherry pick of commit 710bd90 onto release/1.10.x failed! Build Log

freddygv pushed a commit that referenced this pull request Aug 18, 2021
@eculver @freddygv
checks: Add Interval and Timeout to API response (#10717)
06d2140
@freddygv freddygv mentioned this pull request Aug 18, 2021
Merged
freddygv added a commit that referenced this pull request Aug 18, 2021
@freddygv @eculver
checks: Add Interval and Timeout to API response (#10717) (#10868)
6db08dc 
Co-authored-by: Evan Culver <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kisunji kisunji kisunji approved these changes

@freddygv freddygv freddygv approved these changes

@dnephin dnephin Awaiting requested review from dnephin

Assignees
No one assigned
Labels
type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eculver @hashicorp-ci @hc-github-team-consul-core @freddygv @kisunji