Export health check definition via the API

[mmoya]

Right now you can know the state of a health check but not what is the health check itself, ie: the provided script/http line when registering it.

[CpuID]

@slackpad discussed this earlier today with you - no need to create a duplicate... :)

Need to determine what the HealthCheck type needs to look like, to augment it to expose the actual checks.

There were thoughts regarding future use of HCL from @sethvargo - and structuring the Go type/s to future proof it.

An initial brainstorm of a response JSON body would be something like:

[
  {
    "Node": "foobar",
    "CheckID": "service:redis",
    "Name": "Service 'redis' check",
    "Check": {
      "Type": "(Script|HTTP|TCP|TTL)",
      "Script": {
        "insertsomefieldshere": "true"
      },
      "HTTP": {
        "URL": "http://foobar:5000/health",
        "Interval": "10s",
        "Timeout": "1s"
      },
      "TCP": {
        "HostAndPort": "localhost:22",
        "Interval": "10s",
        "Timeout": "1s"
      },
      "TTL": {
        "insertsomefieldshere": "true"
      }
    },
    "Status": "passing",
    "Notes": "",
    "Output": "HTTP GET http://localhost:5000/health Output: \"healthy\"",
    "ServiceID": "redis",
    "ServiceName": "redis"
  }
]

Not super well thought out and I'm almost certain it will need to be tweaked, but something to start iterating against.

Related types:

• CheckTCP
• CheckHTTP

Things to consider:

• Expanding the single string key TCP and HTTP in each of the above types respectively to be pieces of a URI, or Hostname and Port separately. For example HTTP would become Scheme, Hostname, Port, URI. TCP would become Hostname and Port.

[CpuID]

Once the internal structure of the types is finalised, I can look at starting a PR for this.

[CpuID]

@slackpad bump :)

[slackpad]

Sorry for the delay on this! I'll pin this to an upcoming release so we can slot a little time for it.

[CpuID]

@slackpad great thx ;)

[CpuID]

@slackpad bump, I noticed it missed 0.7.3/0.7.4 :)

[ifuyivara]

Any updates on this? I'll be happy to take a look if no progress has been made yet

[CpuID]

+1 to getting some movement on this one.

[crhino]

Useful context in #623 (comment), pointing out that some endpoints have a buggy/incomplete implementation of this.

[maxiloEmmmm]

好了么。。。。Definition空的 /v1/agent/checks

我现在尝试

1. RegExp 匹配 Output
2. 分析得到host 和 port

或者

1. 后端生成config.json
2. 使用ansible playbook task部署到consul agent data-dir
3. consul reload
4. 扫描consul agent data-dir获取配置

还有什么好方法?

---

最后措施

1. 设置Definition->Notes
2. parse Notes

结束 剩下的就等接口恢复吧