Support passing extra arguments to injected envoy binary #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<Co-authored-by: Iryna Shustava [email protected]>
<Co-authored-by: Iryna Shustava [email protected]>
ndhanushkodi
requested review from
ishustava,
a team and
thisisnotashwin
and removed request for
a team
lkysow
reviewed
Nov 3, 2020
this commit will be squashed
ndhanushkodi
force-pushed
the
extra-envoy-args
branch
from
6068ce9 to
1fec181
Compare
ndhanushkodi
commented
Nov 6, 2020
There was a problem hiding this comment.
Re-requesting review: addressed PR comments, and added functionality to pass the envoy binary arguments via pod annotations as well.
Also planning to squash and merge this one when its ready since the git history on this one's a bit funky and there's a merge commit in here.
ndhanushkodi
changed the title
ishustava
approved these changes
Nov 6, 2020
ndhanushkodi
added a commit
to ndhanushkodi/consul-k8s
that referenced
this pull request
Nov 6, 2020
ndhanushkodi
pushed a commit
to ndhanushkodi/consul-k8s
that referenced
this pull request
Jul 9, 2021
Update annotation docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
You can set it via either one, but if you set the args both ways, the pod annotation arguments will be used.
How I've tested this PR:
gcr.io/nitya-293720/consul-k8s-dev:extraEnvoyArgs) and ran it on a cluster, while passing--log-level debugas an extra envoy flag, and saw that when we deployed a connect-inject enabled service, the envoy logs were showing debug logs.How I expect reviewers to test this PR:
Checklist: