This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Support passing extra arguments to injected envoy binary #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndhanushkodi
requested review from
ishustava,
a team and
lkysow
and removed request for
a team
ndhanushkodi
force-pushed
the
extra-envoy-args
branch
from
b5663ee
to
4328b74
Compare
ishustava
reviewed
Nov 6, 2020
There was a problem hiding this comment.
This looks great 🎉
The one thing that this needs is to add this new value to the values.yaml and document it with a comment, e.g. connectInject.imageConsul. This is the pattern we've been using with our helm chart for all other values and so I think we should follow it. We'll also need a changelog entry.
lkysow
reviewed
Nov 6, 2020
ndhanushkodi
force-pushed
the
extra-envoy-args
branch
from
4328b74
to
0a41688
Compare
|
Thanks for your comments! Re-requesting review for the changelog entry and values.yml comments. |
When a user sets connectInject.envoyExtraArgs value, they can send arguments to the injected envoy sidecar binary. For example, in a development environment, we could consider enabling debug logs in all sidecars. Usage: ``` connectInject: enabled: true envoyExtraArgs: "--log-level debug --disable-hot-restart" ```
ndhanushkodi
force-pushed
the
extra-envoy-args
branch
from
0a41688
to
c163481
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user sets
connectInject.envoyExtraArgsvalue, they can sendarguments to the injected envoy sidecar binary. For example, in a
development environment, we could consider enabling debug logs in all
sidecars.
Sample values file:
Corresponding consul-k8s PR: hashicorp/consul-k8s#378