Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

NET-4954: Remove/replace noncompliant actions #589

Merged
merged 3 commits into from
Jul 20, 2023
Merged

NET-4954: Remove/replace noncompliant actions #589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
056f353
Remove mxschmitt/action-tmate from conformance testing workflows
nathancoleman Jul 18, 2023
d2d5248
Remove workflow for preparing release
nathancoleman Jul 18, 2023
33700ba
Replace ravsamhq/notify-slack-action w/ official Slack action
nathancoleman Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 11 additions & 24 deletions .github/workflows/conformance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,7 @@ on:
schedule:
- cron: '0 0 * * *'

workflow_dispatch:
inputs:
debug_enabled:
description: 'Start tmate session if any step fails'
required: false
type: boolean
default: false # GitHub parses this value to string, see https://github.com/actions/runner/issues/1483
debug_timeout_minutes:
description: 'How many minutes should the tmate session close itself after?'
required: false
type: string # No support for numeric value
default: '10'
workflow_dispatch: {}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inputs were only used for controlling the tmux action, which we're no longer able to use


env:
GO_VERSION: "1.19"
Expand Down Expand Up @@ -123,21 +112,19 @@ jobs:
working-directory: "gateway-api/conformance"
run: go test -v -timeout 10m ./ --gateway-class=consul-api-gateway

- name: Setup tmate session
uses: mxschmitt/action-tmate@v3 # TSCCR: no entry for repository "mxschmitt/action-tmate"
if: failure() && github.event_name == 'workflow_dispatch' && github.event.inputs.debug_enabled == 'true'
timeout-minutes: ${{ fromJSON(github.event.inputs.debug_timeout_minutes) }}

- name: Report Status
- name: Report status
if: always() && github.ref == 'refs/heads/main'
uses: ravsamhq/notify-slack-action@v1 # TSCCR: no entry for repository "ravsamhq/notify-slack-action"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is being replaced by the official Slack action that now exists

with:
status: ${{ job.status }}
message_format: '{emoji} *{workflow}/${{ matrix.cluster-type }} - ${{ matrix.config.name }}* {status_message} in <{repo_url}|{repo}> on <{commit_url}|{commit_sha}>'
mention_groups: '!here'
mention_groups_when: 'failure,warnings'
uses: slackapi/slack-github-action@e28cf165c92ffef168d23c5c9000cffc8a25e117 # v1.24.0
env:
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK
SLACK_WEBHOOK_URL: ${{ secrets.ACTION_MONITORING_SLACK }}
with:
payload: |
{
"Message": "conformance/${{ matrix.cluster-type }} - ${{ matrix.config.name }} ${{ job.status }}",
"Repository": "<https://hashicorp/consul-api-gateway|hashicorp/consul-api-gateway>",
"Commit": "${{ github.sha }}",
}

- name: Tear down EKS cluster
if: always() && matrix.cluster-type == 'eks'
Expand Down
18 changes: 1 addition & 17 deletions .github/workflows/conformance_with_build.yml
View file
Open in desktop
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in this file mirror those in the conformance.yml file above, just without the Slack notification since this one runs on PRs

Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,7 @@ on:
push:
branches: ["conformance/*"]

workflow_dispatch:
inputs:
debug_enabled:
description: 'Start tmate session if any step fails'
required: false
type: boolean
default: false # GitHub parses this value to string, see https://github.com/actions/runner/issues/1483
debug_timeout_minutes:
description: 'How many minutes should the tmate session close itself after?'
required: false
type: string # No support for numeric value
default: '10'
workflow_dispatch: {}

env:
GO_VERSION: "1.19"
Expand Down Expand Up @@ -130,8 +119,3 @@ jobs:
- name: Run tests
working-directory: "gateway-api/conformance"
run: go test -v -timeout 10m ./ --gateway-class=consul-api-gateway

- name: Setup tmate session
uses: mxschmitt/action-tmate@v3 # TSCCR: no entry for repository "mxschmitt/action-tmate"
if: failure() && github.event_name == 'workflow_dispatch' && github.event.inputs.debug_enabled == 'true'
timeout-minutes: ${{ fromJSON(github.event.inputs.debug_timeout_minutes) }}
131 changes: 0 additions & 131 deletions .github/workflows/prepare_release.yml
View file
Open in desktop
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been unable to use this workflow for several releases now due to the default token assigned by GitHub Actions not having SSO enabled. Since we're not actively developing/releasing this repo anymore, I opted to just remove the workflow

This file was deleted.

4 changes: 0 additions & 4 deletions internal/testing/conformance/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,3 @@ need for these patches.

The conformance tests are run nightly in GitHub Actions using the workflow [here](/.github/workflows/conformance.yml).
You may also run the workflow on demand from this repo's Actions tab, by following the `conformance/*` branch naming convention, or by adding the `pr/run-conformance` label to your pull request.

## Tips

- If you need shell access to debug any steps in the workflow, [mxschmitt/action-tmate](https://github.com/mxschmitt/action-tmate) can be added before/after any step.
Loading